Hideyo\Ecommerce\Framework\Services\Attribute\AttributeService

Complexity

Total Complexity

16

Size/Duplication

Total Lines	148
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	selectAllGroups()	0	3	1
A	create()	0	15	2
A	updateById()	0	17	2
A	rules()	0	11	2
A	rulesGroup()	0	11	2
A	createGroup()	0	13	2
A	getGroupModel()	0	3	1
A	updateGroupById()	0	15	2
A	findGroup()	0	3	1
A	__construct()	0	4	1

<?php

namespace Hideyo\Ecommerce\Framework\Services\Attribute;

use Validator;
use Hideyo\Ecommerce\Framework\Services\Attribute\Entity\AttributeRepository;
use Hideyo\Ecommerce\Framework\Services\Attribute\Entity\AttributeGroupRepository;
use Hideyo\Ecommerce\Framework\Services\BaseService;
 
class AttributeService extends BaseService
{
	public function __construct(AttributeRepository $attribute, AttributeGroupRepository $attributeGroup)
	{
		$this->repo = $attribute;

The property repo does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		$this->repoGroup = $attributeGroup;		

The property repoGroup does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

	} 

    /**
     * laravel validation rules for attribute
     * @param  boolean $id 
     * @return array    
     */
    private function rules($id = false)
    {
        $rules = array(
            'value' => 'required|unique_with:'.$this->repo->getModel()->getTable().',attribute_group_id'
        );

        if ($id) {
            $rules['value'] = $rules['value'].','.$id;

Are you sure $id of type true can be used in concatenation?

        }

        return $rules;
    }

    /**
     * laravel validation rules for attributeGroup
     * @param  boolean $id 
     * @return array    
     */
    private function rulesGroup($id = false)
    {
        $rules = array(
            'title' => 'required|between:1,65|unique_with:'.$this->repoGroup->getModel()->getTable().', shop_id'
        );
        
        if ($id) {
            $rules['title'] =   $rules['title'].','.$id.' = id';

Are you sure $id of type true can be used in concatenation?

        }

        return $rules;
    }

    /**
     * create a attribute
     * @param  array  $attributes       
     * @param  integer $attributeGroupId 
     * @return mixed                   
     */
    public function create(array $attributes, $attributeGroupId)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

  		$attributes['attribute_group_id'] = $attributeGroupId;

        $validator = Validator::make($attributes, $this->rules());

        if ($validator->fails()) {
            return $validator;
        }

        $this->repo->getModel()->fill($attributes);
        $this->repo->getModel()->save();
        return $this->repo->getModel();
    }

    /**
     * create a attribute group
     * @param  array  $attributes        
     * @return mixed                   
     */    
    public function createGroup(array $attributes)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rulesGroup());

        if ($validator->fails()) {
            return $validator;
        }

        $this->repoGroup->getModel()->fill($attributes);
        $this->repoGroup->getModel()->save();
        return $this->repoGroup->getModel();
    }

    public function updateById(array $attributes, $attributeGroupId, $id)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $attributes['attribute_group_id'] = $attributeGroupId;
        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rules($id));
        
        if ($validator->fails()) {
            return $validator;
        }

        $model = $this->find($id);
        $model->fill($attributes);
        $model->save();

        return $model;    
    } 

    public function updateGroupById(array $attributes, $id)
    {
        $attributes['shop_id'] = auth('hideyobackend')->user()->selected_shop_id;

Accessing selected_shop_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $validator = Validator::make($attributes, $this->rulesGroup($id));
        if ($validator->fails()) {
            return $validator;
        }

        $model = $this->findGroup($id);
        $attributes['modified_by_user_id'] = auth('hideyobackend')->user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $model->fill($attributes);
        $model->save();

        return $model;    
    } 

    /**
     * select all attribute Groups
     * @return object
     */
    public function selectAllGroups()
    {
        return $this->repoGroup->selectAll();
    }

    /**
     * get attribute group model
     * @return object
     */
    public function getGroupModel()
    {
        return $this->repoGroup->getModel();
    }

    /**
     * find a attribute group model
     * @return object
     */
    public function findGroup($groupId)
    {
        return $this->repoGroup->find($groupId);
    }
}