Hhxsv5\LaravelS\Swoole\ChokidarWatchTrait::addChokidarWatchProcess()

Complexity

Conditions	6
Paths	5

Size

Total Lines	38
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function addChokidarWatchProcess(Server $swoole, array $config, array $laravelConf)

Missing doc comment for function addChokidarWatchProcess()

    {
        if (empty($config['enable'])) {
            return false;
        }

        $watchPathFiles = isset($config['watch_path_files']) ? (array)$config['watch_path_files'] : [];
        if (empty($watchPathFiles)) {
            $this->warning('No file to watch by chokidar');

It seems like warning() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return false;
        }

        $callback = function (Process $worker) use ($config, $laravelConf, $watchPathFiles) {
            $log = !empty($config['log']);
            $watch_base_path = $config['watch_base_path'];
            $this->setProcessTitle(sprintf('%s laravels: chokidar process', $config['process_prefix']));

It seems like setProcessTitle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $nodeExecutable = (new ExecutableFinder)->find('node');
            $nodeScriptPath = realpath(__DIR__.'/../../bin/file-watcher.cjs');
            $this->info(sprintf('$nodeScriptPath: %s', $nodeScriptPath));

It seems like info() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $watchOptions = isset($config['watch_options']) ? (array)$config['watch_options'] : ['ignoreInitial' => true];
            $worker->exec($nodeExecutable, [$nodeScriptPath,

The opening parenthesis of a multi-line function call should be the last content on the line.

                json_encode(collect($watchPathFiles)->map(fn ($path) => $watch_base_path.'/'.$path)),

The function collect was not found. Maybe you did not declare it correctly or list all dependencies?

                json_encode($watchOptions),
            ]);

For multi-line function calls, the closing parenthesis should be on a new line.

            // 获取 Node.js 脚本的输出
            tap($worker->read(), function ($output) use ($log, $laravelConf) {

The function tap was not found. Maybe you did not declare it correctly or list all dependencies?

The opening parenthesis of a multi-line function call should be the last content on the line.

                Portal::runLaravelSCommand($laravelConf['root_path'], 'reload');
                if ($log) {
                    $this->info(sprintf('reloaded by chokidar, reason: %s', $output));
                }
            });

For multi-line function calls, the closing parenthesis should be on a new line.

        };

        $process = new Process($callback, false, 0);
        $swoole->addProcess($process);
        return $process;
    }