Hhxsv5\LaravelS\Swoole\Timer\TimerTrait::addTimerProcess()

Complexity

Conditions	13
Paths	3

Size

Total Lines	59
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function addTimerProcess(Server $swoole, array $config, array $laravelConfig)
    {
        if (empty($config['enable']) || empty($config['jobs'])) {
            return;
        }

        $startTimer = function (Process $process) use ($swoole, $config, $laravelConfig) {
            $pidfile = dirname($swoole->setting['pid_file']) . '/laravels-timer-process.pid';
            file_put_contents($pidfile, $process->pid);
            $this->setProcessTitle(sprintf('%s laravels: timer process', $config['process_prefix']));

It seems like setProcessTitle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->initLaravel($laravelConfig, $swoole);

It seems like initLaravel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $timerIds = [];
            foreach ($config['jobs'] as $jobClass) {
                if (is_array($jobClass) && isset($jobClass[0])) {
                    $job = new $jobClass[0](isset($jobClass[1]) ? $jobClass[1] : []);
                } else {
                    $job = new $jobClass();
                }
                if (!($job instanceof CronJob)) {
                    throw new \InvalidArgumentException(sprintf(
                            '%s must extend the abstract class %s',
                            get_class($job),
                            CronJob::class
                        )
                    );
                }
                if (empty($job->interval())) {
                    throw new \InvalidArgumentException(sprintf('The interval of %s cannot be empty', get_class($job)));
                }
                $runProcess = function () use ($job) {
                    $runCallback = function () use ($job) {
                        $this->callWithCatchException(function () use ($job) {

It seems like callWithCatchException() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                            $job->run();
                        });
                    };
                    class_exists('Swoole\Coroutine') ? go($runCallback) : $runCallback();
                };

                $timerId = Timer::tick($job->interval(), $runProcess);
                $timerIds[] = $timerId;
                $job->setTimerId($timerId);
                if ($job->isImmediate()) {
                    Timer::after(1, $runProcess);
                }
            }

            Process::signal(SIGUSR1, function ($signo) use ($config, $timerIds, $process) {

The parameter $signo is not used and could be removed.

                foreach ($timerIds as $timerId) {
                    Timer::clear($timerId);
                }
                Timer::after($config['max_wait_time'] * 1000, function () use ($process) {
                    $process->exit(0);
                });
            });
        };

        $timerProcess = new Process($startTimer, false, false);
        if ($swoole->addProcess($timerProcess)) {

Are you sure the usage of $swoole->addProcess($timerProcess) targeting Swoole\Server::addProcess() seems to always return null.

            return $timerProcess;
        }
}