Hhxsv5\LaravelS\Swoole\Traits\CustomProcessTrait::addCustomProcesses()

Complexity

Conditions	6
Paths	4

Size

Total Lines	46
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function addCustomProcesses(\swoole_server $swoole, $processPrefix, array $processes, array $laravelConfig)
    {
        Laravel::autoload($laravelConfig['root_path']);

        /**
         * @var []CustomProcessInterface $processList
         */
        $processList = [];
        foreach ($processes as $process) {
            if (!isset(class_implements($process)[CustomProcessInterface::class])) {
                throw new \Exception(sprintf(
                        '%s must implement the interface %s',
                        $process,
                        CustomProcessInterface::class
                    )
                );
            }
            $processHandler = function () use ($swoole, $processPrefix, $process, $laravelConfig) {
                // Inject the global variables
                $_SERVER = $laravelConfig['_SERVER'];
                $_ENV = $laravelConfig['_ENV'];

                $name = $process::getName() ?: 'custom';
                $this->setProcessTitle(sprintf('%s laravels: %s process', $processPrefix, $name));
                $this->initLaravel($laravelConfig, $swoole);

It seems like initLaravel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $maxTry = 10;
                $i = 0;
                do {
                    $this->callWithCatchException(function () use ($process, $swoole) {
                        return $process::callback($swoole);
                    });
                    ++$i;
                    sleep(1);
                } while ($i < $maxTry);
                $this->log(sprintf('The custom process "%s" reaches maximum number of retries, and will be restarted by the manager process.', $name), 'WARN');
            };
            $customProcess = new \swoole_process(
                $processHandler,
                $process::isRedirectStdinStdout(),
                $process::getPipeType()
            );
            if ($swoole->addProcess($customProcess)) {

Are you sure the usage of $swoole->addProcess($customProcess) targeting Swoole\Server::addProcess() seems to always return null.

                $processList[] = $customProcess;
            }
        }
        return $processList;
    }