Hhxsv5\LaravelS\Swoole\Process\CustomProcessTrait::addCustomProcesses()

Complexity

Conditions	14
Paths	18

Size

Total Lines	79
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes	9
Bugs	0	Features	1

<?php
    public function addCustomProcesses(Server $swoole, $processPrefix, array $processes, array $laravelConfig)

Missing doc comment for function addCustomProcesses()

    {
        $pidfile = dirname($swoole->setting['pid_file']) . '/' . $this->customProcessPidFile;
        if (file_exists($pidfile)) {
            unlink($pidfile);
        }

        /**@var []CustomProcessInterface $processList */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

        $processList = [];
        foreach ($processes as $name => $item) {
            if (empty($item['class'])) {
                throw new \InvalidArgumentException(sprintf(

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'process class name must be specified'

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 24.

                    )

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 20.

                );
            }
            if (isset($item['enable']) && !$item['enable']) {
                continue;
            }
            $processClass = $item['class'];
            $restartInterval = isset($item['restart_interval']) ? (int)$item['restart_interval'] : 5;
            $callback = function (Process $worker) use ($pidfile, $swoole, $processPrefix, $processClass, $restartInterval, $name, $laravelConfig) {
                file_put_contents($pidfile, $worker->pid . "\n", FILE_APPEND | LOCK_EX);
                $this->initLaravel($laravelConfig, $swoole);

It seems like initLaravel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                if (!isset(class_implements($processClass)[CustomProcessInterface::class])) {
                    throw new \InvalidArgumentException(
                        sprintf(
                            '%s must implement the interface %s',
                            $processClass,
                            CustomProcessInterface::class
                        )
                    );
                }
                /**@var CustomProcessInterface $processClass */

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

                $this->setProcessTitle(sprintf('%s laravels: %s process', $processPrefix, $name));

It seems like setProcessTitle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                Process::signal(SIGUSR1, function ($signo) use ($name, $processClass, $worker, $pidfile, $swoole) {

The parameter $signo is not used and could be removed.

The import $pidfile is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                    $this->info(sprintf('Reloading %s process[PID=%d].', $name, $worker->pid));

It seems like info() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    $processClass::onReload($swoole, $worker);
                });

For multi-line function calls, the closing parenthesis should be on a new line.

                if (method_exists($processClass, 'onStop')) {
                    Process::signal(SIGTERM, function ($signo) use ($name, $processClass, $worker, $pidfile, $swoole) {

The import $pidfile is not used and could be removed.

The parameter $signo is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                        $this->info(sprintf('Stopping %s process[PID=%d].', $name, $worker->pid));
                        $processClass::onStop($swoole, $worker);
                    });

For multi-line function calls, the closing parenthesis should be on a new line.

                }

                if (class_exists('Swoole\Runtime')) {
                    \Swoole\Runtime::enableCoroutine();
                }

                $this->callWithCatchException([$processClass, 'callback'], [$swoole, $worker]);

It seems like callWithCatchException() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                // Avoid frequent process creation
                if (class_exists('Swoole\Coroutine')) {
                    \Swoole\Coroutine::sleep($restartInterval);
                } else {
                    sleep($restartInterval);
                }
            };

            // for multiple processes
            if (isset($item['num']) && $item['num'] > 1) {
                for ($i = 0; $i < $item['num']; $i++) {
                    $process = $this->makeProcess($callback, $item);
                    $swoole->addProcess($process);
                    $processList[$name . $i] = $process;
                }

                return $processList;
            }

            // for single process
            $process = $this->makeProcess($callback, $item);
            $swoole->addProcess($process);
            $processList[$name] = $process;
        }
        return $processList;
    }