Hhxsv5\LaravelS\Swoole\Traits\CustomProcessTrait::addCustomProcesses()

Complexity

Conditions	12
Paths	12

Size

Total Lines	75
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function addCustomProcesses(Server $swoole, $processPrefix, array $processes, array $laravelConfig)
    {
        /**@var []CustomProcessInterface $processList */
        $processList = [];
        foreach ($processes as $item) {
            if (is_string($item)) {
                // Backwards compatible
                Laravel::autoload($laravelConfig['root_path']);
                $process = $item;
                $redirect = $process::isRedirectStdinStdout();
                $pipe = $process::getPipeType();
            } else {
                if (empty($item['class'])) {
                    throw new \InvalidArgumentException(sprintf(
                            'process class name must be specified'
                        )
                    );
                }
                $process = $item['class'];
                $redirect = isset($item['redirect']) ? $item['redirect'] : false;
                $pipe = isset($item['pipe']) ? $item['pipe'] : 0;
            }

            $processHandler = function (Process $worker) use ($swoole, $processPrefix, $process, $laravelConfig) {
                if (!isset(class_implements($process)[CustomProcessInterface::class])) {
                    throw new \InvalidArgumentException(
                        sprintf(
                            '%s must implement the interface %s',
                            $process,
                            CustomProcessInterface::class
                        )
                    );
                }
                $name = $process::getName() ?: 'custom';
                $this->setProcessTitle(sprintf('%s laravels: %s process', $processPrefix, $name));
                $this->initLaravel($laravelConfig, $swoole);

It seems like initLaravel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                Process::signal(SIGUSR1, function ($signo) use ($name, $process, $worker, $swoole) {

The parameter $signo is not used and could be removed.

                    $this->info(sprintf('Reloading the process %s [pid=%d].', $name, $worker->pid));
                    $process::onReload($swoole, $worker);
                });

                $enableCoroutine = class_exists('Swoole\Coroutine');
                $runProcess = function () use ($name, $process, $swoole, $worker, $enableCoroutine) {
                    $maxTry = 10;
                    $i = 0;
                    do {
                        $this->callWithCatchException([$process, 'callback'], [$swoole, $worker]);
                        ++$i;
                        if ($enableCoroutine) {
                            \Swoole\Coroutine::sleep(1);
                        } else {
                            sleep(1);
                        }
                    } while ($i < $maxTry);
                    $this->error(
                        sprintf(
                            'The custom process "%s" reaches the maximum number of retries %d times, and will be restarted by the manager process.',
                            $name,
                            $maxTry
                        )
                    );
                };
                $enableCoroutine ? go($runProcess) : $runProcess();;
            };
            $customProcess = new Process(
                $processHandler,
                $redirect,
                $pipe
            );
            if ($swoole->addProcess($customProcess)) {

Are you sure the usage of $swoole->addProcess($customProcess) targeting Swoole\Server::addProcess() seems to always return null.

                $processList[] = $customProcess;
            }
        }
        return $processList;
    }