Hhxsv5\LaravelS\Components\HttpClient\SimpleHttpTrait::httpGet()

Complexity

Conditions	18
Paths	62

Size

Total Lines	71
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function httpGet($url, array $options)
    {
        if (Context::inCoroutine()) {
            $parts = parse_url($url);
            $path = isset($parts['path']) ? $parts['path'] : '/';
            if (isset($parts['query'])) {
                $path .= '?' . $parts['query'];
            }
            if (isset($parts['fragment'])) {
                $path .= '#' . $parts['fragment'];
            }
            $client = new CoroutineClient($parts['host'], isset($parts['port']) ? $parts['port'] : 80, isset($parts['scheme']) && $parts['scheme'] === 'https');
            if (isset($options['timeout'])) {
                $client->set([
                    'timeout' => $options['timeout'],
                ]);
            }
            $client->get($path);
            $client->close();
            if ($client->errCode === 110) {
                return ['statusCode' => 0, 'headers' => [], 'body' => ''];
            }
            if ($client->errCode !== 0) {
                $msg = sprintf('Failed to send Http request(%s), errcode=%d, errmsg=%s', $url, $client->errCode, $client->errMsg);

The property errMsg does not seem to exist on Swoole\Coroutine\Http\Client.

                throw new \RuntimeException($msg, $client->errCode);
            }
            return ['statusCode' => $client->statusCode, 'headers' => $client->headers, 'body' => $client->body];
        } else {
            $handle = curl_init();
            $finalOptions = [
                    CURLOPT_URL     => $url,
                    CURLOPT_HTTPGET => true,
                ] + $this->curlOptions;
            if (isset($options['timeout'])) {
                $finalOptions[CURLOPT_TIMEOUT] = $options['timeout'];
            }
            curl_setopt_array($handle, $finalOptions);

It seems like $handle can also be of type false; however, parameter $ch of curl_setopt_array() does only seem to accept resource, maybe add an additional type check?

            $responseStr = curl_exec($handle);

It seems like $handle can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            $errno = curl_errno($handle);

It seems like $handle can also be of type false; however, parameter $ch of curl_errno() does only seem to accept resource, maybe add an additional type check?

            $errmsg = curl_error($handle);

It seems like $handle can also be of type false; however, parameter $ch of curl_error() does only seem to accept resource, maybe add an additional type check?

            // Fix: curl_errno() always return 0 when fail
            if ($errno !== 0 || $errmsg !== '') {
                curl_close($handle);

It seems like $handle can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

                $msg = sprintf('Failed to send Http request(%s), errcode=%d, errmsg=%s', $url, $errno, $errmsg);
                throw new \RuntimeException($msg, $errno);
            }

            $headerSize = curl_getinfo($handle, CURLINFO_HEADER_SIZE);

It seems like $handle can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

            $statusCode = curl_getinfo($handle, CURLINFO_HTTP_CODE);
            curl_close($handle);

            $header = substr($responseStr, 0, $headerSize);
            $body = substr($responseStr, $headerSize);
            $lines = explode("\n", $header);
            array_shift($lines); // Remove status

            $headers = [];
            foreach ($lines as $part) {
                $middle = explode(':', $part);
                $key = trim($middle[0]);
                if ($key === '') {
                    continue;
                }
                if (isset($headers[$key])) {
                    $headers[$key] = (array)$headers[$key];
                    $headers[$key][] = isset($middle[1]) ? trim($middle[1]) : '';
                } else {
                    $headers[$key] = isset($middle[1]) ? trim($middle[1]) : '';
                }
            }
            return ['statusCode' => $statusCode, 'headers' => $headers, 'body' => $body];
        }
}