Hhxsv5\LaravelS\Swoole\Timer\TimerTrait::registerTimers()

Complexity

Conditions	11
Paths	9

Size

Total Lines	39
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function registerTimers(array $jobs)

Missing doc comment for function registerTimers()

    {
        $timerIds = [];
        foreach ($jobs as $jobClass) {
            if (is_array($jobClass) && isset($jobClass[0])) {
                $job = new $jobClass[0](isset($jobClass[1]) ? $jobClass[1] : []);
            } else {
                $job = new $jobClass();
            }
            if (!($job instanceof CronJob)) {
                throw new \InvalidArgumentException(sprintf(

The opening parenthesis of a multi-line function call should be the last content on the line.

                        '%s must extend the abstract class %s',

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 24.

                        get_class($job),

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 24.

                        CronJob::class

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 24.

                    )

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 20.

                );
            }
            if (empty($job->interval())) {
                throw new \InvalidArgumentException(sprintf('The interval of %s cannot be empty', get_class($job)));
            }
            $runJob = function () use ($job) {
                $runCallback = function () use ($job) {
                    $this->callWithCatchException(function () use ($job) {

It seems like callWithCatchException() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The opening parenthesis of a multi-line function call should be the last content on the line.

                        if (($job instanceof CheckGlobalTimerAliveCronJob) || $job::isEnable()) {
                            $job->run();
                        }
                    });

For multi-line function calls, the closing parenthesis should be on a new line.

                };
                class_exists('Swoole\Coroutine') ? \Swoole\Coroutine::create($runCallback) : $runCallback();
            };

            $timerId = Timer::tick($job->interval(), $runJob);
            $timerIds[] = $timerId;
            $job->setTimerId($timerId);
            if ($job->isImmediate()) {
                Timer::after(1, $runJob);
            }
        }
        return $timerIds;
    }
}