Hhxsv5\LaravelS\Swoole\Timer\TimerTrait::addTimerProcess()

Complexity

Conditions	7
Paths	3

Size

Total Lines	46
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	8
Bugs	1	Features	1

<?php
    public function addTimerProcess(Server $swoole, array $config, array $laravelConfig)

Missing doc comment for function addTimerProcess()

    {
        if (empty($config['enable']) || empty($config['jobs'])) {
            return false;
        }

        // Add backup cron job.
        $config['jobs'][] = BackupCronJob::class;
        if (!empty($config['global_lock'])) {
            // Add auxiliary jobs for global timer.
            $config['jobs'][] = RenewGlobalTimerLockCronJob::class;
            $config['jobs'][] = CheckGlobalTimerAliveCronJob::class;
        }

        $callback = function (Process $process) use ($swoole, $config, $laravelConfig) {
            $pidfile = dirname($swoole->setting['pid_file']) . '/' . $this->timerPidFile;
            file_put_contents($pidfile, $process->pid);
            $this->setProcessTitle(sprintf('%s laravels: timer process', $config['process_prefix']));

It seems like setProcessTitle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->initLaravel($laravelConfig, $swoole);

It seems like initLaravel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            // Implement global timer by Cache lock.
            if (!empty($config['global_lock'])) {
                CronJob::setGlobalTimerLockKey($config['global_lock_key']);
                CronJob::checkSetEnable();
            }

            $timerIds = $this->registerTimers($config['jobs']);

            Process::signal(SIGUSR1, function ($signo) use ($config, $timerIds, $process) {

The parameter $signo is not used and could be removed.

The opening parenthesis of a multi-line function call should be the last content on the line.

                foreach ($timerIds as $timerId) {
                    if (Timer::exists($timerId)) {
                        Timer::clear($timerId);
                    }
                }
                Timer::after($config['max_wait_time'] * 1000, function () use ($process) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                    $process->exit(0);
                });

For multi-line function calls, the closing parenthesis should be on a new line.

            });

For multi-line function calls, the closing parenthesis should be on a new line.

            // For Swoole 4.6.x
            // Deprecated: Swoole\Event::rshutdown(): Event::wait() in shutdown function is deprecated in Unknown on line 0
            Event::wait();
        };

        $process = new Process($callback, false, 0);
        $swoole->addProcess($process);
        return $process;
    }
}