Hhxsv5\LaravelS\Swoole\InotifyTrait::addInotifyProcess()

Complexity

Conditions	12
Paths	6

Size

Total Lines	62
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

<?php
    public function addInotifyProcess(Server $swoole, array $config, array $laravelConf)

Missing doc comment for function addInotifyProcess()

    {
        if (empty($config['enable'])) {
            return false;
        }

        if (!extension_loaded('inotify')) {
            $this->warning('Require extension inotify');

It seems like warning() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return false;
        }

        $fileTypes = isset($config['file_types']) ? (array)$config['file_types'] : [];
        if (empty($fileTypes)) {
            $this->warning('No file types to watch by inotify');
            return false;
        }

        $callback = function () use ($config, $laravelConf) {
            $log = !empty($config['log']);
            $this->setProcessTitle(sprintf('%s laravels: inotify process', $config['process_prefix']));

It seems like setProcessTitle() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $inotify = new Inotify($config['watch_path'], IN_CREATE | IN_DELETE | IN_MODIFY | IN_MOVE,

The opening parenthesis of a multi-line function call should be the last content on the line.

                function ($event) use ($log, $laravelConf) {
                    Portal::runLaravelSCommand($laravelConf['root_path'], 'reload');
                    if ($log) {
                        $action = 'file:';
                        switch ($event['mask']) {
                            case IN_CREATE:

Line indented incorrectly; expected 24 spaces, found 28

                                $action = 'create';
                                break;
                            case IN_DELETE:

Line indented incorrectly; expected 24 spaces, found 28

                                $action = 'delete';
                                break;
                            case IN_MODIFY:

Line indented incorrectly; expected 24 spaces, found 28

                                $action = 'modify';
                                break;
                            case IN_MOVE:

Line indented incorrectly; expected 24 spaces, found 28

                                $action = 'move';
                                break;
                        }
                        $this->info(sprintf('reloaded by inotify, reason: %s %s', $action, $event['name']));

It seems like info() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                    }
                });

This line of the multi-line function call does not seem to be indented correctly. Expected 12 spaces, but found 16.

For multi-line function calls, the closing parenthesis should be on a new line.

            $inotify->addFileTypes($config['file_types']);
            if (empty($config['excluded_dirs'])) {
                $config['excluded_dirs'] = [];
            }
            $inotify->addExcludedDirs($config['excluded_dirs']);
            $inotify->watch();
            if ($log) {
                $this->info(sprintf('[Inotify] watched files: %d; file types: %s; excluded directories: %s',

The opening parenthesis of a multi-line function call should be the last content on the line.

                        $inotify->getWatchedFileCount(),

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 24.

                        implode(',', $config['file_types']),

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 24.

                        implode(',', $config['excluded_dirs'])

This line of the multi-line function call does not seem to be indented correctly. Expected 20 spaces, but found 24.

                    )

This line of the multi-line function call does not seem to be indented correctly. Expected 16 spaces, but found 20.

                );
            }
            $inotify->start();
        };

        $process = new Process($callback, false, 0);
        $swoole->addProcess($process);
        return $process;
    }
}