FileSystemAdapterTest::test_getExtension() - Code Metrics - Inspection of "first mining command and analysis command, to get..." - hgraca/php-phorensic - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9251f2...ca8fc4 )

by Herberto

created 2017-01-03 20:35 UTC

FileSystemAdapterTest::test_getExtension() A

↳ Parent: FileSystemAdapterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	2

<?php

namespace Hgraca\Phorensic\Test\SharedKernel\Port\FileSystem\Adapter\FileSystem;

use Hgraca\FileSystem\Exception\FileNotFoundException;
use Hgraca\FileSystem\Exception\InvalidPathException;
use Hgraca\FileSystem\FileSystemInterface;
use Hgraca\Phorensic\SharedKernel\Port\FileSystem\Adapter\FileSystem\FileSystemAdapter;
use Mockery;
use Mockery\MockInterface;
use PHPUnit_Framework_TestCase;

final class FileSystemAdapterTest extends PHPUnit_Framework_TestCase
{
    /**
     * @var MockInterface|FileSystemInterface
     */
    private $fileSystemMock;

    /**
     * @var FileSystemAdapter
     */
    private $adapter;

    /**
     * @before
     */
    public function setUpAdapter()
    {
        $this->fileSystemMock = Mockery::mock(FileSystemInterface::class);
        $this->adapter = new FileSystemAdapter($this->fileSystemMock);
    }

    /**
     * @test
     *
     * @small
     */
    public function readFile()
    {
        $path = 'some/path/to/file';
        $this->fileSystemMock->shouldReceive('readFile')->once()->with($path)->andReturn('some content');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->adapter->readFile($path);
    }

    /**
     * @test
     *
     * @small
     *
     * @expectedException \Hgraca\Phorensic\SharedKernel\Port\FileSystem\Exception\InvalidPathException
     */
    public function readFile_ThrowsExceptionIfInvalidPath()

    {
        $path = 'some/path/to/file';
        $this->fileSystemMock->shouldReceive('readFile')->once()->with($path)->andThrow(InvalidPathException::class);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->adapter->readFile($path);
    }

    /**
     * @test
     *
     * @small
     *
     * @expectedException \Hgraca\Phorensic\SharedKernel\Port\FileSystem\Exception\FileNotFoundException
     */
    public function readFile_ThrowsExceptionIfPathNotFound()

    {
        $path = 'some/path/to/file';
        $this->fileSystemMock->shouldReceive('readFile')->once()->with($path)->andThrow(FileNotFoundException::class);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->adapter->readFile($path);
    }

    /**
     * @dataProvider dataProvider_test_getExtension
     */
    public function test_getExtension(string $path, string $expectedExtension)
    {
        $adapter = new FileSystemAdapter();

        self::assertEquals($expectedExtension, $adapter->getExtension($path));
    }

    public function dataProvider_test_getExtension()
    {
        return [
            ['/a/dir/fileA', ''],
            ['/a/dir/fileA.php', 'php'],
            ['/a/dir/fileA.bladibla', 'bladibla'],
        ];
    }
}


1		<?php
2
3		namespace Hgraca\Phorensic\Test\SharedKernel\Port\FileSystem\Adapter\FileSystem;
4
5		use Hgraca\FileSystem\Exception\FileNotFoundException;
6		use Hgraca\FileSystem\Exception\InvalidPathException;
7		use Hgraca\FileSystem\FileSystemInterface;
8		use Hgraca\Phorensic\SharedKernel\Port\FileSystem\Adapter\FileSystem\FileSystemAdapter;
9		use Mockery;
10		use Mockery\MockInterface;
11		use PHPUnit_Framework_TestCase;
12
13		final class FileSystemAdapterTest extends PHPUnit_Framework_TestCase
14		{
15		/**
16		* @var MockInterface\|FileSystemInterface
17		*/
18		private $fileSystemMock;
19
20		/**
21		* @var FileSystemAdapter
22		*/
23		private $adapter;
24
25		/**
26		* @before
27		*/
28		public function setUpAdapter()
29		{
30		$this->fileSystemMock = Mockery::mock(FileSystemInterface::class);
31		$this->adapter = new FileSystemAdapter($this->fileSystemMock);
32		}
33
34		/**
35		* @test
36		*
37		* @small
38		*/
39		public function readFile()
40		{
41		$path = 'some/path/to/file';
42		$this->fileSystemMock->shouldReceive('readFile')->once()->with($path)->andReturn('some content');
		0 ignored issues – show Bug introduced 2017-01-03 20:38 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `Hgraca\FileSystem\FileSystemInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43
44		$this->adapter->readFile($path);
45		}
46
47		/**
48		* @test
49		*
50		* @small
51		*
52		* @expectedException \Hgraca\Phorensic\SharedKernel\Port\FileSystem\Exception\InvalidPathException
53		*/
54	View Code Duplication	public function readFile_ThrowsExceptionIfInvalidPath()
		0 ignored issues – show Duplication introduced 2017-01-03 20:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		$path = 'some/path/to/file';
57		$this->fileSystemMock->shouldReceive('readFile')->once()->with($path)->andThrow(InvalidPathException::class);
		0 ignored issues – show Bug introduced 2017-01-03 20:38 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `Hgraca\FileSystem\FileSystemInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
58
59		$this->adapter->readFile($path);
60		}
61
62		/**
63		* @test
64		*
65		* @small
66		*
67		* @expectedException \Hgraca\Phorensic\SharedKernel\Port\FileSystem\Exception\FileNotFoundException
68		*/
69	View Code Duplication	public function readFile_ThrowsExceptionIfPathNotFound()
		0 ignored issues – show Duplication introduced 2017-01-03 20:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		$path = 'some/path/to/file';
72		$this->fileSystemMock->shouldReceive('readFile')->once()->with($path)->andThrow(FileNotFoundException::class);
		0 ignored issues – show Bug introduced 2017-01-03 20:38 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `Hgraca\FileSystem\FileSystemInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
73
74		$this->adapter->readFile($path);
75		}
76
77		/**
78		* @dataProvider dataProvider_test_getExtension
79		*/
80		public function test_getExtension(string $path, string $expectedExtension)
81		{
82		$adapter = new FileSystemAdapter();
83
84		self::assertEquals($expectedExtension, $adapter->getExtension($path));
85		}
86
87		public function dataProvider_test_getExtension()
88		{
89		return [
90		['/a/dir/fileA', ''],
91		['/a/dir/fileA.php', 'php'],
92		['/a/dir/fileA.bladibla', 'bladibla'],
93		];
94		}
95		}
96

hgraca / php-phorensic

Push — master ( 9251f2...ca8fc4 )

FileSystemAdapterTest::test_getExtension() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like