GitAdapterUnitTest::findMostChangedFiles() - Code Metrics - hgraca/php-phorensic - Measure and Improve Code Quality continuously with Scrutinizer

GitAdapterUnitTest::findMostChangedFiles() A
last analyzed 2017-01-03 20:38 UTC

↳ Parent: GitAdapterUnitTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	0

<?php

namespace Hgraca\Phorensic\Test\Miner\Vcs\Git;

use Hgraca\Phorensic\Miner\Vcs\Git\Console\ShellAdapter;
use Hgraca\Phorensic\Miner\Vcs\Git\ConsoleInterface;
use Hgraca\Phorensic\Miner\Vcs\Git\GitAdapter;
use Mockery;
use Mockery\MockInterface;
use PHPUnit_Framework_TestCase;

final class GitAdapterUnitTest extends PHPUnit_Framework_TestCase
{
    /** @var GitAdapter */
    private $adapter;

    /** @var string */
    private $repoPath;

    /** @var MockInterface|ShellAdapter */
    private $shell;

    /**
     * @before
     */
    public function setUpAdapter()
    {
        $this->repoPath = 'a/dummy/path';
        $this->shell = Mockery::mock(ConsoleInterface::class);
        $this->adapter = new GitAdapter($this->shell);
    }

    /**
     * @test
     *
     * @small
     */
    public function findMostChangedFiles()
    {
        $since = 'last month';
        $this->shell->shouldReceive('gitEffort')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->once()
            ->with($this->repoPath, $since)
            ->andReturn(file_get_contents(__DIR__ . '/GitAdapterUnitTest.findMostChangedFiles.in.sh'));

        $expected = include __DIR__ . '/GitAdapterUnitTest.findMostChangedFiles.out.php';

        self::assertEquals(
            $expected,
            $this->adapter->findMostChangedFiles($this->repoPath, $since)
        );
    }
}


1			<?php
2
3			namespace Hgraca\Phorensic\Test\Miner\Vcs\Git;
4
5			use Hgraca\Phorensic\Miner\Vcs\Git\Console\ShellAdapter;
6			use Hgraca\Phorensic\Miner\Vcs\Git\ConsoleInterface;
7			use Hgraca\Phorensic\Miner\Vcs\Git\GitAdapter;
8			use Mockery;
9			use Mockery\MockInterface;
10			use PHPUnit_Framework_TestCase;
11
12			final class GitAdapterUnitTest extends PHPUnit_Framework_TestCase
13			{
14			/** @var GitAdapter */
15			private $adapter;
16
17			/** @var string */
18			private $repoPath;
19
20			/** @var MockInterface\|ShellAdapter */
21			private $shell;
22
23			/**
24			* @before
25			*/
26			public function setUpAdapter()
27			{
28			$this->repoPath = 'a/dummy/path';
29			$this->shell = Mockery::mock(ConsoleInterface::class);
30			$this->adapter = new GitAdapter($this->shell);
31			}
32
33			/**
34			* @test
35			*
36			* @small
37			*/
38			public function findMostChangedFiles()
39			{
40			$since = 'last month';
41			$this->shell->shouldReceive('gitEffort')
			0 ignored issues – show Bug introduced 2017-01-03 20:38 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `Hgraca\Phorensic\Miner\V...it\Console\ShellAdapter`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
42			->once()
43			->with($this->repoPath, $since)
44			->andReturn(file_get_contents(__DIR__ . '/GitAdapterUnitTest.findMostChangedFiles.in.sh'));
45
46			$expected = include __DIR__ . '/GitAdapterUnitTest.findMostChangedFiles.out.php';
47
48			self::assertEquals(
49			$expected,
50			$this->adapter->findMostChangedFiles($this->repoPath, $since)
51			);
52			}
53			}
54

hgraca / php-phorensic

GitAdapterUnitTest::findMostChangedFiles() A last analyzed 2017-01-03 20:38 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

GitAdapterUnitTest::findMostChangedFiles() A
last analyzed 2017-01-03 20:38 UTC