DependencyResolver::resolveDependencies() - Code Metrics - Inspection of "segregated code into dependency resolving, buildin..." - hgraca/php-micro-di - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 5d533a...3e433e )

by Herberto

created 2016-12-05 21:35 UTC

DependencyResolver::resolveDependencies() A

↳ Parent: DependencyResolver

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	8
nc	2
nop	2

<?php
namespace Hgraca\MicroDI;

use Hgraca\Cache\CacheInterface;
use Hgraca\Cache\Exception\CacheItemNotFoundException;
use Hgraca\Helper\ClassHelper;

final class DependencyResolver implements DependencyResolverInterface
{
    /** @var CacheInterface */
    private $cache;

    public function __construct(CacheInterface $cache)
    {
        $this->cache = $cache;
    }

    public function resolveDependencies(string $dependentClass, string $dependentMethod): array
    {
        $dependenciesKey = $this->getDependenciesKey($dependentClass, $dependentMethod);

        try {
            $dependencies = $this->cache->fetch($dependenciesKey);
        } catch (CacheItemNotFoundException $e) {
            $dependencies = ClassHelper::getParameters($dependentClass, $dependentMethod);
            $this->cache->save($dependenciesKey, $dependencies);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $dependencies;
    }

    private function getDependenciesKey(string $class, string $method = '__construct'): string
    {
        return sprintf('%s::%s', str_replace('\\', '_', $class), $method);
    }
}


1			<?php
2			namespace Hgraca\MicroDI;
3
4			use Hgraca\Cache\CacheInterface;
5			use Hgraca\Cache\Exception\CacheItemNotFoundException;
6			use Hgraca\Helper\ClassHelper;
7
8			final class DependencyResolver implements DependencyResolverInterface
9			{
10			/** @var CacheInterface */
11			private $cache;
12
13			public function __construct(CacheInterface $cache)
14			{
15			$this->cache = $cache;
16			}
17
18			public function resolveDependencies(string $dependentClass, string $dependentMethod): array
19			{
20			$dependenciesKey = $this->getDependenciesKey($dependentClass, $dependentMethod);
21
22			try {
23			$dependencies = $this->cache->fetch($dependenciesKey);
24			} catch (CacheItemNotFoundException $e) {
25			$dependencies = ClassHelper::getParameters($dependentClass, $dependentMethod);
26			$this->cache->save($dependenciesKey, $dependencies);
			0 ignored issues – show Documentation introduced 2016-12-05 21:38 UTC by Report Bug Copy Issue Report `$dependencies` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			}
28
29			return $dependencies;
30			}
31
32			private function getDependenciesKey(string $class, string $method = '__construct'): string
33			{
34			return sprintf('%s::%s', str_replace('\\', '_', $class), $method);
35			}
36			}
37

hgraca / php-micro-di

Push — master ( 5d533a...3e433e )

DependencyResolver::resolveDependencies() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like