AuthorizationService::__construct() - Code Metrics - Inspection of "Replace dependency on "zend_diactoros" for "nyholm..." - hgraca/explicit-architecture-php - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 0c8bf0...b71d97 )

by Herberto

created 2020-03-06 15:33 UTC

AuthorizationService::__construct() A

↳ Parent: AuthorizationService

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Explicit Architecture POC,
 * which is created on top of the Symfony Demo application.
 *
 * (c) Herberto Graça <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Acme\App\Infrastructure\Auth\Authorization;

use Acme\App\Core\Port\Auth\Authorization\AccessDeniedException;
use Acme\App\Core\Port\Auth\Authorization\AuthorizationServiceInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

final class AuthorizationService implements AuthorizationServiceInterface
{
    /**
     * @var AuthorizationCheckerInterface
     */
    private $authorizationChecker;

    public function __construct(AuthorizationCheckerInterface $authorizationChecker)
    {
        $this->authorizationChecker = $authorizationChecker;
    }

    public function hasRole(string ...$roleList): bool
    {
        return $this->authorizationChecker->isGranted($roleList);
    }

    public function isAllowed(string $action, $subject): bool
    {
        return $this->authorizationChecker->isGranted($action, $subject);
    }

    /**
     * Throws an exception unless the specified roles and action are met on the subject.
     */
    public function denyAccessUnlessGranted(
        array $roleList = [],
        string $action = '',
        string $message = 'Access Denied.',
        $subject = null
    ): void {
        $attributes[] = $action;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $attributes = \array_filter(\array_merge($roleList, $attributes));

        if (!$this->authorizationChecker->isGranted($attributes, $subject)) {
            throw new AccessDeniedException($roleList, $action, $subject, $message);
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Explicit Architecture POC,
7			* which is created on top of the Symfony Demo application.
8			*
9			* (c) Herberto Graça <[email protected]>
10			*
11			* For the full copyright and license information, please view the LICENSE
12			* file that was distributed with this source code.
13			*/
14
15			namespace Acme\App\Infrastructure\Auth\Authorization;
16
17			use Acme\App\Core\Port\Auth\Authorization\AccessDeniedException;
18			use Acme\App\Core\Port\Auth\Authorization\AuthorizationServiceInterface;
19			use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
20
21			final class AuthorizationService implements AuthorizationServiceInterface
22			{
23			/**
24			* @var AuthorizationCheckerInterface
25			*/
26			private $authorizationChecker;
27
28			public function __construct(AuthorizationCheckerInterface $authorizationChecker)
29			{
30			$this->authorizationChecker = $authorizationChecker;
31			}
32
33			public function hasRole(string ...$roleList): bool
34			{
35			return $this->authorizationChecker->isGranted($roleList);
36			}
37
38			public function isAllowed(string $action, $subject): bool
39			{
40			return $this->authorizationChecker->isGranted($action, $subject);
41			}
42
43			/**
44			* Throws an exception unless the specified roles and action are met on the subject.
45			*/
46			public function denyAccessUnlessGranted(
47			array $roleList = [],
48			string $action = '',
49			string $message = 'Access Denied.',
50			$subject = null
51			): void {
52			$attributes[] = $action;
			0 ignored issues – show Coding Style Comprehensibility introduced 2018-06-23 10:21 UTC by Report Bug Copy Issue Report `$attributes` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$attributes = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
53			$attributes = \array_filter(\array_merge($roleList, $attributes));
54
55			if (!$this->authorizationChecker->isGranted($attributes, $subject)) {
56			throw new AccessDeniedException($roleList, $action, $subject, $message);
57			}
58			}
59			}
60

hgraca / explicit-architecture-php

Push — master ( 0c8bf0...b71d97 )

AuthorizationService::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like