Acme\App\Core\Component\Blog\Application\Repository\DQL\CommentRepository

Complexity

Total Complexity

4

Size/Duplication

Total Lines	44
Duplicated Lines	45.45 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	findAllByPostId()	20	20	3

<?php

declare(strict_types=1);

/*
 * This file is part of the Explicit Architecture POC,
 * which is created on top of the Symfony Demo application.
 *
 * (c) Herberto Graça <herberto.graca@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Acme\App\Core\Component\Blog\Application\Repository\DQL;

use Acme\App\Core\Component\Blog\Application\Repository\CommentRepositoryInterface;
use Acme\App\Core\Component\Blog\Domain\Post\Comment\Comment;
use Acme\App\Core\Component\Blog\Domain\Post\PostId;
use Acme\App\Core\Port\Persistence\DQL\DqlQueryBuilderInterface;
use Acme\App\Core\Port\Persistence\QueryServiceRouterInterface;
use Acme\App\Core\Port\Persistence\ResultCollectionInterface;

class CommentRepository implements CommentRepositoryInterface
{
    /**
     * @var DqlQueryBuilderInterface
     */
    private $dqlQueryBuilder;

    /**
     * @var QueryServiceRouterInterface
     */
    private $queryService;

    public function __construct(
        DqlQueryBuilderInterface $dqlQueryBuilder,
        QueryServiceRouterInterface $queryService
    ) {
        $this->dqlQueryBuilder = $dqlQueryBuilder;
        $this->queryService = $queryService;
    }

    /**
     * @return Comment[]
     */
    public function findAllByPostId(

This method seems to be duplicated in your project.

        PostId $postId,
        array $orderByList = ['publishedAt' => 'DESC'],
        int $maxResults = null
    ): ResultCollectionInterface {
        $this->dqlQueryBuilder->create(Comment::class);

        $this->dqlQueryBuilder->where('Comment.post = :post')
            ->setParameter('post', $postId);

        foreach ($orderByList as $property => $direction) {
            $this->dqlQueryBuilder->orderBy('Comment.' . $property, $direction);
        }

        if ($maxResults) {

The expression $maxResults of type null|integer is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $this->dqlQueryBuilder->setMaxResults($maxResults);
        }

        return $this->queryService->query($this->dqlQueryBuilder->build());
    }
}