hfw / socket

src/Reactor.php

Braces +1 added lines, -2 removed lines

@@ -93,8 +93,7 @@
             foreach ($rwe[0] as $id => $socket) {
                 $socket->onReadable();
             }
-        }
-        finally {
+        } finally {
             array_walk_recursive($rwe, function(ReactiveInterface $each) {
                 if (!$each->isOpen()) {
                     $this->remove($each);

src/WebSocket/HandShake.php

Braces +2 added lines, -4 removed lines

@@ -91,8 +91,7 @@ 
                 $value = trim($value);
                 if (isset($this->headers[$key])) {
                     $this->headers[$key] .= ', ' . $value;
-                }
-                else {
+                } else {
                     $this->headers[$key] = $value;
                 }
             }
@@ -101,8 +100,7 @@ 
             $this->upgrade();
             $this->client->write("\r\n\r\n");
             return true;
-        }
-        catch (WebSocketError $e) {
+        } catch (WebSocketError $e) {
             $this->client->write("HTTP/1.1 {$e->getCode()}\r\n\r\n");
             throw $e;
         }

src/WebSocket/WebSocketServer.php

Braces +1 added lines, -2 removed lines

@@ -94,8 +94,7 @@
         foreach ($this->clients as $client) {
             try {
                 $client->close($code, $reason);
-            }
-            catch (Exception $e) {
+            } catch (Exception $e) {
                 continue;
             }
         }

src/AbstractClient.php

Braces +2 added lines, -4 removed lines

@@ -21,8 +21,7 @@ 
     public function __toString () {
         try {
             return implode(':', $this->getPeerName());
-        }
-        catch (Throwable $e) {
+        } catch (Throwable $e) {
             return "?{$this->resource}";
         }
     }
@@ -102,8 +101,7 @@ 
         while ($total < $length) {
             try {
                 $total += $this->awaitWritable()->send(substr($data, $total));
-            }
-            catch (SocketError $e) {
+            } catch (SocketError $e) {
                 $e->setExtra($total);
                 throw $e;
             }

src/SocketError.php

Braces +1 added lines, -2 removed lines

@@ -65,8 +65,7 @@
     public function __construct ($subject = null, $fallback = 0, SocketError $previous = null) {
         if ($errno = is_int($subject) ? $subject : static::getLast($subject)) {
             $message = socket_strerror($errno);
-        }
-        else {
+        } else {
             $errno = $fallback;
             $last = error_get_last();
             $message = "{$last['message']} in {$last['file']}:{$last['line']}";

src/StreamClient.php

Braces +2 added lines, -4 removed lines

@@ -53,8 +53,7 @@ 
                 $length -= $chunkSize = strlen($chunk);
             } while ($chunkSize and $length);
             return $data;
-        }
-        catch (SocketError $e) {
+        } catch (SocketError $e) {
             $e->setExtra($data);
             throw $e;
         }
@@ -91,8 +90,7 @@ 
         $length = $this->getOption(SO_RCVBUF);
         try {
             return $this->recv($length, $msgFlags);
-        }
-        catch (SocketError $e) {
+        } catch (SocketError $e) {
             if ($e->getCode() === SOCKET_EAGAIN) { // would block
                 return '';
             }

Doc Comments +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      * @link https://php.net/socket_create_pair
      *
      * @param array $extra Variadic constructor arguments.
-     * @return static[] Two instances at indices `0` and `1`.
+     * @return StreamClient[] Two instances at indices `0` and `1`.
      * @throws SocketError
      */
     public static function newUnixPair (...$extra) {

src/AbstractSocket.php

Braces +2 added lines, -4 removed lines

@@ -52,11 +52,9 @@
     public function __construct ($resource) {
         if (!is_resource($resource) or get_resource_type($resource) !== 'Socket') {
             throw new InvalidArgumentException('Expected an open socket resource.', SOCKET_EBADF);
-        }
-        elseif (socket_get_option($resource, SOL_SOCKET, SO_TYPE) !== static::getType()) {
+        } elseif (socket_get_option($resource, SOL_SOCKET, SO_TYPE) !== static::getType()) {
             throw new InvalidArgumentException('Invalid socket type for ' . static::class, SOCKET_ESOCKTNOSUPPORT);
-        }
-        elseif ($errno = SocketError::getLast($resource)) {
+        } elseif ($errno = SocketError::getLast($resource)) {
             // "File descriptor in bad state"
             throw new SocketError(SOCKET_EBADFD, 0, new SocketError($errno));
         }

Doc Comments +2 added lines, -2 removed lines

@@ -154,7 +154,7 @@ 
      * @link https://php.net/socket_get_option
      *
      * @param int $option `SO_*` option constant.
-     * @return mixed The option's value. This is never `false`.
+     * @return integer The option's value. This is never `false`.
      * @throws SocketError
      */
     public function getOption (int $option) {
@@ -222,7 +222,7 @@ 
      * @see await()
      *
      * @param int $channel `SocketInterface` channel constant.
-     * @param float|null $timeout Maximum seconds to block. `NULL` blocks forever. Defaults to a poll.
+     * @param integer $timeout Maximum seconds to block. `NULL` blocks forever. Defaults to a poll.
      * @return bool
      * @throws SocketError
      */

src/WebSocket/FrameHandler.php

Braces +8 added lines, -16 removed lines

@@ -138,11 +138,9 @@ 
     protected function onControl (Frame $control): void {
         if ($control->isClose()) {
             $this->onClose($control);
-        }
-        elseif ($control->isPing()) {
+        } elseif ($control->isPing()) {
             $this->onPing($control);
-        }
-        elseif ($control->isPong()) {
+        } elseif ($control->isPong()) {
             $this->onPong($control);
         }
     }
@@ -158,8 +156,7 @@ 
         }
         if ($data->isText()) {
             $this->onText($data);
-        }
-        elseif ($data->isBinary()) {
+        } elseif ($data->isBinary()) {
             $this->onBinary($data);
         }
     }
@@ -188,11 +185,9 @@ 
         $this->onFrame_CheckLength($frame);
         if ($frame->isControl()) {
             $this->onControl($frame);
-        }
-        elseif ($frame->isContinue()) {
+        } elseif ($frame->isContinue()) {
             $this->onContinue($frame);
-        }
-        else {
+        } else {
             $this->onData($frame);
         }
     }
@@ -204,8 +199,7 @@ 
         if ($frame->isData()) {
             if ($frame->isBinary()) {
                 $length = strlen($this->binary);
-            }
-            else {
+            } else {
                 $length = strlen($this->text);
             }
             if ($length + $frame->getLength() > $this->maxLength) {
@@ -341,12 +335,10 @@ 
         if ($length > 65535) {
             $head .= chr(127);
             $head .= pack('J', $length);
-        }
-        elseif ($length >= 126) {
+        } elseif ($length >= 126) {
             $head .= chr(126);
             $head .= pack('n', $length);
-        }
-        else {
+        } else {
             $head .= chr($length);
         }
         $this->client->write($head . $payload);

src/WebSocket/WebSocketClient.php

Braces +3 added lines, -6 removed lines

@@ -80,8 +80,7 @@ 
                 $this->getFrameHandler()->writeClose($code, $reason);
                 $this->shutdown(self::CH_WRITE);
             }
-        }
-        finally {
+        } finally {
             $this->state = self::STATE_CLOSE;
             $this->server->remove($this);
             parent::close();
@@ -173,12 +172,10 @@ 
                 case self::STATE_CLOSE:
                     return;
             }
-        }
-        catch (WebSocketError $e) {
+        } catch (WebSocketError $e) {
             $this->close($e->getCode(), $e->getMessage());
             throw $e;
-        }
-        catch (Exception $e) {
+        } catch (Exception $e) {
             $this->close(Frame::CLOSE_INTERNAL_ERROR);
             throw $e;
         }