Helix\Shopify\Base\AbstractEntity\MetafieldTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getMetafields()	0	11	1
A	_metafieldType()	0	2	1
A	newMetafield()	0	7	1

<?php

namespace Helix\Shopify\Base\AbstractEntity;

use Helix\Shopify\Base\AbstractEntity;
use Helix\Shopify\Metafield;

/**
 * Adds metafields to an entity.
 *
 * @see https://help.shopify.com/en/api/reference/metafield
 *
 * @mixin AbstractEntity
 */
trait MetafieldTrait {

    /**
     * @return string
     */
    protected function _metafieldType (): string {
        return static::TYPE;

The constant Helix\Shopify\Base\AbstractEntity\MetafieldTrait::TYPE was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * @return Metafield[]
     */
    public function getMetafields () {
        assert($this->hasId());

It seems like hasId() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        // the endpoints are all over the place.
        // querying the main directory works for all entities.
        $remote = $this->api->get('metafields', [
            'metafield[owner_id]' => $this->getId(),

It seems like getId() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'metafield[owner_resource]' => $this->_metafieldType()
        ]);
        /** @var AbstractEntity $that */
        $that = $this;
        return $this->api->factoryAll($that, Metafield::class, $remote['metafields']);
    }

    /**
     * Factory.
     *
     * @return Metafield
     */
    public function newMetafield () {
        assert($this->hasId());
        /** @var AbstractEntity $that */
        $that = $this;
        return $this->api->factory($that, Metafield::class, [
            'owner_resource' => $this->_metafieldType(),
            'owner_id' => $this->getId()
        ]);
    }
}