Statement::__toString() - Code Metrics - Inspection of "Added Statement->__toString()" - hfw/db - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 331e8c...9d3685 )

by y

created 2019-02-21 08:27 UTC

Statement::__toString() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	2
rs	10
c	0
b	0
f	0

<?php

namespace Helix\DB;

use ArgumentCountError;
use Helix\DB;
use PDOStatement;

/**
 * Extends `PDOStatement` for fluency and logging.
 */
class Statement extends PDOStatement {

    /**
     * @var DB
     */
    protected $db;

    /**
     * PDO requires this to be protected.
     *
     * @param DB $db
     */
    protected function __construct (DB $db) {
        $this->db = $db;
    }

    /**
     * The query string.
     *
     * @return string
     */
    public function __toString () {
        return $this->queryString;
    }

    /**
     * Logs and returns for fluency.
     *
     * PHP returns `false` instead of throwing if too many arguments were given.
     * This checks for that and throws.
     *
     * @param array $args
     * @return $this
     * @throws ArgumentCountError
     */
    public function execute ($args = null) {
        $this->db->getLogger()->__invoke($this->queryString);
        if (!parent::execute($args)) {
            $info = $this->errorInfo();
            if ($info[0] == 0) {
                $argc = count($args);
                throw new ArgumentCountError("Too many arguments given ({$argc})");
            }
        }
        return $this;
    }

    /**
     * `lastInsertId()`
     *
     * @return int
     */
    public function getId (): int {
        return $this->db->lastInsertId();

    }
}


1			<?php
2
3			namespace Helix\DB;
4
5			use ArgumentCountError;
6			use Helix\DB;
7			use PDOStatement;
8
9			/**
10			* Extends `PDOStatement` for fluency and logging.
11			*/
12			class Statement extends PDOStatement {
13
14			/**
15			* @var DB
16			*/
17			protected $db;
18
19			/**
20			* PDO requires this to be protected.
21			*
22			* @param DB $db
23			*/
24			protected function __construct (DB $db) {
25			$this->db = $db;
26			}
27
28			/**
29			* The query string.
30			*
31			* @return string
32			*/
33			public function __toString () {
34			return $this->queryString;
35			}
36
37			/**
38			* Logs and returns for fluency.
39			*
40			* PHP returns `false` instead of throwing if too many arguments were given.
41			* This checks for that and throws.
42			*
43			* @param array $args
44			* @return $this
45			* @throws ArgumentCountError
46			*/
47			public function execute ($args = null) {
48			$this->db->getLogger()->__invoke($this->queryString);
49			if (!parent::execute($args)) {
50			$info = $this->errorInfo();
51			if ($info[0] == 0) {
52			$argc = count($args);
53			throw new ArgumentCountError("Too many arguments given ({$argc})");
54			}
55			}
56			return $this;
57			}
58
59			/**
60			* `lastInsertId()`
61			*
62			* @return int
63			*/
64			public function getId (): int {
65			return $this->db->lastInsertId();
			0 ignored issues – show Bug Best Practice introduced 2019-02-16 04:12 UTC by Report Bug Copy Issue Report The expression `return $this->db->lastInsertId()` returns the type `string` which is incompatible with the type-hinted return `integer`. Loading history...
66			}
67			}
68

hfw / db

Push — master ( 331e8c...9d3685 )

Statement::__toString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like