hfw / asana

src/Api/Laravel/AsanaServiceProvider.php

Spacing +3 added lines, -3 removed lines

@@ -17,7 +17,7 @@ 
 
     const NAME = 'asana';
 
-    public function boot () {
+    public function boot() {
         $this->publishes([
             __DIR__ . '/config/asana.php' => $this->app->configPath('asana.php')
         ]);
@@ -30,11 +30,11 @@ 
         }
     }
 
-    public function provides () {
+    public function provides() {
         return [self::NAME];
     }
 
-    public function register () {
+    public function register() {
         $this->app->singleton(self::NAME, function(Application $app) {
             $config = $app['config'][self::NAME];
             $pool = null;

src/Api/FileCache.php

Spacing +13 added lines, -13 removed lines

@@ -29,30 +29,30 @@ 
     /**
      * @param string $dir
      */
-    public function __construct (string $dir) {
+    public function __construct(string $dir) {
         $this->dir = $dir;
         $this->log = new NullLogger();
     }
 
-    private function _log (string $msg): void {
+    private function _log(string $msg): void {
         $this->log->log(LOG_DEBUG, $msg);
     }
 
-    private function _path ($key): string {
+    private function _path($key): string {
         $path = "{$this->dir}/{$key}~";
         clearstatcache(true, $path);
         return $path;
     }
 
-    private function _ref ($key): string {
+    private function _ref($key): string {
         return $ref = "{$this->dir}/{$key}.ref";
     }
 
-    public function clear () {
+    public function clear() {
         // unused. just delete the dir.
     }
 
-    public function delete ($key) {
+    public function delete($key) {
         $path = $this->_path($key);
         if (is_link($ref = $this->_ref($key))) {
             $this->_log("CACHE DELINK {$key}");
@@ -65,7 +65,7 @@ 
         }
     }
 
-    public function deleteMultiple ($keys) {
+    public function deleteMultiple($keys) {
         // unused
     }
 
@@ -74,7 +74,7 @@ 
      * @param null $default
      * @return null|string|object
      */
-    public function get ($key, $default = null) {
+    public function get($key, $default = null) {
         $path = $this->_path($key);
         if (!is_file($path)) {
             $this->_log("CACHE MISS {$key}");
@@ -93,11 +93,11 @@ 
         return $data;
     }
 
-    public function getMultiple ($keys, $default = null) {
+    public function getMultiple($keys, $default = null) {
         // unused
     }
 
-    public function has ($key): bool {
+    public function has($key): bool {
         return is_file($this->_path($key));
     }
 
@@ -107,7 +107,7 @@ 
      * @param int $ttl
      * @return void
      */
-    public function set ($key, $value, $ttl = null): void {
+    public function set($key, $value, $ttl = null): void {
         $path = $this->_path($key);
         if (!is_dir(dirname($path))) {
             mkdir(dirname($path), 0770, true);
@@ -136,12 +136,12 @@ 
      * @param LoggerInterface $log
      * @return $this
      */
-    public function setLog (LoggerInterface $log) {
+    public function setLog(LoggerInterface $log) {
         $this->log = $log;
         return $this;
     }
 
-    public function setMultiple ($values, $ttl = null) {
+    public function setMultiple($values, $ttl = null) {
         // unused
     }
 }
\ No newline at end of file

Braces +2 added lines, -4 removed lines

@@ -58,8 +58,7 @@ 
             $this->_log("CACHE DELINK {$key}");
             unlink($ref);
             unlink($path);
-        }
-        elseif (is_file($path)) {
+        } elseif (is_file($path)) {
             $this->_log("CACHE DELETE {$key}");
             unlink($path);
         }
@@ -117,8 +116,7 @@ 
                 ["CACHE SET {$key}", "CACHE BURN {$key}"][$value instanceof ImmutableInterface],
                 "CACHE UPDATE {$key}"
             ][is_file($path)]);
-        }
-        else {
+        } else {
             $this->_log([
                 "CACHE LINK {$key} => {$value}",
                 "CACHE RENEW LINK {$key} => {$value}"

src/Api/Pool.php

Spacing +7 added lines, -7 removed lines

@@ -29,7 +29,7 @@ 
     /**
      * @param AbstractEntity $entity
      */
-    protected function _add (AbstractEntity $entity): void {
+    protected function _add(AbstractEntity $entity): void {
         $gid = $entity->getGid();
         $this->entities[$gid] = $entity;
         $this->gids[$gid] = $gid;
@@ -39,7 +39,7 @@ 
      * @param AbstractEntity $entity
      * @param string[] $keys
      */
-    protected function _addKeys (AbstractEntity $entity, ...$keys): void {
+    protected function _addKeys(AbstractEntity $entity, ...$keys): void {
         $this->gids += array_fill_keys($keys, $entity->getGid());
     }
 
@@ -48,7 +48,7 @@ 
      * @param Api|Data $caller For hydration if needed.
      * @return null|AbstractEntity
      */
-    protected function _get (string $key, $caller) {
+    protected function _get(string $key, $caller) {
         if (isset($this->gids[$key])) {
             return $this->entities[$this->gids[$key]];
         }
@@ -62,14 +62,14 @@ 
      * @param string $key
      * @return bool
      */
-    protected function _has (string $key): bool {
+    protected function _has(string $key): bool {
         return isset($this->gids[$key]);
     }
 
     /**
      * @param AbstractEntity $entity
      */
-    final public function add (AbstractEntity $entity): void {
+    final public function add(AbstractEntity $entity): void {
         if (!$entity->isDiff()) {
             $this->_add($entity);
             $this->_addKeys($entity, ...$entity->getPoolKeys());
@@ -82,7 +82,7 @@ 
      * @param Closure $factory `fn( Api|Data $caller ): null|AbstractEntity`
      * @return null|mixed|AbstractEntity
      */
-    final public function get (string $key, $caller, Closure $factory) {
+    final public function get(string $key, $caller, Closure $factory) {
         /** @var AbstractEntity $entity */
         if (!$entity = $this->_get($key, $caller) and $entity = $factory($caller)) {
             $gid = $entity->getGid();
@@ -103,7 +103,7 @@ 
     /**
      * @param string[] $keys
      */
-    public function remove (array $keys): void {
+    public function remove(array $keys): void {
         foreach ($keys as $key) {
             unset($this->entities[$key]);
             unset($this->gids[$key]);

src/Base/Data.php

Spacing +20 added lines, -20 removed lines

@@ -57,7 +57,7 @@ 
      * @param Api|Data $caller
      * @param array $data
      */
-    public function __construct ($caller, array $data = []) {
+    public function __construct($caller, array $data = []) {
         if ($caller instanceof self) {
             $this->api = $caller->api;
         }
@@ -78,9 +78,9 @@ 
      * @param array $args
      * @return mixed
      */
-    public function __call (string $method, array $args) {
+    public function __call(string $method, array $args) {
         static $magic = [];
-        if (!$call =& $magic[$method]) {
+        if (!$call = & $magic[$method]) {
             preg_match('/^(get|has|is|select|set)(.+)$/', $method, $call);
             $call[1] = '_' . $call[1];
             $call[2] = preg_replace_callback('/[A-Z]/', function(array $match) {
@@ -93,7 +93,7 @@ 
     /**
      * @return array
      */
-    public function __debugInfo (): array {
+    public function __debugInfo(): array {
         return $this->data;
     }
 
@@ -102,7 +102,7 @@ 
      * @return null|Data|mixed
      * @internal `array_column()`
      */
-    final public function __get ($field) {
+    final public function __get($field) {
         return $this->_get($field);
     }
 
@@ -111,7 +111,7 @@ 
      * @return bool
      * @internal `array_column()`
      */
-    final public function __isset ($field) {
+    final public function __isset($field) {
         return true;
     }
 
@@ -123,7 +123,7 @@ 
      * @param string $field
      * @return mixed
      */
-    protected function _get (string $field) {
+    protected function _get(string $field) {
         return $this->data[$field] ?? null;
     }
 
@@ -138,7 +138,7 @@ 
      * @param string $field
      * @return bool
      */
-    protected function _has (string $field): bool {
+    protected function _has(string $field): bool {
         $value = $this->_get($field);
         if (isset($value)) {
             if (is_countable($value)) {
@@ -161,7 +161,7 @@ 
      * @param string $field
      * @return bool
      */
-    protected function _is (string $field): bool {
+    protected function _is(string $field): bool {
         return (bool)$this->_get($field);
     }
 
@@ -176,7 +176,7 @@ 
      * @param callable $filter `fn( Data $object ): bool`
      * @return array
      */
-    protected function _select ($subject, callable $filter) {
+    protected function _select($subject, callable $filter) {
         if (!is_iterable($subject)) {
             $subject = $this->_get($subject) ?? [];
         }
@@ -198,7 +198,7 @@ 
      * @param mixed $value
      * @return $this
      */
-    protected function _set (string $field, $value) {
+    protected function _set(string $field, $value) {
         $this->data[$field] = $value;
         $this->diff[$field] = true;
         return $this;
@@ -209,7 +209,7 @@ 
      *
      * @param array $data
      */
-    protected function _setData (array $data): void {
+    protected function _setData(array $data): void {
         $this->data = $this->diff = [];
         foreach ($data as $field => $value) {
             $this->_setMapped($field, $value);
@@ -222,7 +222,7 @@ 
      * @param string $field
      * @param mixed $value
      */
-    protected function _setMapped (string $field, $value): void {
+    protected function _setMapped(string $field, $value): void {
         unset($this->diff[$field]);
 
         // use value as-is?
@@ -274,7 +274,7 @@ 
      *
      * @return array
      */
-    public function getDiff (): array {
+    public function getDiff(): array {
         $convert = function($each) use (&$convert) {
             // convert existing entities to gids
             if ($each instanceof AbstractEntity and $each->hasGid()) {
@@ -300,7 +300,7 @@ 
      * @param string null $field
      * @return bool
      */
-    final public function isDiff (string $field = null): bool {
+    final public function isDiff(string $field = null): bool {
         if ($field) {
             return isset($this->diff[$field]);
         }
@@ -311,7 +311,7 @@ 
      * @see toArray()
      * @return array
      */
-    public function jsonSerialize (): array {
+    public function jsonSerialize(): array {
         $data = $this->toArray();
         ksort($data);
         return $data;
@@ -322,8 +322,8 @@ 
      *
      * @return string
      */
-    public function serialize (): string {
-        return json_encode($this, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE);
+    public function serialize(): string {
+        return json_encode($this, JSON_PRETTY_PRINT|JSON_UNESCAPED_SLASHES|JSON_UNESCAPED_UNICODE);
     }
 
     /**
@@ -331,7 +331,7 @@ 
      *
      * @return array
      */
-    public function toArray (): array {
+    public function toArray(): array {
         if (!$this->api) {
             return $this->data;
         }
@@ -356,7 +356,7 @@ 
     /**
      * @param $serialized
      */
-    public function unserialize ($serialized): void {
+    public function unserialize($serialized): void {
         $this->data = json_decode($serialized, true);
     }
 }
\ No newline at end of file

Braces +2 added lines, -4 removed lines

@@ -60,8 +60,7 @@ 
     public function __construct ($caller, array $data = []) {
         if ($caller instanceof self) {
             $this->api = $caller->api;
-        }
-        else {
+        } else {
             $this->api = $caller;
         }
         $this->_setData($data);
@@ -263,8 +262,7 @@ 
 
         if ($isList) {
             $this->data[$field] = array_map($hydrate, $value);
-        }
-        else {
+        } else {
             $this->data[$field] = $hydrate($value);
         }
     }

src/Base/AbstractEntity.php

Spacing +14 added lines, -14 removed lines

@@ -30,14 +30,14 @@ 
      *
      * @return string
      */
-    abstract public function __toString (): string;
+    abstract public function __toString(): string;
 
     /**
      * @param self $entity
      * @return bool
      * @internal pool
      */
-    final public function __merge (self $entity): bool {
+    final public function __merge(self $entity): bool {
         $old = $this->toArray();
         $this->data = array_merge($this->data, array_diff_key($entity->data, $this->diff));
         return $this->toArray() !== $old;
@@ -51,7 +51,7 @@ 
      * @return $this
      * @internal
      */
-    protected function _addWithPost (string $addPath, array $data, string $field, array $diff) {
+    protected function _addWithPost(string $addPath, array $data, string $field, array $diff) {
         if ($this->hasGid()) {
             return $this->_setWithPost($addPath, $data, $field);
         }
@@ -63,7 +63,7 @@ 
      *
      * @internal
      */
-    protected function _delete (): void {
+    protected function _delete(): void {
         $this->api->delete($this);
         $this->api->getPool()->remove($this->getPoolKeys());
     }
@@ -74,7 +74,7 @@ 
      * @param string $field
      * @return mixed
      */
-    protected function _get (string $field) {
+    protected function _get(string $field) {
         if (!array_key_exists($field, $this->data) and $this->hasGid()) {
             $this->reload($field);
         }
@@ -89,7 +89,7 @@ 
      * @return $this
      * @internal
      */
-    protected function _removeWithPost (string $rmPath, array $data, string $field, $diff) {
+    protected function _removeWithPost(string $rmPath, array $data, string $field, $diff) {
         if ($this->hasGid()) {
             return $this->_setWithPost($rmPath, $data, $field);
         }
@@ -106,7 +106,7 @@ 
      * @return $this
      * @internal
      */
-    protected function _save (string $dir = null) {
+    protected function _save(string $dir = null) {
         if (isset($dir)) { // create()
             $remote = $this->api->post($dir, $this->getDiff(), ['expand' => 'this']);
         }
@@ -122,7 +122,7 @@ 
         return $this;
     }
 
-    protected function _setData (array $data): void {
+    protected function _setData(array $data): void {
         // make sure the gid is consistently null|string across all entities.
         $data['gid'] = (string)$data['gid'];
         if (empty($data['gid'])) {
@@ -145,7 +145,7 @@ 
      * @return $this
      * @internal
      */
-    protected function _setWithPost (string $path, array $data, string $field, $value = null) {
+    protected function _setWithPost(string $path, array $data, string $field, $value = null) {
         if ($this->hasGid()) {
             /** @var array $remote */
             $remote = $this->api->post($path, $data, ['fields' => static::OPT_FIELDS[$field] ?? $field]);
@@ -161,7 +161,7 @@ 
     /**
      * @return null|string
      */
-    final public function getGid (): ?string {
+    final public function getGid(): ?string {
         return $this->data['gid'];
     }
 
@@ -170,7 +170,7 @@ 
      *
      * @return string[]
      */
-    public function getPoolKeys () {
+    public function getPoolKeys() {
         return [$this->getGid(), (string)$this];
     }
 
@@ -179,14 +179,14 @@ 
      *
      * @return string
      */
-    final public function getResourceType (): string {
+    final public function getResourceType(): string {
         return $this::TYPE;
     }
 
     /**
      * @return bool
      */
-    final public function hasGid (): bool {
+    final public function hasGid(): bool {
         return isset($this->data['gid']);
     }
 
@@ -197,7 +197,7 @@ 
      * @param string $field
      * @return $this
      */
-    public function reload (string $field = null) {
+    public function reload(string $field = null) {
         if (!$this->hasGid()) { // guards against loading a remote dir.
             throw new LogicException(static::class . " has no GID, it can't be reloaded.");
         }

Braces +5 added lines, -10 removed lines

@@ -92,8 +92,7 @@ 
     protected function _removeWithPost (string $rmPath, array $data, string $field, $diff) {
         if ($this->hasGid()) {
             return $this->_setWithPost($rmPath, $data, $field);
-        }
-        elseif (is_array($diff)) {
+        } elseif (is_array($diff)) {
             return $this->_set($field, array_values(array_diff($this->data[$field] ?? [], $diff)));
         }
         return $this->_set($field, array_values(array_filter($this->data[$field] ?? [], $diff)));
@@ -109,11 +108,9 @@ 
     protected function _save (string $dir = null) {
         if (isset($dir)) { // create()
             $remote = $this->api->post($dir, $this->getDiff(), ['expand' => 'this']);
-        }
-        elseif ($this->isDiff()) { // update()
+        } elseif ($this->isDiff()) { // update()
             $remote = $this->api->put($this, $this->getDiff(), ['expand' => 'this']);
-        }
-        else { // update() but no change
+        } else { // update() but no change
             return $this;
         }
         /** @var array $remote */
@@ -204,11 +201,9 @@ 
         if (isset($field)) {
             $remote = $this->api->get($this, [], ['fields' => static::OPT_FIELDS[$field] ?? $field]);
             $this->_setMapped($field, $remote[$field] ?? null);
-        }
-        elseif ($remote = $this->api->get($this, [], ['expand' => 'this'])) {
+        } elseif ($remote = $this->api->get($this, [], ['expand' => 'this'])) {
             $this->_setData($remote);
-        }
-        else { // deleted upstream.
+        } else { // deleted upstream.
             $this->api->getPool()->remove($this->getPoolKeys());
             throw new RuntimeException("{$this} was deleted upstream.");
         }

src/CustomField/FieldSetting.php

Spacing +2 added lines, -2 removed lines

@@ -23,7 +23,7 @@ 
         'custom_field' => CustomField::class,
     ];
 
-    protected function _setData (array $data): void {
+    protected function _setData(array $data): void {
         // these are the only fields that matter.
         parent::_setData([
             'custom_field' => $data['custom_field'],
@@ -31,7 +31,7 @@ 
         ]);
     }
 
-    final public function getResourceType (): string {
+    final public function getResourceType(): string {
         return self::TYPE;
     }
 }
\ No newline at end of file

src/CustomField/FieldSettingsTrait.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
     /**
      * @return CustomField[]
      */
-    public function getCustomFields () {
+    public function getCustomFields() {
         return array_column($this->getCustomFieldSettings(), 'custom_field');
     }
 
@@ -23,7 +23,7 @@ 
      * @param callable $filter `fn( CustomField $field ): bool`
      * @return CustomField[]
      */
-    public function selectCustomFields (callable $filter) {
+    public function selectCustomFields(callable $filter) {
         return $this->{'_select'}($this->getCustomFields(), $filter);
     }
 }
\ No newline at end of file

src/Task/FieldEntries.php

Spacing +16 added lines, -16 removed lines

@@ -53,7 +53,7 @@ 
      */
     protected $types = [];
 
-    public function __construct (Task $task, array $data = []) {
+    public function __construct(Task $task, array $data = []) {
         $this->task = $task;
         parent::__construct($task, $data);
     }
@@ -62,7 +62,7 @@ 
      * @param $offset
      * @return null|string
      */
-    protected function _toGid (string $offset) {
+    protected function _toGid(string $offset) {
         if (isset($this->names[$offset])) {
             return $offset;
         }
@@ -72,7 +72,7 @@ 
     /**
      * @param array[] $values
      */
-    protected function _setData (array $values): void {
+    protected function _setData(array $values): void {
         // ensure data is keyed by field gid
         $values = array_combine(array_column($values, 'gid'), $values);
 
@@ -85,11 +85,11 @@ 
     /**
      * @return int
      */
-    public function count () {
+    public function count() {
         return count($this->data);
     }
 
-    public function getDiff (): array {
+    public function getDiff(): array {
         return array_map(function(FieldEntry $value) {
             return $value->getValue();
         }, array_intersect_key($this->data, $this->diff));
@@ -99,7 +99,7 @@ 
      * @param $fieldGid
      * @return FieldEntry
      */
-    public function getField ($fieldGid) {
+    public function getField($fieldGid) {
         return $this->data[$fieldGid];
     }
 
@@ -107,41 +107,41 @@ 
      * @param string $name
      * @return string
      */
-    public function getGid (string $name): string {
+    public function getGid(string $name): string {
         return $this->gids[$name];
     }
 
     /**
      * @return string[]
      */
-    public function getGids () {
+    public function getGids() {
         return $this->gids;
     }
 
     /**
      * @return Generator
      */
-    public function getIterator () {
+    public function getIterator() {
         foreach ($this->data as $gid => $field) {
             yield $gid => $field->getValue();
         }
     }
 
-    public function getName (string $fieldGid) {
+    public function getName(string $fieldGid) {
         return $this->names[$fieldGid];
     }
 
     /**
      * @return string[]
      */
-    public function getNames () {
+    public function getNames() {
         return $this->names;
     }
 
     /**
      * @return array
      */
-    public function getValues () {
+    public function getValues() {
         return iterator_to_array($this);
     }
 
@@ -149,7 +149,7 @@ 
      * @param string $offset
      * @return bool
      */
-    public function offsetExists ($offset) {
+    public function offsetExists($offset) {
         return isset($this->data[$this->_toGid($offset)]);
     }
 
@@ -157,7 +157,7 @@ 
      * @param string $offset
      * @return null|number|string
      */
-    public function offsetGet ($offset) {
+    public function offsetGet($offset) {
         return $this->data[$this->_toGid($offset)]->getValue();
     }
 
@@ -165,7 +165,7 @@ 
      * @param string $offset
      * @param null|number|string $value
      */
-    public function offsetSet ($offset, $value) {
+    public function offsetSet($offset, $value) {
         $offset = $this->_toGid($offset);
         $this->data[$offset]->setValue($value);
         $this->diff[$offset] = true;
@@ -177,7 +177,7 @@ 
      *
      * @param string $offset
      */
-    public function offsetUnset ($offset) {
+    public function offsetUnset($offset) {
         $this->offsetSet($offset, null);
     }
 

src/Task/FieldEntry.php

Spacing +10 added lines, -10 removed lines

@@ -26,14 +26,14 @@ 
      * @param string $value
      * @return string
      */
-    protected function _toEnumOptionGid (string $value): string {
+    protected function _toEnumOptionGid(string $value): string {
         return $this->getEnumOptionValues()[$value] ?? $value;
     }
 
     /**
      * @return string
      */
-    public function getCurrentOptionName () {
+    public function getCurrentOptionName() {
         return $this->getEnumOptionNames()[$this->getValue()];
     }
 
@@ -42,7 +42,7 @@ 
      *
      * @return string[]
      */
-    public function getEnumOptionNames () {
+    public function getEnumOptionNames() {
         static $names = []; // shared
         $gid = $this->data['gid'];
         return $names[$gid] ?? $names[$gid] = array_column($this->data['enum_options'], 'name', 'gid');
@@ -53,7 +53,7 @@ 
      *
      * @return string[]
      */
-    public function getEnumOptionValues () {
+    public function getEnumOptionValues() {
         static $values = []; // shared
         $gid = $this->data['gid'];
         return $values[$gid] ?? $values[$gid] = array_column($this->data['enum_options'], 'gid', 'name');
@@ -62,7 +62,7 @@ 
     /**
      * @return null|number|string
      */
-    public function getValue () {
+    public function getValue() {
         $type = $this->data['type'];
         if ($type === CustomField::TYPE_ENUM) {
             return $this->data['enum_value']['gid'] ?? null;
@@ -70,15 +70,15 @@ 
         return $this->data["{$type}_value"];
     }
 
-    final public function isEnum (): bool {
+    final public function isEnum(): bool {
         return $this->getType() === CustomField::TYPE_ENUM;
     }
 
-    final public function isNumber (): bool {
+    final public function isNumber(): bool {
         return $this->getType() === CustomField::TYPE_NUMBER;
     }
 
-    final public function isText (): bool {
+    final public function isText(): bool {
         return $this->getType() === CustomField::TYPE_TEXT;
     }
 
@@ -86,7 +86,7 @@ 
      * @param null|number|string $value
      * @return $this
      */
-    public function setValue ($value) {
+    public function setValue($value) {
         $type = $this->data['type'];
         $this->diff["{$type}_value"] = true;
         if ($type === CustomField::TYPE_ENUM) {
@@ -102,7 +102,7 @@ 
      *
      * @return array
      */
-    public function toArray (): array {
+    public function toArray(): array {
         // only strip if needed.
         if (!isset($this->data['resource_subtype'])) {
             return $this->data;