Helix\Asana\Base\AbstractEntity\UpdateTrait::update()

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function update () {
        if ($this->isDiff()) {

It seems like isDiff() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            /** @var Api $api */
            $api = $this->api;
            $remote = $api->put($this, $this->getDiff(), ['expand' => 'this']);

It seems like getDiff() must be provided by classes using this trait. How about adding it as abstract method to this trait?

$this of type Helix\Asana\Base\AbstractEntity\UpdateTrait is incompatible with the type string expected by parameter $path of Helix\Asana\Api::put().

            $this->_setData($remote);

It seems like _setData() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            /** @var AbstractEntity $that */
            $that = $this;
            $api->getCache()->add($that);
            $this->onUpdate();
        }
        return $this;
    }
}