hexydec\agentzero\versions

Complexity

Total Complexity

30

Size/Duplication

Total Lines	133
Duplicated Lines	0 %

Test Coverage

Coverage

91.8%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	released()	0	25	7
B	load()	0	29	9
C	get()	0	61	12
A	latest()	0	6	2

<?php
declare(strict_types = 1);
namespace hexydec\agentzero;

class versions {

	protected static ?array $versions = null;

	protected static function load(string $source, ?string $cache, int $life = 604800) : array|false {

		// cache for this session
		$data = self::$versions;
		if ($data === null) {

			// fetch from cache
			if (\file_exists($cache) && \filemtime($cache) > \time() - $life && ($json = \file_get_contents($cache)) !== false) {

It seems like $cache can also be of type null; however, parameter $filename of filemtime() does only seem to accept string, maybe add an additional type check?

It seems like $cache can also be of type null; however, parameter $filename of file_get_contents() does only seem to accept string, maybe add an additional type check?

It seems like $cache can also be of type null; however, parameter $filename of file_exists() does only seem to accept string, maybe add an additional type check?

			// fetch from server
			} elseif (($json = \file_get_contents($source)) === false) {
				return false;

			// update cache
			} elseif ($cache !== null) {

				// create directory
				$dir = \dirname($cache);
				if (!\is_dir($dir) && \mkdir($dir, 0755)) {

					// cache file
					\file_put_contents($cache, $json);
				}
			}

			// decode JSON
			$data = \json_decode($json, true);
		}
		return $data ?? false;
	}

	protected static function latest(array $versions, ?\DateTime $now = null) : string {

		// no date restriction
		if ($now === null) {
			return \strval(\array_key_first($versions));
		} else {

		}

In this branch, the function will implicitly return null which is incompatible with the type-hinted return string. Consider adding a return statement or allowing null as return value.

	}

	protected static function released(array $data, string $version) : ?string {
		$major = \intval($version);
		$len = 0;
		$i = 0;
		$vlen = \strlen($version);
		$released = null;
		foreach ($data AS $ver => $date) {
			if (\intval($ver) === $major) {
				$ver = \strval($ver); // cast as string to get letters, string keys cast to int when array keys
				$match = 0;
				for ($n = 0; $n < $vlen; $n++) {
					if ($version[$n] === ($ver[$n] ?? null)) {
						$match++;
					} else {
						break;
					}
				}
				if ($match > $len) {
					$len = $match;
					$released = $date;
				}
			}
			$i++;
		}
		return $released !== null ? (new \DateTime(\strval($released)))->format('Y-m-d') : null;

The condition $released !== null is always false.

	}

	public static function get(string $browser, string $version, array $config) : array {
		if (($versions = self::load($config['source'], $config['cache'])) !== false) {
			$data = [];
			if (isset($versions[$browser])) {

				// get latest version of the browser
				$data['browserlatest'] = self::latest($versions[$browser]);
				
				// check if version is greater than latest version
				$major = \intval($version);
				$latest = \intval($data['browserlatest']);

				// version is way out of bounds (This happens sometimes, for example if the safari engine version is reported instead of the browser version)
				if ($latest + 3 < $major) {
					return [];

				// nightly build?
				} elseif ($latest + 3 === $major) {
					$data['browserstatus'] = 'nightly';

				// canary build
				} elseif ($latest + 2 === $major) {
					$data['browserstatus'] = 'canary';

				// beta release
				} elseif ($latest + 1 === $major) {
					$data['browserstatus'] = 'beta';

				// find closes match for version
				} else {

					// get current version
					$data['browserreleased'] = self::released($versions[$browser], $version);

Are you sure the assignment to $data['browserreleased'] is correct as self::released($versions[$browser], $version) targeting hexydec\agentzero\versions::released() seems to always return null.

					// calculate status
					if (isset($data['browserreleased'])) {
						$current = \explode('.', $data['browserlatest'])[0] === \explode('.', $version)[0];
						$released = new \DateTime($data['browserreleased']);

						// legacy
						if ($released < \date_create('-3 years')) {
							$data['browserstatus'] = 'legacy';

						// current
						} elseif ($current && ($released >= \date_create('-1 year') || $data['browserlatest'] === $version)) {
							$data['browserstatus'] = 'current';

						// previous
						} else {
							$data['browserstatus'] = 'previous';
						}

					// version wasn't listed - ancient
					} else {
						$data['browserstatus'] = 'legacy';
					}
				}
			}
			return $data;
		}
		return [];
	}
}