ItemList::validateItem() - Code Metrics - Inspection of "refactoring done" - hexogen/kdtree - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (eb975e)

by Basarab

created 2016-12-22 15:25 UTC

ItemList::validateItem() A

↳ Parent: ItemList

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	4
cts	4
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	3
nc	2
nop	1
crap	2

<?php


namespace Hexogen\KDTree;

use Hexogen\KDTree\Exception\ValidationException;

class ItemList
{
    private $dimensions;
    private $items;
    private $ids;
    private $lastId;

    /**
     * ItemList constructor.
     * @param int $dimensions
     * @throws ValidationException
     */
    public function __construct(int $dimensions)
    {
        if ($dimensions <= 0) {
            throw new ValidationException('$dimensions should be bigger than 0');
        }

        $this->lastId = 0;
        $this->dimensions = $dimensions;
        $this->items = [];
        $this->ids = [];
    }

    /**
     * Add or replace an item in the item list
     *
     * @param ItemInterface $item
     */
    public function addItem(ItemInterface $item)
    {
        $this->validateItem($item);
        $id = $item->getId();

        if (isset($this->ids[$id])) {
            $index = $this->ids[$id];
            $this->items[$index] = $item;
        } else {
            $this->items[] = $item;
            $this->ids[$id] = $this->lastId++;
        }
    }

    /**
     * @return ItemInterface[]
     */
    public function getItems(): array
    {
        return $this->items;
    }

    /**
     * @return int number of dimensions in item
     */
    public function getDimensionCount(): int
    {
        return $this->dimensions;
    }

    /**
     * @param ItemInterface $item
     * @throws ValidationException
     */
    private function validateItem(ItemInterface $item)
    {
        if ($item->getDimensionsCount() !== $this->dimensions) {
            throw new ValidationException('$dValues number dimensions should be equal to ' . $this->dimensions);
        }
    }
}


1		<?php
2
3
4		namespace Hexogen\KDTree;
5
6		use Hexogen\KDTree\Exception\ValidationException;
7
8		class ItemList
9		{
10		private $dimensions;
11		private $items;
12		private $ids;
13		private $lastId;
14
15		/**
16		* ItemList constructor.
17		* @param int $dimensions
18		* @throws ValidationException
19		*/
20	27	public function __construct(int $dimensions)
21		{
22	27	if ($dimensions <= 0) {
23	3	throw new ValidationException('$dimensions should be bigger than 0');
24		}
25
26	27	$this->lastId = 0;
27	27	$this->dimensions = $dimensions;
28	27	$this->items = [];
29	27	$this->ids = [];
30	27	}
31
32		/**
33		* Add or replace an item in the item list
34		*
35		* @param ItemInterface $item
36		*/
37	18	public function addItem(ItemInterface $item)
38		{
39	18	$this->validateItem($item);
40	15	$id = $item->getId();
41
42	15	if (isset($this->ids[$id])) {
43	3	$index = $this->ids[$id];
44	3	$this->items[$index] = $item;
45		} else {
46	15	$this->items[] = $item;
47	15	$this->ids[$id] = $this->lastId++;
48		}
49	15	}
50
51		/**
52		* @return ItemInterface[]
53		*/
54	45	public function getItems(): array
55		{
56	45	return $this->items;
57		}
58
59		/**
60		* @return int number of dimensions in item
61		*/
62	45	public function getDimensionCount(): int
63		{
64	45	return $this->dimensions;
65		}
66
67		/**
68		* @param ItemInterface $item
69		* @throws ValidationException
70		*/
71	18	private function validateItem(ItemInterface $item)
72		{
73	18	if ($item->getDimensionsCount() !== $this->dimensions) {
74	3	throw new ValidationException('$dValues number dimensions should be equal to ' . $this->dimensions);
75		}
76	15	}
77		}
78

hexogen / kdtree

Branch — master (eb975e)

ItemList::validateItem() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like