heroesofabenez / combat

src/SkillSpecial.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
     });
     $resolver->setAllowedTypes("stat", ["string", "null"]);
     $resolver->setAllowedValues("stat", function(?string $value) {
-      return is_null($value) OR in_array($value, $this->getAllowedStats(), true);
+      return is_null($value) or in_array($value, $this->getAllowedStats(), true);
     });
     $resolver->setAllowedTypes("value", "integer");
     $resolver->setAllowedValues("value", function(int $value) {

src/CharacterEffect.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -52,7 +52,7 @@ 
     $resolver->setAllowedTypes("stat", "string");
     $resolver->setDefault("stat", "");
     $resolver->setAllowedValues("stat", function(string $value) {
-      return $value === "" OR in_array($value, $this->getAllowedStats(), true);
+      return $value === "" or in_array($value, $this->getAllowedStats(), true);
     });
     $resolver->setAllowedTypes("source", "string");
     $resolver->setAllowedValues("source", function(string $value) {
@@ -62,10 +62,10 @@ 
     $resolver->setDefault("value", 0);
     $resolver->setAllowedTypes("duration", ["string", "integer"]);
     $resolver->setAllowedValues("duration", function($value) {
-      return (in_array($value, $this->getDurations(), true)) OR ($value > 0);
+      return (in_array($value, $this->getDurations(), true)) or ($value > 0);
     });
     $effect = $resolver->resolve($effect);
-    if(!in_array($effect["type"], SkillSpecial::NO_STAT_TYPES, true) AND $effect["stat"] === "") {
+    if(!in_array($effect["type"], SkillSpecial::NO_STAT_TYPES, true) and $effect["stat"] === "") {
       throw new \InvalidArgumentException("The option stat with value '' is invalid.");
     }
     $this->id = $effect["id"];
@@ -135,7 +135,7 @@ 
    * @throws \InvalidArgumentException
    */
   public function setDuration($value) {
-    if(!is_int($value) AND !in_array($value, $this->getDurations(), true)) {
+    if(!is_int($value) and !in_array($value, $this->getDurations(), true)) {
       throw new \InvalidArgumentException("Invalid value set to CharacterEffect::\$duration. Expected string or integer.");
     }
     $this->duration = $value;

src/CharacterAttackSkill.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
   }
   
   public function getHitRate(): int {
-    if(is_string($this->skill->hitRate) AND substr($this->skill->hitRate, -1) === "%") {
+    if(is_string($this->skill->hitRate) and substr($this->skill->hitRate, -1) === "%") {
       return (int) $this->skill->hitRate;
     }
     return 100;

src/CombatLogger.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
    */
   public function setTemplate(string $template): void {
     if(!is_file($template)) {
-      throw new \RuntimeException("File $template does not exist.");
+      throw new \RuntimeException("file $template does not exist.");
     }
     $this->template = $template;
   }

src/Character.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -520,7 +520,7 @@ 
   public function damageStat(): string {
     $stat = static::STAT_STRENGTH;
     foreach($this->equipment as $item) {
-      if(!$item->worn OR $item->slot != Equipment::SLOT_WEAPON) {
+      if(!$item->worn or $item->slot != Equipment::SLOT_WEAPON) {
         continue;
       }
       switch($item->type) {
@@ -579,7 +579,7 @@ 
       $stat = $effect->stat;
       $type = $effect->type;
       $duration = $effect->duration;
-      if(is_int($duration) AND $duration < 1) {
+      if(is_int($duration) and $duration < 1) {
         $this->removeEffect($effect->id);
         continue;
       }

src/CombatActionSelector.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
   public function chooseAction(CombatBase $combat, Character $character): ?string {
     if($character->hitpoints < 1) {
       return null;
-    } elseif(in_array($character, $combat->findHealers()->toArray(), true) AND !is_null($combat->selectHealingTarget($character))) {
+    } elseif(in_array($character, $combat->findHealers()->toArray(), true) and !is_null($combat->selectHealingTarget($character))) {
       return CombatAction::ACTION_HEALING;
     }
     $attackTarget = $combat->selectAttackTarget($character);

src/Team.php

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -80,11 +80,11 @@ 
    */
   public function setCharacterPosition($id, int $row, int $column): void {
     if(!$this->hasItems(["id" => $id])) {
-      throw new \OutOfBoundsException("Character $id is not in the team");
+      throw new \OutOfBoundsException("character $id is not in the team");
     } elseif(count($this->getItems(["positionRow" => $row])) >= $this->maxRowSize) {
-      throw new InvalidCharacterPositionException("Row $row is full.", InvalidCharacterPositionException::ROW_FULL);
+      throw new InvalidCharacterPositionException("row $row is full.", InvalidCharacterPositionException::ROW_FULL);
     } elseif($this->hasItems(["positionRow" => $row, "positionColumn" => $column])) {
-      throw new InvalidCharacterPositionException("Row $row column $column is occupied.", InvalidCharacterPositionException::POSITION_OCCUPIED);
+      throw new InvalidCharacterPositionException("row $row column $column is occupied.", InvalidCharacterPositionException::POSITION_OCCUPIED);
     }
     $character = $this->getItems(["id" => $id])[0];
     $character->positionRow = $row;
@@ -112,7 +112,7 @@ 
       return null;
     }
     foreach($this->aliveMembers as $index => $member) {
-      if($member->hitpoints <= $member->maxHitpoints * $threshold AND $member->hitpoints < $lowestHp) {
+      if($member->hitpoints <= $member->maxHitpoints * $threshold and $member->hitpoints < $lowestHp) {
         $lowestHp = $member->hitpoints;
         $lowestIndex = $index;
       }

src/CombatBase.php

Upper-Lower-Casing +7 added lines, -7 removed lines

@@ -237,7 +237,7 @@ 
       foreach($team as $character) {
         try {
           $column++;
-          if($character->positionRow > 0 AND $character->positionColumn > 0) {
+          if($character->positionRow > 0 and $character->positionColumn > 0) {
             continue;
           }
           setPosition:
@@ -290,7 +290,7 @@ 
     $characters = array_merge($combat->team1->toArray(), $combat->team2->toArray());
     foreach($characters as $character) {
       foreach($character->effects as $effect) {
-        if($effect->duration === CharacterEffect::DURATION_COMBAT OR is_int($effect->duration)) {
+        if($effect->duration === CharacterEffect::DURATION_COMBAT or is_int($effect->duration)) {
           $character->removeEffect($effect->id);
         }
       }
@@ -352,7 +352,7 @@ 
     $enemyTeam = $this->getEnemyTeam($attacker);
     $rangedWeapon = false;
     foreach($attacker->equipment as $equipment) {
-      if($equipment instanceof Weapon AND $equipment->isWorn() AND $equipment->ranged) {
+      if($equipment instanceof Weapon and $equipment->isWorn() and $equipment->ranged) {
         $rangedWeapon = true;
         break;
       }
@@ -412,7 +412,7 @@ 
         $targets = $this->getTeam($primaryTarget)->getItems(["positionColumn" => $primaryTarget->positionColumn]);
         break;
       default:
-        throw new NotImplementedException("Target $skill->skill->target for attack skills is not implemented.");
+        throw new NotImplementedException("target $skill->skill->target for attack skills is not implemented.");
     }
     foreach($targets as $target) {
       for($i = 1; $i <= $skill->skill->strikes; $i++) {
@@ -440,7 +440,7 @@ 
         $targets = $this->getEnemyTeam($character)->toArray();
         break;
       default:
-        throw new NotImplementedException("Target $skill->skill->target for special skills is not implemented.");
+        throw new NotImplementedException("target $skill->skill->target for special skills is not implemented.");
     }
     foreach($targets as $target) {
       $this->onSkillSpecial($character, $target, $skill);
@@ -478,7 +478,7 @@ 
           $combat->onHeal($character, $combat->selectHealingTarget($character));
           break;
         default:
-          throw new NotImplementedException("Action $action is not implemented.");
+          throw new NotImplementedException("action $action is not implemented.");
       }
     }
   }
@@ -589,7 +589,7 @@ 
       "character1" => $character1, "character2" => $target,
     ];
     $effect = new CharacterEffect([
-      "id" => "skill{$skill->skill->id}Effect",
+      "id" => "skill{$skill->skill->id}effect",
       "type" => $skill->skill->type,
       "stat" => ((in_array($skill->skill->type, SkillSpecial::NO_STAT_TYPES, true)) ? null : $skill->skill->stat),
       "value" => $skill->value,