heroesofabenez / combat

src/CombatActions/SkillSpecial.php

Braces +3 added lines, -1 removed lines

@@ -52,9 +52,11 @@
   /**
    * @throws NotImplementedException
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     /** @var CharacterSpecialSkill $skill */
     $skill = $character->usableSkills[0];
+  }
     $targets = [];
     switch($skill->skill->target) {
       case Skill::TARGET_ENEMY:

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
       "character1" => $character1, "character2" => $target,
     ];
     $effect = new CharacterEffect([
-      "id" => "skill{$skill->skill->id}Effect",
+      "id" => "skill{$skill->skill->id}effect",
       "type" => $skill->skill->type,
       "stat" => ((in_array($skill->skill->type, Skill::NO_STAT_TYPES, true)) ? null : $skill->skill->stat),
       "value" => $skill->value,
@@ -70,7 +70,7 @@ 
         $targets = $combat->getEnemyTeam($character)->toArray();
         break;
       default:
-        throw new NotImplementedException("Target {$skill->skill->target} for special skills is not implemented.");
+        throw new NotImplementedException("target {$skill->skill->target} for special skills is not implemented.");
     }
     foreach($targets as $target) {
       $this->doSingleTarget($character, $target, $skill, $combat);

src/CombatActions/Heal.php

Braces +3 added lines, -1 removed lines

@@ -21,8 +21,10 @@
     return (in_array($character, $combat->findHealers()->toArray(), true) AND !is_null($combat->selectHealingTarget($character)));
   }
 
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     $result = [];
+  }
     /** @var Character $patient */
     $patient = $combat->selectHealingTarget($character);
     $result["result"] = $combat->successCalculator->hasHealed($character);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
   }
 
   public function shouldUse(CombatBase $combat, Character $character): bool {
-    return (in_array($character, $combat->findHealers()->toArray(), true) AND !is_null($combat->selectHealingTarget($character)));
+    return (in_array($character, $combat->findHealers()->toArray(), true) and !is_null($combat->selectHealingTarget($character)));
   }
 
   public function do(CombatBase $combat, Character $character): void {

src/CombatActions/SkillAttack.php

Braces +3 added lines, -1 removed lines

@@ -54,9 +54,11 @@
   /**
    * @throws NotImplementedException
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     /** @var CharacterAttackSkill $skill */
     $skill = $character->usableSkills[0];
+  }
     $targets = [];
     /** @var Character $primaryTarget */
     $primaryTarget = $combat->selectAttackTarget($character);

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -71,7 +71,7 @@
         $targets = $combat->getTeam($primaryTarget)->getItems(["positionColumn" => $primaryTarget->positionColumn]);
         break;
       default:
-        throw new NotImplementedException("Target {$skill->skill->target} for attack skills is not implemented.");
+        throw new NotImplementedException("target {$skill->skill->target} for attack skills is not implemented.");
     }
     foreach($targets as $target) {
       for($i = 1; $i <= $skill->skill->strikes; $i++) {

src/CombatActions/ICombatAction.php

Braces +4 added lines, -2 removed lines

@@ -10,6 +10,8 @@
   public function getName(): string;
   public function getPriority(): int;
   public function shouldUse(CombatBase $combat, Character $character): bool;
-  public function do(CombatBase $combat, Character $character): void;
-}
+  public function do {
+    (CombatBase $combat, Character $character): void;
+  }
+  }
 ?>
\ No newline at end of file

src/CombatActions/Attack.php

Braces +3 added lines, -1 removed lines

@@ -26,8 +26,10 @@
    * Hit chance = Attacker's hit - Defender's dodge, but at least 15%
    * Damage = Attacker's damage - defender's defense
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     $result = [];
+  }
     /** @var Character $defender */
     $defender = $combat->selectAttackTarget($character);
     $result["result"] = $combat->successCalculator->hasHit($character, $defender);

src/CharacterEffect.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
   }
 
   protected function configureOptions(OptionsResolver $resolver): void {
-    $allStats = ["id", "type", "value", "valueAbsolute", "duration", "stat",];
+    $allStats = ["id", "type", "value", "valueAbsolute", "duration", "stat", ];
     $resolver->setRequired($allStats);
     $resolver->setAllowedTypes("id", "string");
     $resolver->setAllowedTypes("type", "string");

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -46,7 +46,7 @@ 
     $resolver = new OptionsResolver();
     $this->configureOptions($resolver);
     $effect = $resolver->resolve($effect);
-    if(!in_array($effect["type"], SkillSpecial::NO_STAT_TYPES, true) AND $effect["stat"] === "") {
+    if(!in_array($effect["type"], SkillSpecial::NO_STAT_TYPES, true) and $effect["stat"] === "") {
       throw new \InvalidArgumentException("The option stat with value '' is invalid.");
     }
     $this->id = $effect["id"];
@@ -80,14 +80,14 @@ 
     $resolver->setAllowedTypes("stat", "string");
     $resolver->setDefault("stat", "");
     $resolver->setAllowedValues("stat", function(string $value) {
-      return $value === "" OR in_array($value, $this->getAllowedStats(), true);
+      return $value === "" or in_array($value, $this->getAllowedStats(), true);
     });
     $resolver->setAllowedTypes("value", "integer");
     $resolver->setAllowedTypes("valueAbsolute", "bool");
     $resolver->setDefault("value", 0);
     $resolver->setAllowedTypes("duration", ["string", "integer"]);
     $resolver->setAllowedValues("duration", function($value) {
-      return (in_array($value, $this->getDurations(), true)) OR ($value > 0);
+      return (in_array($value, $this->getDurations(), true)) or ($value > 0);
     });
   }
   
@@ -148,7 +148,7 @@ 
    * @throws \InvalidArgumentException
    */
   public function setDuration($value): void {
-    if(!is_int($value) AND !in_array($value, $this->getDurations(), true)) {
+    if(!is_int($value) and !in_array($value, $this->getDurations(), true)) {
       throw new \InvalidArgumentException("Invalid value set to CharacterEffect::\$duration. Expected string or integer.");
     }
     $this->duration = $value;

src/TextCombatLogRender.php

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
    */
   public function setTemplate(string $template): void {
     if(!is_file($template)) {
-      throw new \RuntimeException("File $template does not exist.");
+      throw new \RuntimeException("file $template does not exist.");
     }
     $this->template = $template;
   }
@@ -54,14 +54,14 @@ 
       case CombatLogEntry::ACTION_ATTACK:
         $message = ($item->result) ? "combat.log.attackHits" : "combat.log.attackFails";
         $text = $this->translator->translate($message, $item->amount, ["character1" => $character1, "character2" => $character2]);
-        if($item->result AND $item->character2->hitpoints < 1) {
+        if($item->result and $item->character2->hitpoints < 1) {
           $text .= $this->translator->translate("combat.log.characterFalls");
         }
         return $text;
       case CombatLogEntry::ACTION_SKILL_ATTACK:
         $message = ($item->result) ? "combat.log.specialAttackHits" : "combat.log.specialAttackFails";
         $text = $this->translator->translate($message, $item->amount, ["character1" => $character1, "character2" => $character2, "name" => $item->name]);
-        if($item->result AND $item->character2->hitpoints < 1) {
+        if($item->result and $item->character2->hitpoints < 1) {
           $text .= $this->translator->translate("combat.log.characterFalls");
         }
         return $text;

src/CombatLogEntry.php

Spacing +2 added lines, -2 removed lines

@@ -51,8 +51,8 @@
   }
 
   protected function configureOptions(OptionsResolver $resolver): void {
-    $requiredStats = ["action", "result", "character1", "character2",];
-    $resolver->setDefined(["amount", "name",]);
+    $requiredStats = ["action", "result", "character1", "character2", ];
+    $resolver->setDefined(["amount", "name", ]);
     $resolver->setRequired($requiredStats);
     $resolver->setAllowedTypes("action", "string");
     $resolver->setAllowedTypes("result", "bool");