Heal::do() - Code Metrics - Inspection of "do not validate action in CombatLogEntry" - heroesofabenez/combat - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ff1e5a...9ad4f6 )

by Jakub

created 2018-12-21 19:19 UTC

Heal::do() A

↳ Parent: Heal

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3.0052

Importance

Changes

Metric	Value
eloc	13
dl	0
loc	15
ccs	11
cts	12
cp	0.9167
rs	9.8333
c	0
b	0
f	0
cc	3
nc	4
nop	2
crap	3.0052

<?php
declare(strict_types=1);

namespace HeroesofAbenez\Combat\CombatActions;

use HeroesofAbenez\Combat\Character;
use HeroesofAbenez\Combat\CombatBase;
use HeroesofAbenez\Combat\CombatLogEntry;
use Nexendrie\Utils\Numbers;

final class Heal implements ICombatAction {
  use \Nette\SmartObject;

  public function getName(): string {
    return CombatLogEntry::ACTION_HEALING;
  }

  public function getPriority(): int {
    return 1000;
  }

  public function shouldUse(CombatBase $combat, Character $character): bool {
    return (in_array($character, $combat->findHealers()->toArray(), true) AND !is_null($combat->selectHealingTarget($character)));

  }

  public function do(CombatBase $combat, Character $character): void {
    $result = [];
    /** @var Character $patient */
    $patient = $combat->selectHealingTarget($character);
    $result["result"] = $combat->successCalculator->hasHealed($character);
    $amount = ($result["result"]) ? (int) ($character->intelligence / 2) : 0;
    $result["amount"] = Numbers::range($amount, 0, $patient->maxHitpoints - $patient->hitpoints);
    if($result["amount"] > 0) {
      $patient->heal($result["amount"]);
    }
    $result["action"] = $this->getName();
    $result["name"] = "";
    $result["character1"] = $character;
    $result["character2"] = $patient;
    $combat->log->log($result);
  }
}
?>

1		<?php
2		declare(strict_types=1);
3
4		namespace HeroesofAbenez\Combat\CombatActions;
5
6		use HeroesofAbenez\Combat\Character;
7		use HeroesofAbenez\Combat\CombatBase;
8		use HeroesofAbenez\Combat\CombatLogEntry;
9		use Nexendrie\Utils\Numbers;
10
11	1	final class Heal implements ICombatAction {
12	1	use \Nette\SmartObject;
13
14		public function getName(): string {
15	1	return CombatLogEntry::ACTION_HEALING;
16		}
17
18		public function getPriority(): int {
19	1	return 1000;
20		}
21
22		public function shouldUse(CombatBase $combat, Character $character): bool {
23	1	return (in_array($character, $combat->findHealers()->toArray(), true) AND !is_null($combat->selectHealingTarget($character)));
		0 ignored issues – show introduced 2018-11-18 18:55 UTC by Report Bug Copy Issue Report Line exceeds 120 characters; contains 130 characters Loading history...
24		}
25
26		public function do(CombatBase $combat, Character $character): void {
27	1	$result = [];
28		/** @var Character $patient */
29	1	$patient = $combat->selectHealingTarget($character);
30	1	$result["result"] = $combat->successCalculator->hasHealed($character);
31	1	$amount = ($result["result"]) ? (int) ($character->intelligence / 2) : 0;
32	1	$result["amount"] = Numbers::range($amount, 0, $patient->maxHitpoints - $patient->hitpoints);
33	1	if($result["amount"] > 0) {
34		$patient->heal($result["amount"]);
35		}
36	1	$result["action"] = $this->getName();
37	1	$result["name"] = "";
38	1	$result["character1"] = $character;
39	1	$result["character2"] = $patient;
40	1	$combat->log->log($result);
41	1	}
42		}
43		?>

heroesofabenez / combat

Push — master ( ff1e5a...9ad4f6 )

Heal::do() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like