heroesofabenez / combat

tests/HeroesofAbenez/Combat/CombatBaseTest.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
   
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     $petStats = [

tests/HeroesofAbenez/Combat/CombatActions/SkillAttackTest.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     $skillData = [

tests/HeroesofAbenez/Combat/CharacterTest.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 final class CharacterTest extends \Tester\TestCase {
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

src/CombatActions/SkillAttack.php

Braces +3 added lines, -1 removed lines

@@ -58,9 +58,11 @@
   /**
    * @throws NotImplementedException
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     /** @var CharacterAttackSkill $skill */
     $skill = $character->usableSkills[0];
+  }
     /** @var Character $primaryTarget */
     $primaryTarget = $combat->selectAttackTarget($character);
     $targets = match($skill->skill->target) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
       Skill::TARGET_SINGLE => [$primaryTarget],
       Skill::TARGET_ROW => $combat->getTeam($primaryTarget)->getItems(["positionRow" => $primaryTarget->positionRow]),
       Skill::TARGET_COLUMN => $combat->getTeam($primaryTarget)->getItems(["positionColumn" => $primaryTarget->positionColumn]),
-      default => throw new NotImplementedException("Target {$skill->skill->target} for attack skills is not implemented."),
+      default => throw new NotImplementedException("target {$skill->skill->target} for attack skills is not implemented."),
     };
     /** @var Character $target */
     foreach($targets as $target) {

src/CombatActions/SkillSpecial.php

Braces +3 added lines, -1 removed lines

@@ -56,9 +56,11 @@
   /**
    * @throws NotImplementedException
    */
-  public function do(CombatBase $combat, Character $character): void {
+  public function do {
+    (CombatBase $combat, Character $character): void {
     /** @var CharacterSpecialSkill $skill */
     $skill = $character->usableSkills[0];
+  }
     $targets = match($skill->skill->target) {
       Skill::TARGET_ENEMY => [$combat->selectAttackTarget($character)],
       Skill::TARGET_SELF => [$character],

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
       "character1" => $character1, "character2" => $target,
     ];
     $effect = new CharacterEffect([
-      "id" => "skill{$skill->skill->id}Effect",
+      "id" => "skill{$skill->skill->id}effect",
       "type" => $skill->skill->type,
       "stat" => ((in_array($skill->skill->type, Skill::NO_STAT_TYPES, true)) ? null : $skill->skill->stat),
       "value" => $skill->value,
@@ -64,7 +64,7 @@ 
       Skill::TARGET_SELF => [$character],
       Skill::TARGET_PARTY => $combat->getTeam($character)->toArray(),
       Skill::TARGET_ENEMY_PARTY => $combat->getEnemyTeam($character)->toArray(),
-      default => throw new NotImplementedException("Target {$skill->skill->target} for special skills is not implemented."),
+      default => throw new NotImplementedException("target {$skill->skill->target} for special skills is not implemented."),
     };
     foreach($targets as $target) {
       $this->doSingleTarget($character, $target, $skill, $combat);

src/Character.php

Spacing +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
   public const STATUS_POISONED = "poisoned";
   public const STATUS_HIDDEN = "hidden";
 
-  protected int|string $id;
+  protected int | string $id;
   protected string $name;
   protected string $gender = "male";
   protected string $race;
@@ -200,7 +200,7 @@ 
     $this->dodgeBase = $this->dodge;
   }
 
-  protected function getId(): int|string {
+  protected function getId(): int | string {
     return $this->id;
   }
 

src/CharacterEffect.php

Spacing +3 added lines, -3 removed lines

@@ -25,7 +25,7 @@ 
   public readonly string $stat;
   public readonly int $value;
   public readonly bool $valueAbsolute;
-  protected int|string $duration;
+  protected int | string $duration;
   /** @var callable[] */
   public array $onApply = [];
   /** @var callable[] */
@@ -102,14 +102,14 @@ 
     return Constants::getConstantsValues(static::class, "DURATION_");
   }
 
-  protected function getDuration(): int|string {
+  protected function getDuration(): int | string {
     return $this->duration;
   }
   
   /**
    * @throws \InvalidArgumentException
    */
-  protected function setDuration(string|int $value): void {
+  protected function setDuration(string | int $value): void {
     if(!is_int($value) && !in_array($value, $this->getDurations(), true)) {
       throw new \InvalidArgumentException("Invalid value set to CharacterEffect::\$duration. Expected string or integer.");
     }

tests/HeroesofAbenez/Combat/CombatLoggerTest.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
   
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);

tests/HeroesofAbenez/Combat/CombatActions/HealTest.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
   
   protected function generateCharacter(int $id): Character {
     $stats = [
-      "id" => $id, "name" => "Player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
+      "id" => $id, "name" => "player $id", "level" => 1, "initiativeFormula" => "1d2+DEX/4", "strength" => 10,
       "dexterity" => 10, "constitution" => 10, "intelligence" => 10, "charisma" => 10
     ];
     return new Character($stats);