Passed
Push — master ( 4271e8...d7b53e )
by Jakub
02:40
created
src/SkillSpecial.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
     });
75 75
     $resolver->setAllowedTypes("stat", ["string", "null"]);
76 76
     $resolver->setAllowedValues("stat", function(?string $value) {
77
-      return is_null($value) OR in_array($value, $this->getAllowedStats(), true);
77
+      return is_null($value) or in_array($value, $this->getAllowedStats(), true);
78 78
     });
79 79
     $resolver->setAllowedTypes("value", "integer");
80 80
     $resolver->setAllowedValues("value", function(int $value) {
Please login to merge, or discard this patch.
src/Equipment.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
     });
62 62
     $resolver->setAllowedTypes("type", ["string", "null"]);
63 63
     $resolver->setAllowedValues("type", function(?string $value) {
64
-      return is_null($value) OR in_array($value, $this->getAllowedTypes(), true);
64
+      return is_null($value) or in_array($value, $this->getAllowedTypes(), true);
65 65
     });
66 66
     $resolver->setAllowedTypes("strength", "integer");
67 67
     $resolver->setAllowedValues("strength", function(int $value) {
Please login to merge, or discard this patch.
src/Team.php 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
    */
71 71
   public function getActiveMembers(): array {
72 72
     return array_values(array_filter($this->items, function(Character $value) {
73
-      return (!$value->stunned AND $value->hitpoints > 0);
73
+      return (!$value->stunned and $value->hitpoints > 0);
74 74
     }));
75 75
   }
76 76
   
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
    */
93 93
   public function getUsableMembers(): array {
94 94
     return array_values(array_filter($this->items, function(Character $value) {
95
-      return (!$value->stunned AND $value->hitpoints > 0);
95
+      return (!$value->stunned and $value->hitpoints > 0);
96 96
     }));
97 97
   }
98 98
   
Please login to merge, or discard this patch.
src/CombatBase.php 1 patch
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
     $characters = array_merge($combat->team1->items, $combat->team2->items);
298 298
     foreach($characters as $character) {
299 299
       foreach($character->effects as $effect) {
300
-        if($effect->duration === CharacterEffect::DURATION_COMBAT OR is_int($effect->duration)) {
300
+        if($effect->duration === CharacterEffect::DURATION_COMBAT or is_int($effect->duration)) {
301 301
           $character->removeEffect($effect->id);
302 302
         }
303 303
       }
@@ -388,7 +388,7 @@  discard block
 block discarded – undo
388 388
       $threshold = static::LOWEST_HP_THRESHOLD;
389 389
     }
390 390
     foreach($team->aliveMembers as $index => $member) {
391
-      if($member->hitpoints <= $member->maxHitpoints * $threshold AND $member->hitpoints < $lowestHp) {
391
+      if($member->hitpoints <= $member->maxHitpoints * $threshold and $member->hitpoints < $lowestHp) {
392 392
         $lowestHp = $member->hitpoints;
393 393
         $lowestIndex = $index;
394 394
       }
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
   protected function chooseAction(CombatBase $combat, Character $character): ?string {
441 441
     if($character->hitpoints < 1) {
442 442
       return NULL;
443
-    } elseif(in_array($character, $combat->findHealers()->items, true) AND !is_null($combat->selectHealingTarget($character))) {
443
+    } elseif(in_array($character, $combat->findHealers()->items, true) and !is_null($combat->selectHealingTarget($character))) {
444 444
       return CombatAction::ACTION_HEALING;
445 445
     }
446 446
     $attackTarget = $combat->selectAttackTarget($character);
@@ -635,7 +635,7 @@  discard block
 block discarded – undo
635 635
     ];
636 636
     $this->results = $result;
637 637
     $effect = [
638
-      "id" => "skill{$skill->skill->id}Effect",
638
+      "id" => "skill{$skill->skill->id}effect",
639 639
       "type" => $skill->skill->type,
640 640
       "stat" => ((in_array($skill->skill->type, SkillSpecial::NO_STAT_TYPES, true)) ? NULL : $skill->skill->stat),
641 641
       "value" => $skill->value,
Please login to merge, or discard this patch.
src/Character.php 1 patch
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
    * @throws \OutOfBoundsException
430 430
    */
431 431
   public function getPet(int $petId): Pet {
432
-    if(isset($this->pets[$petId]) AND $this->pets[$petId] instanceof Pet) {
432
+    if(isset($this->pets[$petId]) and $this->pets[$petId] instanceof Pet) {
433 433
       return $this->pets[$petId];
434 434
     }
435 435
     throw new \OutOfBoundsException("Pet was not found.");
@@ -489,7 +489,7 @@  discard block
 block discarded – undo
489 489
   public function damageStat(): string {
490 490
     $stat = "strength";
491 491
     foreach($this->equipment as $item) {
492
-      if(!$item->worn OR $item->slot != Equipment::SLOT_WEAPON) {
492
+      if(!$item->worn or $item->slot != Equipment::SLOT_WEAPON) {
493 493
         continue;
494 494
       }
495 495
       switch($item->type) {
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
       $stat = $effect->stat;
543 543
       $type = $effect->type;
544 544
       $duration = $effect->duration;
545
-      if(is_int($duration) AND $duration < 0) {
545
+      if(is_int($duration) and $duration < 0) {
546 546
         unset($this->effects[$i]);
547 547
         continue;
548 548
       }
Please login to merge, or discard this patch.
src/CharacterEffect.php 1 patch
Upper-Lower-Casing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     $resolver->setAllowedTypes("stat", "string");
53 53
     $resolver->setDefault("stat", "");
54 54
     $resolver->setAllowedValues("stat", function(string $value) {
55
-      return $value === "" OR in_array($value, $this->getAllowedStats(), true);
55
+      return $value === "" or in_array($value, $this->getAllowedStats(), true);
56 56
     });
57 57
     $resolver->setAllowedTypes("source", "string");
58 58
     $resolver->setAllowedValues("source", function(string $value) {
@@ -62,10 +62,10 @@  discard block
 block discarded – undo
62 62
     $resolver->setDefault("value", 0);
63 63
     $resolver->setAllowedTypes("duration", ["string", "integer"]);
64 64
     $resolver->setAllowedValues("duration", function($value) {
65
-      return (in_array($value, $this->getDurations(), true)) OR ($value > 0);
65
+      return (in_array($value, $this->getDurations(), true)) or ($value > 0);
66 66
     });
67 67
     $effect = $resolver->resolve($effect);
68
-    if(!in_array($effect["type"], SkillSpecial::NO_STAT_TYPES, true) AND $effect["stat"] === "") {
68
+    if(!in_array($effect["type"], SkillSpecial::NO_STAT_TYPES, true) and $effect["stat"] === "") {
69 69
       throw new \InvalidArgumentException("The option stat with value '' is invalid.");
70 70
     }
71 71
     $this->id = $effect["id"];
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
    * @throws \InvalidArgumentException
136 136
    */
137 137
   public function setDuration($value) {
138
-    if(!is_int($value) AND !in_array($value, $this->getDurations(), true)) {
138
+    if(!is_int($value) and !in_array($value, $this->getDurations(), true)) {
139 139
       throw new \InvalidArgumentException("Invalid value set to CharacterEffect::\$duration. Expected string or integer.");
140 140
     }
141 141
     $this->duration = $value;
Please login to merge, or discard this patch.