heroesofabenez /
combat
| Conditions | 13 |
| Paths | 13 |
| Total Lines | 47 |
| Code Lines | 38 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 34 |
| CRAP Score | 13 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 47 | public function renderItem($item): string { |
||
|
introduced
by
|
|||
| 48 | 1 | if(!$item instanceof CombatLogEntry) { |
|
| 49 | 1 | return $item; |
|
| 50 | } |
||
| 51 | 1 | $character1 = $item->character1->name; |
|
| 52 | 1 | $character2 = $item->character2->name; |
|
| 53 | 1 | $text = ""; |
|
| 54 | 1 | switch($item->action) { |
|
| 55 | 1 | case CombatLogEntry::ACTION_ATTACK: |
|
| 56 | 1 | if($item->result) { |
|
| 57 | 1 | $text = $this->translator->translate("combat.log.attackHits", $item->amount, ["character1" => $character1, "character2" => $character2]); |
|
| 58 | 1 | if($item->character2->hitpoints < 1) { |
|
| 59 | 1 | $text .= $this->translator->translate("combat.log.characterFalls"); |
|
| 60 | } |
||
| 61 | } else { |
||
| 62 | 1 | $text = $this->translator->translate("combat.log.attackFails", $item->amount, ["character1" => $character1, "character2" => $character2]); |
|
| 63 | } |
||
| 64 | 1 | break; |
|
| 65 | 1 | case CombatLogEntry::ACTION_SKILL_ATTACK: |
|
| 66 | 1 | if($item->result) { |
|
| 67 | 1 | $text = $this->translator->translate("combat.log.specialAttackHits", $item->amount, ["character1" => $character1, "character2" => $character2, "name" => $item->name]); |
|
| 68 | 1 | if($item->character2->hitpoints < 1) { |
|
| 69 | 1 | $text .= $this->translator->translate("combat.log.characterFalls"); |
|
| 70 | } |
||
| 71 | } else { |
||
| 72 | 1 | $text = $this->translator->translate("combat.log.specialAttackFails", $item->amount, ["character1" => $character1, "character2" => $character2, "name" => $item->name]); |
|
| 73 | } |
||
| 74 | 1 | break; |
|
| 75 | 1 | case CombatLogEntry::ACTION_SKILL_SPECIAL: |
|
| 76 | 1 | if($item->result) { |
|
| 77 | 1 | $text = $this->translator->translate("combat.log.specialSkillSuccess", 0, ["character1" => $character1, "character2" => $character2, "name" => $item->name]); |
|
| 78 | } else { |
||
| 79 | 1 | $text = $this->translator->translate("combat.log.specialSKillFailure", 0, ["character1" => $character1, "character2" => $character2, "name" => $item->name]); |
|
| 80 | } |
||
| 81 | 1 | break; |
|
| 82 | 1 | case CombatLogEntry::ACTION_HEALING: |
|
| 83 | 1 | if($item->result) { |
|
| 84 | 1 | $text = $this->translator->translate("combat.log.healingSuccess", $item->amount, ["character1" => $character1, "character2" => $character2]); |
|
| 85 | } else { |
||
| 86 | 1 | $text = $this->translator->translate("combat.log.healingFailure", $item->amount, ["character1" => $character1, "character2" => $character2]); |
|
| 87 | } |
||
| 88 | 1 | break; |
|
| 89 | 1 | case CombatLogEntry::ACTION_POISON: |
|
| 90 | 1 | $text = $this->translator->translate("combat.log.poison", $item->amount, ["character1" => $character1]); |
|
| 91 | 1 | break; |
|
| 92 | } |
||
| 93 | 1 | return $text; |
|
| 94 | } |
||
| 96 | ?> |
Loading history...