BaseCharacterSkill::getCooldown() - Code Metrics - Inspection of "made some properties of Character public" - heroesofabenez/combat - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( d0ce80...210dba )

by Jakub

created 2020-09-05 17:43 UTC

BaseCharacterSkill::getCooldown() A

↳ Parent: BaseCharacterSkill

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	1
c	2
b	0
f	0
dl	0
loc	2
ccs	0
cts	1
cp	0
rs	10
cc	1
nc	1
nop	0
crap	2

<?php
declare(strict_types=1);

namespace HeroesofAbenez\Combat;

use Nexendrie\Utils\Numbers;

/**
 * Base character skill
 *
 * @author Jakub Konečný
 * @property-read BaseSkill $skill
 * @property int $level
 * @property-read int $cooldown
 * @property-read string $skillType
 * @property-read bool $usable
 */
abstract class BaseCharacterSkill {
  use \Nette\SmartObject;

  /** @var BaseSkill */
  protected $skill;
  protected int $level;
  protected int $cooldown = 0;
  
  public function __construct(BaseSkill $skill, int $level) {
    $this->skill = $skill;
    $this->setLevel($level);
    $this->resetCooldown();
  }

  abstract protected function getSkillType(): string;
  
  protected function getLevel(): int {
    return $this->level;
  }
  
  protected function getCooldown(): int {
    return $this->cooldown;
  }
  
  protected function setLevel(int $level): void {
    $this->level = Numbers::range($level, 0, $this->skill->levels);
  }
  
  protected function isUsable(): bool {
    return ($this->cooldown < 1);
  }
  
  public function resetCooldown(): void {
    $this->cooldown = $this->skill->cooldown;
  }
  
  public function decreaseCooldown(): void {
    if($this->cooldown > 0) {
      $this->cooldown--;
    }
  }
}
?>

1		<?php
2		declare(strict_types=1);
3
4		namespace HeroesofAbenez\Combat;
5
6		use Nexendrie\Utils\Numbers;
7
8		/**
9		* Base character skill
10		*
11		* @author Jakub Konečný
12		* @property-read BaseSkill $skill
13		* @property int $level
14		* @property-read int $cooldown
15		* @property-read string $skillType
16		* @property-read bool $usable
17		*/
18	1	abstract class BaseCharacterSkill {
19		use \Nette\SmartObject;
20
21		/** @var BaseSkill */
22		protected $skill;
23		protected int $level;
24		protected int $cooldown = 0;
25
26		public function __construct(BaseSkill $skill, int $level) {
27	1	$this->skill = $skill;
28	1	$this->setLevel($level);
29	1	$this->resetCooldown();
30	1	}
31
32		abstract protected function getSkillType(): string;
33
34		protected function getLevel(): int {
35	1	return $this->level;
36		}
37
38		protected function getCooldown(): int {
39		return $this->cooldown;
40		}
41
42		protected function setLevel(int $level): void {
43	1	$this->level = Numbers::range($level, 0, $this->skill->levels);
44	1	}
45
46		protected function isUsable(): bool {
47	1	return ($this->cooldown < 1);
48		}
49
50		public function resetCooldown(): void {
51	1	$this->cooldown = $this->skill->cooldown;
52	1	}
53
54		public function decreaseCooldown(): void {
55	1	if($this->cooldown > 0) {
56	1	$this->cooldown--;
57		}
58	1	}
59		}
60		?>

heroesofabenez / combat

Push — master ( d0ce80...210dba )

BaseCharacterSkill::getCooldown() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like