henrystivens / upload-image-and-data

core/libs/db/adapters/firebird.php

Doc Comments +1 added lines, -1 removed lines

@@ -138,7 +138,7 @@
      * Efectua operaciones SQL sobre la base de datos
      *
      * @param string $sql_query
-     * @return resource or false
+     * @return resource|null or false
      */
     public function query($sql_query)
     {

core/libs/db/adapters/informix.php

Doc Comments +2 added lines, -2 removed lines

@@ -580,7 +580,7 @@ 
      * @param string $table
      * @param array $values
      * @param array $fields
-     * @return boolean
+     * @return resource|null
      */
     public function insert($table, $values, $fields=null)
     {
@@ -595,7 +595,7 @@ 
      * @param array $fields
      * @param array $values
      * @param string $where_condition
-     * @return boolean
+     * @return resource|null
      */
     public function update($table, $fields, $values, $where_condition=null)
     {

core/libs/db/adapters/mysqli.php

Doc Comments +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
     /**
      * Cierra la Conexión al Motor de Base de datos
      *
-     * @return boolean
+     * @return boolean|null
      */
     public function close()
     {

Braces +9 added lines, -3 removed lines

@@ -117,13 +117,19 @@
      */
     public function connect($config)
     {
-        if (!extension_loaded('mysqli')) throw new KumbiaException('Debe cargar la extensión de PHP llamada php_mysqli');
+        if (!extension_loaded('mysqli')) {
+            throw new KumbiaException('Debe cargar la extensión de PHP llamada php_mysqli');
+        }
 
         $this->id_connection = new mysqli($config['host'], $config['username'], $config['password'], $config['name'], $config['port']);
         //no se usa $object->error() ya que solo funciona a partir de 5.2.9 y 5.3
-        if (mysqli_connect_error ()) throw new KumbiaException(mysqli_connect_error());
+        if (mysqli_connect_error ()) {
+            throw new KumbiaException(mysqli_connect_error());
+        }
         //Selecciona charset
-        if (isset($config['charset'])) $this->id_connection->set_charset($config['charset']);
+        if (isset($config['charset'])) {
+            $this->id_connection->set_charset($config['charset']);
+        }
         return TRUE;
     }
 

core/libs/db/adapters/pdo/pgsql.php

Doc Comments +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
     /**
      * Devuelve el ultimo id autonumerico generado en la BD
      *
-     * @return integer
+     * @return string
      */
     public function last_insert_id($table='', $primary_key='')
     {

core/libs/db/adapters/pdo/sqlite.php

Doc Comments +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
      *
      * @param string $table
      * @param array $definition
-     * @return boolean
+     * @return integer
      */
     public function create_table($table, $definition, $index=array())
     {

core/libs/db/db_base.php

Doc Comments +2 added lines, -3 removed lines

@@ -170,7 +170,7 @@ 
      * @param string $table
      * @param array $values
      * @param array $fields
-     * @return boolean
+     * @return resource|null
      */
     public function insert($table, $values, $fields=null)
     {
@@ -197,7 +197,7 @@ 
      * @param array $fields
      * @param array $values
      * @param string $where_condition
-     * @return boolean
+     * @return resource|null
      */
     public function update($table, $fields, $values, $where_condition=null)
     {
@@ -298,7 +298,6 @@ 
     /**
      * Efectua operaciones SQL sobre la base de datos
      * Este método lo extienden los adapters
-     * @param string $sql_query
      * @return resource or false
      */
     public function query($sql)

core/libs/kumbia_active_record/kumbia_active_record.php

Doc Comments +5 added lines, -7 removed lines

@@ -661,7 +661,7 @@ 
     /**
      * Commit a Transaction
      *
-     * @return success
+     * @return resource|null
      */
     public function commit()
     {
@@ -671,7 +671,7 @@ 
     /**
      * Rollback a Transaction
      *
-     * @return success
+     * @return resource|null
      */
     public function rollback()
     {
@@ -681,7 +681,7 @@ 
     /**
      * Start a transaction in RDBM
      *
-     * @return success
+     * @return resource|null
      */
     public function begin()
     {
@@ -725,7 +725,7 @@ 
      * Execute a SQL Statement directly
      *
      * @param string $sqlQuery
-     * @return int affected
+     * @return resource|null affected
      */
     public function sql($sqlQuery)
     {
@@ -1217,7 +1217,6 @@ 
     /**
      * Creates a new Row in map table
      *
-     * @param mixed $values
      * @return boolean success
      */
     public function create()
@@ -1785,7 +1784,6 @@ 
     /**
      * Updates Data in the Relational Table
      *
-     * @param mixed $values
      * @return boolean|null sucess
      */
     function update()
@@ -1943,7 +1941,7 @@ 
      * Delete All data from Relational Map Table
      *
      * @param string $conditions
-     * @return boolean
+     * @return resource|null
      */
     public function delete_all($conditions = '')
     {

Braces +53 added lines, -36 removed lines

@@ -277,7 +277,9 @@ 
         $this->_connect();
 
         if ($data) {
-            if (!is_array($data)) $data = Util::getParams(func_get_args());
+            if (!is_array($data)) {
+                $data = Util::getParams(func_get_args());
+            }
             foreach($this->fields as $field) {
                 if (isset($data[$field])) {
                     $this->$field = $data[$field];
@@ -394,7 +396,7 @@ 
                 } else {
                     $relation->through = "{$relation_source}_{$this->source}";
                 }
-            }else{
+            } else{
                 $through = explode('/', $relation->through);
                 $relation->through = end($through);
             }
@@ -593,8 +595,9 @@ 
             if ($field['Key'] == 'PRI') {
                 $this->primary_key[] = $field['Field'];
                 $this->alias[$field['Field']] = 'Código';
-            } else
-                $this->non_primary[] = $field['Field'];
+            } else {
+                            $this->non_primary[] = $field['Field'];
+            }
             /**
              * Si se indica que no puede ser nulo, pero se indica un
              * valor por defecto, entonces no se incluye en la lista, ya que
@@ -1282,8 +1285,9 @@ 
     public function save($values=null)
     {
         if ($values) {
-            if (!is_array($values))
-                $values = Util::getParams(func_get_args());
+            if (!is_array($values)) {
+                            $values = Util::getParams(func_get_args());
+            }
             foreach ($this->fields as $field) {
                 if (isset($values[$field])) {
                     $this->$field = $values[$field];
@@ -1345,8 +1349,9 @@ 
         if (isset($this->_validates['presence_of'])) {
             foreach ($this->_validates['presence_of'] as $f => $opt) {
                 if (isset($this->$f) && (is_null($this->$f) || $this->$f == '')) {
-                    if (!$ex && $f == $this->primary_key[0])
-                        continue;
+                    if (!$ex && $f == $this->primary_key[0]) {
+                                            continue;
+                    }
                     if (isset($opt['message'])) {
                         Flash::error($opt['message']);
                         return false;
@@ -1396,18 +1401,20 @@ 
                     $field = isset($opt['field']) ? $opt['field'] : $f;
 
                     if (strlen($this->$f) < $opt['min']) {
-                        if (isset($opt['too_short']))
-                            Flash::error($opt['too_short']);
-                        else
-                            Flash::error("Error: El campo $field debe tener como mínimo $opt[min] caracteres");
+                        if (isset($opt['too_short'])) {
+                                                    Flash::error($opt['too_short']);
+                        } else {
+                                                    Flash::error("Error: El campo $field debe tener como mínimo $opt[min] caracteres");
+                        }
                         return false;
                     }
 
                     if (strlen($this->$f) > $opt['max']) {
-                        if (isset($opt['too_long']))
-                            Flash::error($opt['too_long']);
-                        else
-                            Flash::error("Error: El campo $field debe tener como máximo $opt[max] caracteres");
+                        if (isset($opt['too_long'])) {
+                                                    Flash::error($opt['too_long']);
+                        } else {
+                                                    Flash::error("Error: El campo $field debe tener como máximo $opt[max] caracteres");
+                        }
                         return false;
                     }
                 }
@@ -1569,8 +1576,9 @@ 
             } else {
                 if (isset($this->after_validation_on_update)) {
                     $method = $this->after_validation_on_update;
-                    if ($this->$method() == 'cancel')
-                        return false;
+                    if ($this->$method() == 'cancel') {
+                                            return false;
+                    }
                 }
             }
         }
@@ -2008,8 +2016,9 @@ 
      */
     protected function validates_presence_of($field, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['presence_of'][$field] = $params;
     }
@@ -2029,8 +2038,9 @@ 
      */
     protected function validates_length_of($field, $max, $min=0, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['length_of'][$field] = $params;
         $this->_validates['length_of'][$field]['min'] = $min;
@@ -2049,8 +2059,9 @@ 
      */
     protected function validates_inclusion_in($field, $list, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['inclusion_in'][$field] = $params;
         $this->_validates['inclusion_in'][$field]['list'] = $list;
@@ -2068,8 +2079,9 @@ 
      */
     protected function validates_exclusion_of($field, $list, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['exclusion_of'][$field] = $params;
         $this->_validates['exclusion_of'][$field]['list'] = $list;
@@ -2087,8 +2099,9 @@ 
      */
     protected function validates_format_of($field, $pattern, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['format_of'][$field] = $params;
         $this->_validates['format_of'][$field]['pattern'] = $pattern;
@@ -2105,8 +2118,9 @@ 
      */
     protected function validates_numericality_of($field, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['numericality_of'][$field] = $params;
     }
@@ -2122,8 +2136,9 @@ 
      */
     protected function validates_email_in($field, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['email_in'][$field] = $params;
     }
@@ -2139,8 +2154,9 @@ 
      */
     protected function validates_uniqueness_of($field, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['uniqueness_of'][$field] = $params;
     }
@@ -2156,8 +2172,9 @@ 
      */
     protected function validates_date_in($field, $params=array())
     {
-        if (is_string($params))
-            $params = Util::getParams(func_get_args());
+        if (is_string($params)) {
+                    $params = Util::getParams(func_get_args());
+        }
 
         $this->_validates['date_in'][$field] = $params;
     }

core/libs/upload/upload.php

Doc Comments +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
     /**
      * Asigna las extensiones de archivos permitidas
      *
-     * @param array|string $value lista de extensiones para archivos, si es string separado por |
+     * @param string[] $value lista de extensiones para archivos, si es string separado por |
      */
     public function setExtensions($value) {
         if (!is_array($value)) {

default/app/models/user.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     /**
      * Sube y actualiza la foto del usuario.
      * 
-     * @return boolean | null
+     * @return boolean|null | null
      */
     public function updatePhoto() {
         if ($photo = $this->uploadPhoto('photo')) {