UserController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	58
Duplicated Lines	53.45 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	edit()	15	15	3
A	index()	0	3	1
A	create()	0	14	3
A	update_photo()	15	15	3

<?php

/**
 * Controlador para las acciones y vistas con el usuario
 */
class UserController extends AppController
{

    public function index()
    {
        $this->data = (new User)->find();
    }

    public function create()
    {
        //se verifica si se ha enviado via POST los datos
        if (Input::hasPost('user')) {
            $obj = new User;
            //Intenta guardar el usuario junto con la foto
            if ($obj->saveWithPhoto(Input::post('user'))) {
                //Mensaje de éxito y retorna al listado
                Flash::valid('Usuario creado');
                return Redirect::to();

Are you sure the usage of Redirect::to() targeting Redirect::to() seems to always return null.

            }
            //Si falla se hacen persistentes los datos en el formulario
            $this->data = Input::post('user');
            return;
        }
    }

    public function edit(int $id)//validación 'int' con php7

This method seems to be duplicated in your project.

    {
        //Carga los datos del usuario
        $this->user = (new User)->find($id);

The property user does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        //se verifica si se ha enviado via POST los datos
        if (Input::hasPost('user')) {
            //Intenta guardar los cambios
            if ($this->user->update(Input::post('user'))) {
                //Mensaje de éxito y retorna al listado
                Flash::valid('Usuario actualizado');
                return Redirect::to();

Are you sure the usage of Redirect::to() targeting Redirect::to() seems to always return null.

            }
            //Si falla se hacen persistentes los datos en el formulario
            $this->user = Input::post('user');
            return;
        }
    }

    public function update_photo(int $id)//validación 'int' con php7

This method seems to be duplicated in your project.

    {
        //Carga los datos del usuario
        $this->user = (new User)->find($id);

The property user does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        //se verifica si se ha enviado via POST los datos
        if (Input::hasPost('user')) {
            //Si falla al intentar actualizar
            if ($this->user->updatePhoto()) {

The method updatePhoto() does not exist on ActiveRecord. Since you implemented __call, consider adding a @method annotation.

                //Mensaje de éxito y retorna al listado
                Flash::valid('Foto de usuario actualizada');
                return Redirect::to();

Are you sure the usage of Redirect::to() targeting Redirect::to() seems to always return null.

            }
            //se hacen persistentes los datos en el formulario
            $this->user = Input::post('user');
            return;
        }
    }
}