Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | class ParagraphTextTest extends FormTestCase { |
||
| 6 | |||
| 7 | /** @test */ |
||
| 8 | public function it_can_be_rendered() |
||
| 9 | { |
||
| 10 | $form = $this->form(); |
||
| 11 | $form->paragraph_text('foo'); |
||
| 12 | $this->assertContains('<textarea name="foo"', $form->render()); |
||
| 13 | } |
||
| 14 | |||
| 15 | /** @test */ |
||
| 16 | public function it_renders_a_default_value() |
||
| 17 | { |
||
| 18 | $form = $this->form(); |
||
| 19 | $form->paragraph_text('foo')->default('bar'); |
||
| 20 | $this->assertContains('<textarea name="foo"', $form->render()); |
||
| 21 | $this->assertContains('bar</textarea>', $form->render()); |
||
| 22 | } |
||
| 23 | |||
| 24 | /** @test */ |
||
| 25 | public function it_renders_model_values() |
||
| 26 | { |
||
| 27 | $form = $this->form(); |
||
| 28 | $form->defaults($this->model(['foo'=>'bar'])); |
||
| 29 | $form->paragraph_text('foo'); |
||
| 30 | $this->assertContains('<textarea name="foo"', $form->render()); |
||
| 31 | $this->assertContains('bar</textarea>', $form->render()); |
||
| 32 | } |
||
| 33 | |||
| 34 | /** @test */ |
||
| 35 | public function it_can_fill_model_values() |
||
| 36 | { |
||
| 37 | $model = $this->model(['foo'=>'']); |
||
| 38 | |||
| 39 | $form = $this->form(); |
||
| 40 | $form->paragraph_text('foo')->default('bar'); |
||
| 41 | $form->fill($model); |
||
| 42 | |||
| 43 | $form->assertEquals($model->foo, 'bar'); |
||
| 44 | } |
||
| 45 | |||
| 46 | /** @test */ |
||
| 47 | public function it_escapes_value() |
||
| 48 | { |
||
| 49 | $form = $this->form(); |
||
| 50 | $form->paragraph_text('foo')->default('bar&'); |
||
| 51 | $this->assertContains('<textarea name="foo"', $form->render()); |
||
| 52 | $this->assertContains('bar&</textarea>', $form->render()); |
||
| 53 | } |
||
| 54 | |||
| 55 | /** @test */ |
||
| 56 | public function it_provides_expected_values() |
||
| 57 | { |
||
| 58 | $form = $this->form(); |
||
| 59 | $form->paragraph_text('foo'); |
||
| 60 | |||
| 61 | $this->assertSame($form->get('foo'), ''); |
||
| 62 | } |
||
| 63 | |||
| 64 | /** @test */ |
||
| 65 | public function it_provides_expected_default_values() |
||
| 66 | { |
||
| 67 | $form = $this->form(); |
||
| 68 | $form->paragraph_text('foo')->default('bar'); |
||
| 69 | |||
| 70 | $this->assertSame($form->get('foo'), 'bar'); |
||
| 71 | } |
||
| 72 | |||
| 73 | /** @test */ |
||
| 74 | public function it_validates_required() |
||
| 75 | { |
||
| 76 | $this->assertValid(function($form) { $form->paragraph_text('foo'); }); |
||
| 77 | |||
| 78 | $this->assertNotValid(function($form) { $form->paragraph_text('foo')->required(); }); |
||
| 79 | } |
||
| 80 | |||
| 81 | } |
||
| 82 |