ExpressionCondition::__construct() - Code Metrics - hellofresh/feature-toggle - Measure and Improve Code Quality continuously with Scrutinizer

ExpressionCondition::__construct() A
last analyzed 2016-07-11 18:12 UTC

↳ Parent: ExpressionCondition

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	9.4285
cc	1
eloc	3
nc	1
nop	2
crap	1

<?php
/**
 * Copyright (c) 2016, HelloFresh GmbH.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

namespace HelloFresh\FeatureToggle;

use Symfony\Component\ExpressionLanguage\ExpressionLanguage;

/**
 * A condition written as a symfony language expression that gets evaluated against the
 * full context, allowing access to several keys of the context in a single condition
 */
class ExpressionCondition implements ConditionInterface
{
    /** @var string */
    protected $expression;

    /** @var ExpressionLanguage */
    protected $language;

    /**
     * @param string $expression The expression to ve evaluated
     * @param ExpressionLanguage $language The instance of the Expression Language
     */
    function __construct($expression, ExpressionLanguage $language)

    {
        $this->expression = $expression;
        $this->language = $language;
    }

    /**
     * @inheritdoc
     */
    public function holdsFor(Context $context)
    {
        return $this->language->evaluate($this->expression, $context->toArray()) === true;
    }
}

1		<?php
2		/**
3		* Copyright (c) 2016, HelloFresh GmbH.
4		* All rights reserved.
5		*
6		* This source code is licensed under the MIT license found in the
7		* LICENSE file in the root directory of this source tree.
8		*/
9
10		namespace HelloFresh\FeatureToggle;
11
12		use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
13
14		/**
15		* A condition written as a symfony language expression that gets evaluated against the
16		* full context, allowing access to several keys of the context in a single condition
17		*/
18		class ExpressionCondition implements ConditionInterface
19		{
20		/** @var string */
21		protected $expression;
22
23		/** @var ExpressionLanguage */
24		protected $language;
25
26		/**
27		* @param string $expression The expression to ve evaluated
28		* @param ExpressionLanguage $language The instance of the Expression Language
29		*/
30	5	function __construct($expression, ExpressionLanguage $language)
		0 ignored issues – show Best Practice introduced 2016-01-27 14:34 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Comprehensibility Best Practice introduced 2016-01-27 15:01 UTC by Report Bug Copy Issue Report It is recommend to declare an explicit visibility for `__construct`. Generally, we recommend to declare visibility for all methods in your source code. This has the advantage of clearly communication to other developers, and also yourself, how this method should be consumed. If you are not sure which visibility to choose, it is a good idea to start with the most restrictive visibility, and then raise visibility as needed, i.e. start with `private`, and only raise it to `protected` if a sub-class needs to have access, or `public` if an external class needs access. Loading history...
31		{
32	5	$this->expression = $expression;
33	5	$this->language = $language;
34	5	}
35
36		/**
37		* @inheritdoc
38		*/
39	5	public function holdsFor(Context $context)
40		{
41	5	return $this->language->evaluate($this->expression, $context->toArray()) === true;
42		}
43		}

hellofresh / feature-toggle

GitHub Access Token became invalid

ExpressionCondition::__construct() A last analyzed 2016-07-11 18:12 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ExpressionCondition::__construct() A
last analyzed 2016-07-11 18:12 UTC