HelloFresh\FeatureToggle\OperatorCondition

Complexity

Total Complexity

5

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	holdsFor()	0	9	2
A	getKey()	0	4	1
A	getOperator()	0	4	1

<?php
/**
 * Copyright (c) 2016, HelloFresh GmbH.
 * All rights reserved.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

namespace HelloFresh\FeatureToggle;

use HelloFresh\FeatureToggle\Operator\OperatorInterface;

/**
 * A condition based on the name of the value from the context and an operator.
 */
class OperatorCondition implements ConditionInterface
{
    /** @var string */
    private $key;

    /** @var OperatorInterface */
    private $operator;

    /**
     * @param string $key Name of the value
     * @param OperatorInterface $operator Operator to run
     */
    public function __construct($key, OperatorInterface $operator)
    {
        $this->key = $key;
        $this->operator = $operator;
    }

    /**
     * {@inheritdoc}
     */
    public function holdsFor(Context $context)
    {
        if (!$context->containsKey($this->key)) {

The expression $context->containsKey($this->key) of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            return false;
        }
        $argument = $context->get($this->key);

        return $this->operator->appliesTo($argument);
    }

    /**
     * @return string
     */
    public function getKey()
    {
        return $this->key;
    }

    /**
     * @return OperatorInterface
     */
    public function getOperator()
    {
        return $this->operator;
    }
}