hellemarck / ramverk1-weather_module

src/Models/GeoApi.php

<?php

namespace Anax\Models;

class GeoApi extends IpValidator
{
    /**
     * model class for finding coordinates matching the ip adress
     * using the geolocation api 'ipstack'
     * child class to IpValidator
     */
    public function findGeoLocation($ipAdress)
    {
        global $di;

        // get the secret api key
        $config = $di->get("configuration")->load("api_keys.php") ?? null;
        $apiKey = $config["config"]["ipStack"]["apiKey"] ?? null;

        // make curl api call with ip address and api key
        $ch1 = curl_init('http://api.ipstack.com/'.$ipAdress.'?access_key='.$apiKey.'');
        curl_setopt($ch1, CURLOPT_RETURNTRANSFER, true);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        $json = curl_exec($ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($ch1);

It seems like $ch1 can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        /**
         * decode the json result
         * for usage in both view and rest-api controller
         */
        $result = json_decode($json, true);

        $data = [
            "city" => $result['city'] ?? "-",
            "country_name" => $result['country_name'] ?? "-",
            "longitude" => $result['longitude'] ?? "-",
            "latitude" => $result['latitude'] ?? "-"
        ];

        return $data;
    }
}