hellemarck / ramverk1-weather_module

src/Controller/WeatherToJSONController.php

<?php

namespace Anax\Controller;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;
use Anax\Models\WeatherApi;

// use Anax\Models\IpValidator;
// use Anax\Models\GeoApi;

/**
 * Controllerclass for the JSON-return of weather forecast
 */
class WeatherToJSONController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;

    /**
     * based on ip address or coordinates for a location
     * returning the forecast for 7 days
     */
    public function searchAction()
    {
        $search = $_GET["location"];
        $type = $this->di->get("request")->getGet("type");

        $weatherObj = $this->di->get("weatherapi");
        $geoObj = $this->di->get("geoapi");

        if (strpos($search, ",") == true) {

It seems like you are loosely comparing strpos($search, ',') of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

            $split = explode(",", $search);
            if (!ctype_alpha($split[0]) && !ctype_alpha($split[1])) {
                $weatherObj->setCoordinates($split[0], $split[1]);
                $weather = ($type == "coming") ? ($weatherObj->comingWeather($split[0], $split[1])) : $weatherObj->pastWeather($split[0], $split[1]);
            } else {
                $weather = "Felaktig söksträng, försök igen.";
            }
        } else {
            $res = $geoObj->findGeoLocation($search);
            if ($res["longitude"] !== "-") {
                $weatherObj->setCoordinates($res["latitude"], $res["longitude"]);
                $weather = ($type == "coming") ? ($weatherObj->comingWeather($res["latitude"], $res["longitude"])) : $weatherObj->pastWeather($res["latitude"], $res["longitude"]);
            } else {
                $weather = "Felaktig söksträng, försök igen.";
            }
        }

        $data = [
            "weather" => $weather ?? null,
            "coordinates" => $weatherObj->getCoordinates() ?? null,
            "location" => $weatherObj->getLocation() ?? null
        ];


        json_encode($data, true);

true of type true is incompatible with the type integer expected by parameter $options of json_encode().

        return [[ $data ]];
    }
}