GetSlotsTest::testFailures() - Code Metrics - Inspection of "GetSlots: check if returned slots match requested..." - helecz/php-partner-sync-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e0d167...0f42e0 )

by Josef

created 2016-12-08 15:50 UTC

GetSlotsTest::testFailures() B

↳ Parent: GetSlotsTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	105
Code Lines	74

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	74
nc	1
nop	0
dl	0
loc	105
rs	8.2857
c	0
b	0
f	0

How to fix Long Method

<?php

namespace HelePartnerSyncApi\Method;

use DateTime;

class GetSlotsTest extends MethodTestCase
{

	public function testSuccess()
	{
		$today = new DateTime('today');
		$request = $this->getRequestMock(array(
			'date' => $today->format(DateTime::W3C),
			'parameters' => array(),
		));

		$startDateTime = new DateTime('+1 hour');
		$endDateTime = new DateTime('+2 hours');
		$closure = function () use ($startDateTime, $endDateTime) {
			return array(
				array(
					'startDateTime' => $startDateTime,
					'endDateTime' => $endDateTime,
					'capacity' => 1,
				),
			);
		};
		$method = new GetSlots($closure);
		$response = $method->call($request);

		$this->assertSame(array(
			array(
				'startDateTime' => $startDateTime->format(DateTime::W3C),
				'endDateTime' => $endDateTime->format(DateTime::W3C),
				'capacity' => 1,
			),
		), $response);
	}

	public function testFailures()
	{
		$now = new DateTime();
		$before = new DateTime('-1 hour');
		$tomorrow = new DateTime('tomorrow');
		$nowString = $now->format(DateTime::W3C);

		$this->checkException(
			array(),
			array(),
			'Missing keys (date, parameters)'
		);
		$this->checkException(
			array(
				'date' => 'now',
				'parameters' => array(),
			),
			array(
				array(),
			),
			'W3C datetime expected, string (now) given.'
		);
		$this->checkException(
			array(
				'date' => $nowString,
				'parameters' => array(),
			),
			array(
				array(
					'startDateTime' => $now,
				)
			),
			'Missing keys (endDateTime, capacity)'
		);
		$this->checkException(
			array(
				'date' => $nowString,
				'parameters' => array(),
			),
			array(
				array(
					'startDateTime' => $now,
					'endDateTime' => $now,
					'capacity' => 'string',
				)
			),
			'Int expected, string (string) given.'
		);
		$this->checkException(
			array(
				'date' => $nowString,
				'parameters' => array(),
			),
			array(
				array(
					'startDateTime' => 'not-a-datetime',
					'endDateTime' => $now,
					'capacity' => 1,
				)
			),
			'DateTime expected, string (not-a-datetime) given.'
		);
		$this->checkException(
			array(
				'date' => $nowString,
				'parameters' => array(),
			),
			array(
				array(
					'startDateTime' => $before,
					'endDateTime' => $now,
					'capacity' => -1,
				)
			),
			'Slot capacity (-1) must be non-negative (slot #1)'
		);
		$this->checkException(
			array(
				'date' => $nowString,
				'parameters' => array(),
			),
			array(
				array(
					'startDateTime' => $now,
					'endDateTime' => $before,
					'capacity' => 1,
				)
			),
			sprintf('Slot startDateTime (%s) must be before endDateTime (%s) (slot #1)', $nowString, $before->format(DateTime::W3C))
		);
		$this->checkException(
			array(
				'date' => $tomorrow->format(DateTime::W3C),
				'parameters' => array(),
			),
			array(
				array(
					'startDateTime' => $before,
					'endDateTime' => $now,
					'capacity' => 1,
				)
			),
			sprintf('Slot startDateTime (%s) does not match requested day (%s) (slot #1)', $now->format('Y-m-d'), $tomorrow->format('Y-m-d'))
		);
	}

	/**
	 * @param array $requestData
	 * @param array $responseData
	 * @param string $error
	 */
	private function checkException(array $requestData, array $responseData, $error)

	{
		try {
			$request = $this->getRequestMock($requestData);
			$method = new GetSlots(function () use ($responseData) {
				return $responseData;
			});
			$method->call($request);
			$this->fail(sprintf('Expected exception with "%s" to be thrown', $error));

		} catch (MethodException $e) {
			$this->assertContains($error, $e->getMessage());
		}
	}

}


1		<?php
2
3		namespace HelePartnerSyncApi\Method;
4
5		use DateTime;
6
7		class GetSlotsTest extends MethodTestCase
8		{
9
10		public function testSuccess()
11		{
12		$today = new DateTime('today');
13		$request = $this->getRequestMock(array(
14		'date' => $today->format(DateTime::W3C),
15		'parameters' => array(),
16		));
17
18		$startDateTime = new DateTime('+1 hour');
19		$endDateTime = new DateTime('+2 hours');
20		$closure = function () use ($startDateTime, $endDateTime) {
21		return array(
22		array(
23		'startDateTime' => $startDateTime,
24		'endDateTime' => $endDateTime,
25		'capacity' => 1,
26		),
27		);
28		};
29		$method = new GetSlots($closure);
30		$response = $method->call($request);
31
32		$this->assertSame(array(
33		array(
34		'startDateTime' => $startDateTime->format(DateTime::W3C),
35		'endDateTime' => $endDateTime->format(DateTime::W3C),
36		'capacity' => 1,
37		),
38		), $response);
39		}
40
41		public function testFailures()
42		{
43		$now = new DateTime();
44		$before = new DateTime('-1 hour');
45		$tomorrow = new DateTime('tomorrow');
46		$nowString = $now->format(DateTime::W3C);
47
48		$this->checkException(
49		array(),
50		array(),
51		'Missing keys (date, parameters)'
52		);
53		$this->checkException(
54		array(
55		'date' => 'now',
56		'parameters' => array(),
57		),
58		array(
59		array(),
60		),
61		'W3C datetime expected, string (now) given.'
62		);
63		$this->checkException(
64		array(
65		'date' => $nowString,
66		'parameters' => array(),
67		),
68		array(
69		array(
70		'startDateTime' => $now,
71		)
72		),
73		'Missing keys (endDateTime, capacity)'
74		);
75		$this->checkException(
76		array(
77		'date' => $nowString,
78		'parameters' => array(),
79		),
80		array(
81		array(
82		'startDateTime' => $now,
83		'endDateTime' => $now,
84		'capacity' => 'string',
85		)
86		),
87		'Int expected, string (string) given.'
88		);
89		$this->checkException(
90		array(
91		'date' => $nowString,
92		'parameters' => array(),
93		),
94		array(
95		array(
96		'startDateTime' => 'not-a-datetime',
97		'endDateTime' => $now,
98		'capacity' => 1,
99		)
100		),
101		'DateTime expected, string (not-a-datetime) given.'
102		);
103		$this->checkException(
104		array(
105		'date' => $nowString,
106		'parameters' => array(),
107		),
108		array(
109		array(
110		'startDateTime' => $before,
111		'endDateTime' => $now,
112		'capacity' => -1,
113		)
114		),
115		'Slot capacity (-1) must be non-negative (slot #1)'
116		);
117		$this->checkException(
118		array(
119		'date' => $nowString,
120		'parameters' => array(),
121		),
122		array(
123		array(
124		'startDateTime' => $now,
125		'endDateTime' => $before,
126		'capacity' => 1,
127		)
128		),
129		sprintf('Slot startDateTime (%s) must be before endDateTime (%s) (slot #1)', $nowString, $before->format(DateTime::W3C))
130		);
131		$this->checkException(
132		array(
133		'date' => $tomorrow->format(DateTime::W3C),
134		'parameters' => array(),
135		),
136		array(
137		array(
138		'startDateTime' => $before,
139		'endDateTime' => $now,
140		'capacity' => 1,
141		)
142		),
143		sprintf('Slot startDateTime (%s) does not match requested day (%s) (slot #1)', $now->format('Y-m-d'), $tomorrow->format('Y-m-d'))
144		);
145		}
146
147		/**
148		* @param array $requestData
149		* @param array $responseData
150		* @param string $error
151		*/
152	View Code Duplication	private function checkException(array $requestData, array $responseData, $error)
		0 ignored issues – show Duplication introduced 2016-10-18 14:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
153		{
154		try {
155		$request = $this->getRequestMock($requestData);
156		$method = new GetSlots(function () use ($responseData) {
157		return $responseData;
158		});
159		$method->call($request);
160		$this->fail(sprintf('Expected exception with "%s" to be thrown', $error));
161
162		} catch (MethodException $e) {
163		$this->assertContains($error, $e->getMessage());
164		}
165		}
166
167		}
168

helecz / php-partner-sync-api

Push — master ( e0d167...0f42e0 )

GetSlotsTest::testFailures() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like