DateFactory::itemFromDomElement() - Code Metrics - Inspection of "Refactor factories" - heiglandreas/holidayChecker - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — main (#112)

by Andreas

created 2022-10-19 18:03 UTC

DateFactory::itemFromDomElement() B

↳ Parent: DateFactory

Complexity

Conditions	8
Paths	3

Size

Total Lines	24
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	16
c	1
b	0
f	0
dl	0
loc	24
rs	8.4444
cc	8
nc	3
nop	1

<?php

/**
 * Copyright Andreas Heigl <[email protected]>
 *
 * Licenses under the MIT-license. For details see the included file LICENSE.md
 */

declare(strict_types=1);

namespace Org_Heigl\Holidaychecker\Factory;

use DOMElement;
use Org_Heigl\Holidaychecker\CalendarDayFactory;
use Org_Heigl\Holidaychecker\HolidayIteratorItemInterface;
use Org_Heigl\Holidaychecker\IteratorItem\Date;
use function explode;

class DateFactory implements ItemFromDomElementCreator
{
	public function itemFromDomElement(DOMElement $element): ?HolidayIteratorItemInterface
	{
		if ($element->nodeName !== 'date') {
			return null;
		}

		$day = CalendarDayFactory::createCalendarDay(
			(int) $element->getAttribute('day'),
			(int) $element->getAttribute('month'),
			($element->hasAttribute('calendar') ? $element->getAttribute('calendar') : 'gregorian')
		);

		if ($element->hasAttribute('year')) {
			$day->setYear((int) $element->getAttribute('year'));
		}

		return new Date(
			$element->textContent,
            $element->getAttribute('free') === "true",
			$day,
			$element->hasAttribute('forwardto') ? $element->getAttribute('forwardto') : '',
			$element->hasAttribute('forwardwhen') ? explode(' ', $element->getAttribute('forwardwhen')) : [],
			$element->hasAttribute('rewindto') ? $element->getAttribute('rewindto') : '',
			$element->hasAttribute('rewindwhen') ? explode(' ', $element->getAttribute('rewindwhen')) : [],
		);
	}
}


1			<?php
2
3			/**
4			* Copyright Andreas Heigl <[email protected]>
5			*
6			* Licenses under the MIT-license. For details see the included file LICENSE.md
7			*/
8
9			declare(strict_types=1);
10
11			namespace Org_Heigl\Holidaychecker\Factory;
12
13			use DOMElement;
14			use Org_Heigl\Holidaychecker\CalendarDayFactory;
15			use Org_Heigl\Holidaychecker\HolidayIteratorItemInterface;
16			use Org_Heigl\Holidaychecker\IteratorItem\Date;
17			use function explode;
18
19			class DateFactory implements ItemFromDomElementCreator
20			{
21			public function itemFromDomElement(DOMElement $element): ?HolidayIteratorItemInterface
22			{
23			if ($element->nodeName !== 'date') {
24			return null;
25			}
26
27			$day = CalendarDayFactory::createCalendarDay(
28			(int) $element->getAttribute('day'),
29			(int) $element->getAttribute('month'),
30			($element->hasAttribute('calendar') ? $element->getAttribute('calendar') : 'gregorian')
31			);
32
33			if ($element->hasAttribute('year')) {
34			$day->setYear((int) $element->getAttribute('year'));
35			}
36
37			return new Date(
38			$element->textContent,
39			$element->getAttribute('free') === "true",
40			$day,
41			$element->hasAttribute('forwardto') ? $element->getAttribute('forwardto') : '',
42			$element->hasAttribute('forwardwhen') ? explode(' ', $element->getAttribute('forwardwhen')) : [],
43			$element->hasAttribute('rewindto') ? $element->getAttribute('rewindto') : '',
44			$element->hasAttribute('rewindwhen') ? explode(' ', $element->getAttribute('rewindwhen')) : [],
45			);
46			}
47			}
48

heiglandreas / holidayChecker

Pull Request — main (#112)

DateFactory::itemFromDomElement() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like