Issues in Module.php - Fixed Issues - Inspection of "update to zf3" - heiglandreas/OrgHeiglMailproxy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Andreas

created 2017-02-21 07:02 UTC

Module.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Copyright (c) 2011-2012 Andreas Heigl<[email protected]>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @category  MailProxy
 * @package   OrgHeiglMailproxy
 * @author    Andreas Heigl<[email protected]>
 * @copyright 2011-2012 Andreas Heigl
 * @license   http://www.opesource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     06.03.2012
 * @link      http://github.com/heiglandreas/mailproxyModule
 */

namespace OrgHeiglMailproxy;

use Zend\ModuleManager\ModuleManager,
    Zend\EventManager\StaticEventManager,
    Zend\Mvc\ModuleRouteListener;
    

/**
 * The Module-Provider
 *
 * @category  MailProxy
 * @package   OrgHeiglMailproxy
 * @author    Andreas Heigl<[email protected]>
 * @copyright 2011-2012 Andreas Heigl
 * @license   http://www.opesource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     06.03.2012
 * @link      http://github.com/heiglandreas/mailproxyModule
 */
class Module
{
    public function init(ModuleManager $moduleManager)
    {
        $events = StaticEventManager::getInstance();
        $events->attach('bootstrap', 'bootstrap', array($this, 'initializeView'), 100);
    }
    
    public function initializeView($e)
    {
        $app          = $e->getParam('application');
        $basePath     = $app->getRequest()->getBasePath();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $locator      = $app->getLocator();
        $renderer     = $locator->get('Zend\View\HelperLoader');
        $renderer->registerPlugin('mailto', 'OrgHeiglMailproxy\View\Helper\Mailto');
    }
    

    public function onBootstrap($e)
    {
    	$e->getApplication()->getServiceManager()->get('translator');
    	$eventManager        = $e->getApplication()->getEventManager();
    	$moduleRouteListener = new ModuleRouteListener();
    	$moduleRouteListener->attach($eventManager);
    }
    
    public function getConfig()
    {
    	return include __DIR__ . '/config/module.config.php';
    }
    
    public function getAutoloaderConfig()
    {
    	return array(
    			'Zend\Loader\StandardAutoloader' => array(
    					'namespaces' => array(
    							__NAMESPACE__ => __DIR__ . '/src/' . __NAMESPACE__,
    					),
    			),
    	);
    }
}


1			<?php
2			/**
3			* Copyright (c) 2011-2012 Andreas Heigl<[email protected]>
4			*
5			* Permission is hereby granted, free of charge, to any person obtaining a copy
6			* of this software and associated documentation files (the "Software"), to deal
7			* in the Software without restriction, including without limitation the rights
8			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9			* copies of the Software, and to permit persons to whom the Software is
10			* furnished to do so, subject to the following conditions:
11			*
12			* The above copyright notice and this permission notice shall be included in
13			* all copies or substantial portions of the Software.
14			*
15			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
21			* THE SOFTWARE.
22			*
23			* @category MailProxy
24			* @package OrgHeiglMailproxy
25			* @author Andreas Heigl<[email protected]>
26			* @copyright 2011-2012 Andreas Heigl
27			* @license http://www.opesource.org/licenses/mit-license.php MIT-License
28			* @version 0.0
29			* @since 06.03.2012
30			* @link http://github.com/heiglandreas/mailproxyModule
31			*/
32
33			namespace OrgHeiglMailproxy;
34
35			use Zend\ModuleManager\ModuleManager,
36			Zend\EventManager\StaticEventManager,
37			Zend\Mvc\ModuleRouteListener;
38
39
40			/**
41			* The Module-Provider
42			*
43			* @category MailProxy
44			* @package OrgHeiglMailproxy
45			* @author Andreas Heigl<[email protected]>
46			* @copyright 2011-2012 Andreas Heigl
47			* @license http://www.opesource.org/licenses/mit-license.php MIT-License
48			* @version 0.0
49			* @since 06.03.2012
50			* @link http://github.com/heiglandreas/mailproxyModule
51			*/
52			class Module
53			{
54			public function init(ModuleManager $moduleManager)
55			{
56			$events = StaticEventManager::getInstance();
57			$events->attach('bootstrap', 'bootstrap', array($this, 'initializeView'), 100);
58			}
59
60			public function initializeView($e)
61			{
62			$app = $e->getParam('application');
63			$basePath = $app->getRequest()->getBasePath();
			0 ignored issues – show Unused Code introduced 2017-02-21 07:01 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$basePath` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
64			$locator = $app->getLocator();
65			$renderer = $locator->get('Zend\View\HelperLoader');
66			$renderer->registerPlugin('mailto', 'OrgHeiglMailproxy\View\Helper\Mailto');
67			}
68
69
70			public function onBootstrap($e)
71			{
72			$e->getApplication()->getServiceManager()->get('translator');
73			$eventManager = $e->getApplication()->getEventManager();
74			$moduleRouteListener = new ModuleRouteListener();
75			$moduleRouteListener->attach($eventManager);
76			}
77
78			public function getConfig()
79			{
80			return include __DIR__ . '/config/module.config.php';
81			}
82
83			public function getAutoloaderConfig()
84			{
85			return array(
86			'Zend\Loader\StandardAutoloader' => array(
87			'namespaces' => array(
88			__NAMESPACE__ => __DIR__ . '/src/' . __NAMESPACE__,
89			),
90			),
91			);
92			}
93			}
94

heiglandreas / OrgHeiglMailproxy

Pull Request — master (#2)

Module.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like