Geolocation - Code Metrics - Inspection of "Adapts to ZF3" - heiglandreas/OrgHeiglGeolocation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Andreas

created 2017-02-23 17:14 UTC

Geolocation A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	1
cbo	5
dl	0
loc	36
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	4	1
B	render()	0	26	2

<?php
/**
 * Copyright Andreas Heigl <[email protected]>
 * 
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 * 
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIBILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @author    Andreas Heigl<[email protected]>
 * @copyright Andreas Heigl
 * @license   http://www.opesource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     25.07.14
 * @link      https://github.com/heiglandreas/OrgHeiglGeolocation
 */

namespace Org_Heigl\Geolocation\Form\View\Helper;

use Zend\Form\ElementInterface;
use Zend\Form\View\Helper\FormText;
use Zend\View\Renderer\PhpRenderer;

class Geolocation extends FormText
{
    protected $script = 'org-heigl-geolocation/form-element/geolocation';

    public function render(ElementInterface $element)
    {
        $renderer = $this->getView();

        $basePath = $renderer->basePath();

        if ($renderer instanceof PhpRenderer) {

            $renderer->headScript()->appendFile($basePath . '/jquery/jquery.min.js');
            $renderer->headScript()->appendFile($basePath . '/orgheiglgeolocation/lib/leaflet/leaflet.js');
            $renderer->headScript()->appendFile($basePath . '/orgheiglgeolocation/js/orgHeiglGeolocation.js');
            $renderer->headScript()->appendScript('$(\'.orgheiglgeolocation\').orgHeiglGeolocation()');
            $renderer->headLink()->appendStylesheet($basePath . '/orgheiglgeolocation/lib/leaflet/leaflet.css');
        }

        $class = $element->getAttribute('class');
        $class .= " orgheiglgeolocation";

        $element->setAttribute('class', $class);


        return $this->getView()->render($this->script, array(
            'element' => $element,
            'renderedElement' => parent::render($element),
        ));
    }

    public function __invoke(ElementInterface $element = null)
    {
        return $this->render($element);
function notNullable(stdClass $x) { }

// Unsafe
function withoutCheck(stdClass $x = null) {
    notNullable($x);
}

// Safe - Alternative 1: Adding Additional Type-Check
function withCheck(stdClass $x = null) {
    if ($x instanceof stdClass) {
        notNullable($x);
    }
}

// Safe - Alternative 2: Changing Parameter
function withNonNullableParam(stdClass $x) {
    notNullable($x);
}
    }
}



1			<?php
2			/**
3			* Copyright Andreas Heigl <[email protected]>
4			*
5			* Permission is hereby granted, free of charge, to any person obtaining a copy
6			* of this software and associated documentation files (the "Software"), to deal
7			* in the Software without restriction, including without limitation the rights
8			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9			* copies of the Software, and to permit persons to whom the Software is
10			* furnished to do so, subject to the following conditions:
11			*
12			* The above copyright notice and this permission notice shall be included in
13			* all copies or substantial portions of the Software.
14			*
15			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19			* LIBILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
21			* THE SOFTWARE.
22			*
23			* @author Andreas Heigl<[email protected]>
24			* @copyright Andreas Heigl
25			* @license http://www.opesource.org/licenses/mit-license.php MIT-License
26			* @version 0.0
27			* @since 25.07.14
28			* @link https://github.com/heiglandreas/OrgHeiglGeolocation
29			*/
30
31			namespace Org_Heigl\Geolocation\Form\View\Helper;
32
33			use Zend\Form\ElementInterface;
34			use Zend\Form\View\Helper\FormText;
35			use Zend\View\Renderer\PhpRenderer;
36
37			class Geolocation extends FormText
38			{
39			protected $script = 'org-heigl-geolocation/form-element/geolocation';
40
41			public function render(ElementInterface $element)
42			{
43			$renderer = $this->getView();
44
45			$basePath = $renderer->basePath();
46
47			if ($renderer instanceof PhpRenderer) {
48
49			$renderer->headScript()->appendFile($basePath . '/jquery/jquery.min.js');
50			$renderer->headScript()->appendFile($basePath . '/orgheiglgeolocation/lib/leaflet/leaflet.js');
51			$renderer->headScript()->appendFile($basePath . '/orgheiglgeolocation/js/orgHeiglGeolocation.js');
52			$renderer->headScript()->appendScript('$(\'.orgheiglgeolocation\').orgHeiglGeolocation()');
53			$renderer->headLink()->appendStylesheet($basePath . '/orgheiglgeolocation/lib/leaflet/leaflet.css');
54			}
55
56			$class = $element->getAttribute('class');
57			$class .= " orgheiglgeolocation";
58
59			$element->setAttribute('class', $class);
60
61
62			return $this->getView()->render($this->script, array(
63			'element' => $element,
64			'renderedElement' => parent::render($element),
65			));
66			}
67
68			public function __invoke(ElementInterface $element = null)
69			{
70			return $this->render($element);
			0 ignored issues – show Bug introduced 2017-02-23 07:51 UTC by Report Bug Copy Issue Report It seems like `$element` defined by parameter `$element` on line `68` can be `null`; however, `Org_Heigl\Geolocation\Fo...r\Geolocation::render()` does not accept `null`, maybe add an additional type check? It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null. We recommend to add an additional type check (or disallow null for the parameter): function notNullable(stdClass $x) { } // Unsafe function withoutCheck(stdClass $x = null) { notNullable($x); } // Safe - Alternative 1: Adding Additional Type-Check function withCheck(stdClass $x = null) { if ($x instanceof stdClass) { notNullable($x); } } // Safe - Alternative 2: Changing Parameter function withNonNullableParam(stdClass $x) { notNullable($x); } Loading history...
71			}
72			}
73
74

heiglandreas / OrgHeiglGeolocation

Pull Request — master (#14)

Geolocation A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like