JUnitMerger - Code Metrics - Inspection of "Add compare" - heiglandreas/JUnitDiff - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Andreas

created 2016-06-17 20:57 UTC

JUnitMerger A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
wmc	4
c	2
b	0
f	2
lcom	1
cbo	1
dl	0
loc	30
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	merge()	0	13	3

<?php

/**
 * Copyright (c) Andreas Heigl<[email protected]>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @author    Andreas Heigl<[email protected]>
 * @copyright Andreas Heigl
 * @license   http://www.opensource.org/licenses/mit-license.php MIT-License
 * @since     16.06.2016
 * @link      http://github.com/heiglandreas/org.heigl.junitdiff
 */

namespace Org_Heigl\JUnitDiff;

class JUnitMerger
{
    /** @var  MergeResult */
    protected $mergeResult;

    public function __construct(MergeResult $mergeResult)
    {
        $this->mergeResult = $mergeResult;
    }

    /**
     * @param array $array1
     * @param array $array26
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return array
     */
    public function merge(array $array1, array $array2)
    {
        $merged = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        foreach ($array1 as $key => $value) {
            $this->mergeResult->addBase($key, $value);
        }

        foreach($array2 as $key => $value) {
            $this->mergeResult->addCurrent($key, $value);
        }

        return $this->mergeResult;
    }
}

1			<?php
2
3			/**
4			* Copyright (c) Andreas Heigl<[email protected]>
5			*
6			* Permission is hereby granted, free of charge, to any person obtaining a copy
7			* of this software and associated documentation files (the "Software"), to deal
8			* in the Software without restriction, including without limitation the rights
9			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			* copies of the Software, and to permit persons to whom the Software is
11			* furnished to do so, subject to the following conditions:
12			*
13			* The above copyright notice and this permission notice shall be included in
14			* all copies or substantial portions of the Software.
15			*
16			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
22			* THE SOFTWARE.
23			*
24			* @author Andreas Heigl<[email protected]>
25			* @copyright Andreas Heigl
26			* @license http://www.opensource.org/licenses/mit-license.php MIT-License
27			* @since 16.06.2016
28			* @link http://github.com/heiglandreas/org.heigl.junitdiff
29			*/
30
31			namespace Org_Heigl\JUnitDiff;
32
33			class JUnitMerger
34			{
35			/** @var MergeResult */
36			protected $mergeResult;
37
38			public function __construct(MergeResult $mergeResult)
39			{
40			$this->mergeResult = $mergeResult;
41			}
42
43			/**
44			* @param array $array1
45			* @param array $array26
			0 ignored issues – show Documentation introduced 2016-06-17 12:50 UTC by Report Bug Copy Issue Report There is no parameter named `$array26`. Did you maybe mean `$array2`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
46			*
47			* @return array
48			*/
49			public function merge(array $array1, array $array2)
50			{
51			$merged = [];
			0 ignored issues – show Unused Code introduced 2016-06-17 12:50 UTC by Report Bug Copy Issue Report `$merged` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
52			foreach ($array1 as $key => $value) {
53			$this->mergeResult->addBase($key, $value);
54			}
55
56			foreach($array2 as $key => $value) {
57			$this->mergeResult->addCurrent($key, $value);
58			}
59
60			return $this->mergeResult;
61			}
62			}

heiglandreas / JUnitDiff

Pull Request — master (#13)

JUnitMerger A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like