Summary::write() - Code Metrics - Inspection of "Merge branch 'ChDeinert-feature/output-summary'" - heiglandreas/JUnitDiff - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c66919...af43e1 )

by Andreas

created 2017-01-23 07:11 UTC

Summary::write() A

↳ Parent: Summary

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	9
rs	9.6666
c	1
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php

/**
 * Copyright (c) Andreas Heigl<[email protected]>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @author    Andreas Heigl<[email protected]>
 * @copyright 2016-2016 Andreas Heigl
 * @license   http://www.opensource.org/licenses/mit-license.php MIT-License
 * @since     16.06.2016
 * @link      http://github.com/heiglandreas/org.heigl.junitdiff
 */

namespace Org_Heigl\JUnitDiff\Writer;

use Org_Heigl\JUnitDiff\MergeResult;
use Symfony\Component\Console\Style\StyleInterface;

class Summary implements WriterInterface
{
    protected $style;

    protected $file1;

    protected $file2;

    public function __construct(StyleInterface $style, $file1, $file2)
    {
        $this->style = $style;
        $this->file1 = $file1;
        $this->file2 = $file2;
    }

    public function write(MergeResult $mergeResult)
    {
        $this->style->writeQuiet(sprintf(
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'Added:<bg=green;fg=black> %s </>, Removed:<bg=red;fg=yellow> %s </>, Changed:<bg=blue;fg=yellow> %s </>',
            $mergeResult->countNew(),
            $mergeResult->countRemoved(),
            $mergeResult->countChanged()
        ));
    }
}


1			<?php
2
3			/**
4			* Copyright (c) Andreas Heigl<[email protected]>
5			*
6			* Permission is hereby granted, free of charge, to any person obtaining a copy
7			* of this software and associated documentation files (the "Software"), to deal
8			* in the Software without restriction, including without limitation the rights
9			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10			* copies of the Software, and to permit persons to whom the Software is
11			* furnished to do so, subject to the following conditions:
12			*
13			* The above copyright notice and this permission notice shall be included in
14			* all copies or substantial portions of the Software.
15			*
16			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
19			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
22			* THE SOFTWARE.
23			*
24			* @author Andreas Heigl<[email protected]>
25			* @copyright 2016-2016 Andreas Heigl
26			* @license http://www.opensource.org/licenses/mit-license.php MIT-License
27			* @since 16.06.2016
28			* @link http://github.com/heiglandreas/org.heigl.junitdiff
29			*/
30
31			namespace Org_Heigl\JUnitDiff\Writer;
32
33			use Org_Heigl\JUnitDiff\MergeResult;
34			use Symfony\Component\Console\Style\StyleInterface;
35
36			class Summary implements WriterInterface
37			{
38			protected $style;
39
40			protected $file1;
41
42			protected $file2;
43
44			public function __construct(StyleInterface $style, $file1, $file2)
45			{
46			$this->style = $style;
47			$this->file1 = $file1;
48			$this->file2 = $file2;
49			}
50
51			public function write(MergeResult $mergeResult)
52			{
53			$this->style->writeQuiet(sprintf(
			0 ignored issues – show Bug introduced 2017-01-23 00:09 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Style\StyleInterface` as the method `writeQuiet()` does only exist in the following implementations of said interface: `Org_Heigl\JUnitDiff\Style\DiffStyle`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
54			'Added:<bg=green;fg=black> %s </>, Removed:<bg=red;fg=yellow> %s </>, Changed:<bg=blue;fg=yellow> %s </>',
55			$mergeResult->countNew(),
56			$mergeResult->countRemoved(),
57			$mergeResult->countChanged()
58			));
59			}
60			}
61

heiglandreas / JUnitDiff

Push — master ( c66919...af43e1 )

Summary::write() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like