Issues in UserWrapperFactory.php (master) - Issues in master - heiglandreas/HybridAuth - Measure and Improve Code Quality continuously with Scrutinizer

Issues (13)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/UserWrapperFactory.php (2 issues)

Labels

Unused Code 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Copyright (c)2013-2013 heiglandreas
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIBILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @category  HybridAuth
 * @author    Andreas Heigl<[email protected]>
 * @copyright ©2012-2013 Andreas Heigl
 * @license   http://www.opesource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     11.01.13
 * @link      https://github.com/heiglandreas/HybridAuth
 */

namespace OrgHeiglHybridAuth;

use SocialConnect\Common\Entity\User;

/**
 * This class works as factory to get an Object implementing the UserInterface
 *
 * @category  HybridAuth
 * @author    Andreas Heigl<[email protected]>
 * @copyright ©2012-2013 Andreas Heigl
 * @license   http://www.opesource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     11.01.13
 * @link      https://github.com/heiglandreas/HybridAuth
 */
class UserWrapperFactory
{
   /**
    * Create the user-Proxy according to the given User-Object
    *
    * @return UserInterface
    * @throws \UnexpectedValueException
    */
    public function factory($userObject)
    {
        switch (get_class($userObject))
        {
            case User::class:
                return new SocialAuthUserWrapper($userObject);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'Hybridauth\\Entity\\Profile':
            case 'Hybridauth\\Entity\\Twitter\\Profile':
                $userProxy = new HybridAuthUserWrapper();
                $userProxy->setUser($userObject);
                return $userProxy;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                return new DummyUserWrapper();
        }

        throw new \UnexpectedValueException(sprintf(
            'The given Object could not be found. Found "%s" instead',
            get_Class($userObject)
        ));
    }
}


1			<?php
2			/**
3			* Copyright (c)2013-2013 heiglandreas
4			*
5			* Permission is hereby granted, free of charge, to any person obtaining a copy
6			* of this software and associated documentation files (the "Software"), to deal
7			* in the Software without restriction, including without limitation the rights
8			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9			* copies of the Software, and to permit persons to whom the Software is
10			* furnished to do so, subject to the following conditions:
11			*
12			* The above copyright notice and this permission notice shall be included in
13			* all copies or substantial portions of the Software.
14			*
15			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19			* LIBILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
21			* THE SOFTWARE.
22			*
23			* @category HybridAuth
24			* @author Andreas Heigl<[email protected]>
25			* @copyright ©2012-2013 Andreas Heigl
26			* @license http://www.opesource.org/licenses/mit-license.php MIT-License
27			* @version 0.0
28			* @since 11.01.13
29			* @link https://github.com/heiglandreas/HybridAuth
30			*/
31
32			namespace OrgHeiglHybridAuth;
33
34			use SocialConnect\Common\Entity\User;
35
36			/**
37			* This class works as factory to get an Object implementing the UserInterface
38			*
39			* @category HybridAuth
40			* @author Andreas Heigl<[email protected]>
41			* @copyright ©2012-2013 Andreas Heigl
42			* @license http://www.opesource.org/licenses/mit-license.php MIT-License
43			* @version 0.0
44			* @since 11.01.13
45			* @link https://github.com/heiglandreas/HybridAuth
46			*/
47			class UserWrapperFactory
48			{
49			/**
50			* Create the user-Proxy according to the given User-Object
51			*
52			* @return UserInterface
53			* @throws \UnexpectedValueException
54			*/
55			public function factory($userObject)
56			{
57			switch (get_class($userObject))
58			{
59			case User::class:
60			return new SocialAuthUserWrapper($userObject);
61			break;
			0 ignored issues – show Unused Code introduced 2017-02-14 15:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
62			case 'Hybridauth\\Entity\\Profile':
63			case 'Hybridauth\\Entity\\Twitter\\Profile':
64			$userProxy = new HybridAuthUserWrapper();
65			$userProxy->setUser($userObject);
66			return $userProxy;
67			break;
			0 ignored issues – show Unused Code introduced 2017-02-14 15:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
68			default:
69			return new DummyUserWrapper();
70			}
71
72			throw new \UnexpectedValueException(sprintf(
73			'The given Object could not be found. Found "%s" instead',
74			get_Class($userObject)
75			));
76			}
77			}
78

heiglandreas / HybridAuth

Issues (13)

Security Analysis not enabled

src/UserWrapperFactory.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like