Issues in SocialAuthUserWrapper.php - New Issues - Inspection of "move to social auth" - heiglandreas/HybridAuth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#33)

by Andreas

created 2017-02-15 06:20 UTC

src/SocialAuthUserWrapper.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Copyright (c)2013-2013 heiglandreas
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIBILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * @category  HybridAuth
 * @author    Andreas Heigl<[email protected]>
 * @copyright ©2012-2013 Andreas Heigl
 * @license   http://www.opesource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     11.01.13
 * @link      https://github.com/heiglandreas/HybridAuth
 */

namespace OrgHeiglHybridAuth;

use Hybridauth\Entity\Profile;
use OrgHeiglHybridAuth\UserInterface;
use SocialConnect\Common\Entity\User;

/**
 * This class works as proxy to the HybridAuth-User-Object
 *
 * @category  HybridAuth
 * @author    Andreas Heigl<[email protected]>
 * @copyright ©2012-2013 Andreas Heigl
 * @license   http://www.opesource.org/licenses/mit-license.php MIT-License
 * @version   0.0
 * @since     11.01.13
 * @link      https://github.com/heiglandreas/HybridAuth
 */
class SocialAuthUserWrapper implements UserInterface
{
    /**
     * @var \SocialConnect\Common\Entity\User
     */
    private $user;

    public function __construct(User $user)
    {
        $this->user = $user;
    }

    /**
     * Get the ID of the user
     *
     * @return string
     */
    public function getUID()
    {
        return $this->user->id;
    }

    /**
     * Get the name of the user
     *
     * @return string
     */
    public function getName()
    {
        return $this->user->username;
    }

    /**
     * Get the eMail-Address of the user
     *
     * @return string
     */
    public function getMail()
    {
        return $this->user->email;
    }

    /**
     * Get the language of the user
     *
     * @return string
     */
    public function getLanguage()
    {
        return '';
    }

    /**
     * Get the display-name of the user.
     */
    public function getDisplayName()
    {
        if ($this->user->fullname) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->user->fullname;
        }

        if (! $this->user->firstname && ! $this->user->lastname) {
            return $this->user->username;
        }

        if (! $this->user->firstname) {
            return $this->user->lastname;
        }

        return $this->user->firstname . ' ' . $this->user->lastname;
    }
}


1			<?php
2			/**
3			* Copyright (c)2013-2013 heiglandreas
4			*
5			* Permission is hereby granted, free of charge, to any person obtaining a copy
6			* of this software and associated documentation files (the "Software"), to deal
7			* in the Software without restriction, including without limitation the rights
8			* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9			* copies of the Software, and to permit persons to whom the Software is
10			* furnished to do so, subject to the following conditions:
11			*
12			* The above copyright notice and this permission notice shall be included in
13			* all copies or substantial portions of the Software.
14			*
15			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19			* LIBILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
21			* THE SOFTWARE.
22			*
23			* @category HybridAuth
24			* @author Andreas Heigl<[email protected]>
25			* @copyright ©2012-2013 Andreas Heigl
26			* @license http://www.opesource.org/licenses/mit-license.php MIT-License
27			* @version 0.0
28			* @since 11.01.13
29			* @link https://github.com/heiglandreas/HybridAuth
30			*/
31
32			namespace OrgHeiglHybridAuth;
33
34			use Hybridauth\Entity\Profile;
35			use OrgHeiglHybridAuth\UserInterface;
36			use SocialConnect\Common\Entity\User;
37
38			/**
39			* This class works as proxy to the HybridAuth-User-Object
40			*
41			* @category HybridAuth
42			* @author Andreas Heigl<[email protected]>
43			* @copyright ©2012-2013 Andreas Heigl
44			* @license http://www.opesource.org/licenses/mit-license.php MIT-License
45			* @version 0.0
46			* @since 11.01.13
47			* @link https://github.com/heiglandreas/HybridAuth
48			*/
49			class SocialAuthUserWrapper implements UserInterface
50			{
51			/**
52			* @var \SocialConnect\Common\Entity\User
53			*/
54			private $user;
55
56			public function __construct(User $user)
57			{
58			$this->user = $user;
59			}
60
61			/**
62			* Get the ID of the user
63			*
64			* @return string
65			*/
66			public function getUID()
67			{
68			return $this->user->id;
69			}
70
71			/**
72			* Get the name of the user
73			*
74			* @return string
75			*/
76			public function getName()
77			{
78			return $this->user->username;
79			}
80
81			/**
82			* Get the eMail-Address of the user
83			*
84			* @return string
85			*/
86			public function getMail()
87			{
88			return $this->user->email;
89			}
90
91			/**
92			* Get the language of the user
93			*
94			* @return string
95			*/
96			public function getLanguage()
97			{
98			return '';
99			}
100
101			/**
102			* Get the display-name of the user.
103			*/
104			public function getDisplayName()
105			{
106			if ($this->user->fullname) {
			0 ignored issues – show Bug Best Practice introduced 2017-02-14 15:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->user->fullname` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
107			return $this->user->fullname;
108			}
109
110			if (! $this->user->firstname && ! $this->user->lastname) {
111			return $this->user->username;
112			}
113
114			if (! $this->user->firstname) {
115			return $this->user->lastname;
116			}
117
118			return $this->user->firstname . ' ' . $this->user->lastname;
119			}
120			}
121

heiglandreas / HybridAuth

Pull Request — master (#33)

src/SocialAuthUserWrapper.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like