heidipatja / ramverk1-weather-module

config/di/weather_prog.php

<?php
/**
 * Configuration file for Weather
 */
return [
    // Services to add to the container.
    "services" => [
        "weather_prog" => [
            "shared" => true,
            "callback" => function () {
                $weatherProg = new \Hepa19\Weather\WeatherModel();
                $curl = new \Hepa19\Curl\Curl();
                $cfg = $this->get("configuration");

The variable $this seems to be never defined.

                if (file_exists(ANAX_INSTALL_PATH . "/config/api_weatherprog_config.php")) {
                    $config = $cfg->load("api_weatherprog_config.php");
                    $key = $config["config"]["apiKey"] ?? null;
                    $baseUrl = $config["config"]["baseUrl"] ?? null;
                    $options = $config["config"]["options"] ?? null;
                    $weatherProg->setCurl($curl);
                    $weatherProg->setApiKey($key);
                    $weatherProg->setBaseUrl($baseUrl);

It seems like $baseUrl can also be of type null; however, parameter $baseUrl of Hepa19\Weather\WeatherModel::setBaseUrl() does only seem to accept string, maybe add an additional type check?

                    $weatherProg->setUrlOptions($options);

It seems like $options can also be of type null; however, parameter $urlOptions of Hepa19\Weather\WeatherModel::setUrlOptions() does only seem to accept string, maybe add an additional type check?

                }

                return $weatherProg;
            }
        ],
    ],
];