heidipatja / ramverk1-weather-module

config/di/weather.php

<?php
/**
 * Configuration file for Weather
 */
return [
    // Services to add to the container.
    "services" => [
        "weather" => [
            "shared" => true,
            "callback" => function () {
                $weather = new \Hepa19\Weather\WeatherModel();
                $curl = new \Hepa19\Curl\Curl();
                $cfg = $this->get("configuration");

The variable $this seems to be never defined.

                if (file_exists(ANAX_INSTALL_PATH . "/config/api_weather_config.php")) {
                    $config = $cfg->load("api_weather_config.php");
                    $key = $config["config"]["apiKey"] ?? null;
                    $baseUrl = $config["config"]["baseUrl"] ?? null;
                    $options = $config["config"]["options"] ?? null;
                    $start = $config["config"]["start"] ?? null;
                    $stop = $config["config"]["stop"] ?? null;
                    $weather->setCurl($curl);
                    $weather->setApiKey($key);
                    $weather->setBaseUrl($baseUrl);

It seems like $baseUrl can also be of type null; however, parameter $baseUrl of Hepa19\Weather\WeatherModel::setBaseUrl() does only seem to accept string, maybe add an additional type check?

                    $weather->setUrlOptions($options);

It seems like $options can also be of type null; however, parameter $urlOptions of Hepa19\Weather\WeatherModel::setUrlOptions() does only seem to accept string, maybe add an additional type check?

                    $weather->setStartStop($start, $stop);

It seems like $stop can also be of type null; however, parameter $stop of Hepa19\Weather\WeatherModel::setStartStop() does only seem to accept integer, maybe add an additional type check?

It seems like $start can also be of type null; however, parameter $start of Hepa19\Weather\WeatherModel::setStartStop() does only seem to accept integer, maybe add an additional type check?

                }

                return $weather;
            }
        ],
    ],
];