Hechoenlaravel\JarvisFoundation\Http\Controllers\Core\FlowController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	5	1
A	store()	0	6	1
A	update()	0	6	1

<?php

namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;

use Hechoenlaravel\JarvisFoundation\Flows\Flow;
use Hechoenlaravel\JarvisFoundation\Http\Requests;
use Hechoenlaravel\JarvisFoundation\Traits\FlowManager;
use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
use Hechoenlaravel\JarvisFoundation\Flows\Transformers\FlowTransformer;

/**
 * Class FlowController
 * @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
 */
class FlowController extends Controller
{
    use FlowManager;


    /**
     * @param Requests\FlowRequest $request
     * @return mixed
     */
    public function store(Requests\FlowRequest $request)
    {
        $flow = $this->createFlow($request->all());
        $response = fractal()->item($flow, new FlowTransformer)->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($flow, new \Hechoenlaravel\JarvisFoundation\Flows\Transformers\FlowTransformer())->toArray() on line 27 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param Requests\FlowRequest $request
     * @param $id
     * @return mixed
     */
    public function update(Requests\FlowRequest $request, $id)
    {
        $flow = $this->updateFlow(Flow::findOrFail($id), $request->all());
        $response = fractal()->item($flow, new FlowTransformer)->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($flow, new \Hechoenlaravel\JarvisFoundation\Flows\Transformers\FlowTransformer())->toArray() on line 39 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param $id
     * @return mixed
     */
    public function destroy($id)
    {
        $this->deleteFlow(Flow::findOrFail($id));
        return response()->json(null, 204);
    }
}