Hechoenlaravel\JarvisFoundation\Http\Controllers\Core\FieldsController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	126
Duplicated Lines	15.87 %

Coupling/Cohesion

Components	2
Dependencies	9

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	5	1
A	__construct()	0	4	1
A	store()	10	10	1
A	show()	0	5	1
A	update()	10	10	1
A	destroy()	0	5	1
A	fieldTypeForm()	0	5	1
A	setFieldType()	0	8	2
A	reOrderFieldId()	0	5	1

<?php

namespace Hechoenlaravel\JarvisFoundation\Http\Controllers\Core;

use Illuminate\Http\Request;
use Hechoenlaravel\JarvisFoundation\Traits\EntityManager;
use Hechoenlaravel\JarvisFoundation\FieldGenerator\FieldModel;
use Hechoenlaravel\JarvisFoundation\Http\Controllers\Controller;
use Hechoenlaravel\JarvisFoundation\Http\Requests\EditFieldRequest;
use Hechoenlaravel\JarvisFoundation\Http\Requests\CreateFieldRequest;
use Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException;
use Hechoenlaravel\JarvisFoundation\FieldGenerator\Transformers\FieldTransformer;

/**
 * Class FieldsController
 * @package Hechoenlaravel\JarvisFoundation\Http\Controllers\Core
 */
class FieldsController extends Controller
{
    use EntityManager;


    /**
     * @var FieldModel
     */
    protected $model;

    /**
     * @var
     */
    protected $fieldType;

    /**
     * FieldsController constructor.
     * @param FieldModel $model
     */
    public function __construct(FieldModel $model)
    {
        $this->model = $model;
    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function index($id)
    {
        $model = $this->model->byEntity($id)->orderBy('order', 'ASC');
        return response()->json(fractal()->collection($model->get(), new FieldTransformer())->toArray());

It seems like fractal()->collection($model->get(), new \Hechoenlaravel\JarvisFoundation\FieldGenerator\Transformers\FieldTransformer())->toArray() targeting Spatie\Fractalistic\Fractal::toArray() can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param CreateFieldRequest $request
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function store(CreateFieldRequest $request, $id)

This method seems to be duplicated in your project.

    {
        $data = $request->all();
        $data['entity_id'] = $id;
        $field = $this->generateField($data);
        $response = fractal()->item($field, new FieldTransformer())
            ->addMeta(['return_url' => $data['returnUrl']])
            ->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($field, new \Hechoenlaravel\JarvisFoundation\FieldGenerator\Transformers\FieldTransformer())->addMeta(array('return_url' => $data['returnUrl']))->toArray() on line 62 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }

    /**
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function show($id)
    {
        $response = fractal()->item($this->model->findOrFail($id), new FieldTransformer())->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($this->model->findOrFail($id), new \Hechoenlaravel\JarvisFoundation\FieldGenerator\Transformers\FieldTransformer())->toArray() on line 74 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }


    /**
     * @param EditFieldRequest $request
     * @param $id
     * @param $fields
     * @return \Illuminate\Http\JsonResponse
     */
    public function update(EditFieldRequest $request, $id, $fields)

The parameter $id is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $data = $request->all();
        $data['id'] = $fields;
        $field = $this->editField($data);
        $response = fractal()->item($field, new FieldTransformer())
            ->addMeta(['return_url' => $data['returnUrl']])
            ->toArray();
        return response()->json($response);

It seems like $response defined by fractal()->item($field, new \Hechoenlaravel\JarvisFoundation\FieldGenerator\Transformers\FieldTransformer())->addMeta(array('return_url' => $data['returnUrl']))->toArray() on line 90 can also be of type null; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }


    /**
     * @param $id
     * @param $fields
     * @return \Illuminate\Http\JsonResponse
     */
    public function destroy($id, $fields)

The parameter $id is not used and could be removed.

    {
        $this->deleteField($fields);
        return response()->json(null, 204);
    }


    /**
     * @param $type
     * @return \Illuminate\Http\JsonResponse
     */
    public function fieldTypeForm($type)
    {
        $this->setFieldType($type);
        return response()->json(['form' => $this->fieldType->getOptionsForm()]);
    }


    /**
     * @param $type
     */
    private function setFieldType($type)
    {
        $fieldTypes = app('field.types');
        if (!isset($fieldTypes->types[$type])) {
            throw new NotAcceptableHttpException('El field type ' . $type . ' no esta registrado');
        }
        $this->fieldType = app($fieldTypes->types[$type]);
    }


    /**
     * @param Request $request
     * @param $id
     * @return \Illuminate\Http\JsonResponse
     */
    public function reOrderFieldId(Request $request, $id)

The parameter $id is not used and could be removed.

    {
        $this->reOrderField($request->get('items'));
        return response()->json(['ok' => true]);
    }
}