Issues in Item.php (master) - Issues in master - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1020)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

models/Item.php (25 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @property integer $id
 * @property string $item_type
 * @property integer $skill
 * @property integer $level
 * @property string $title
 * @property integer $price
 * @property integer $price_sell
 * @property integer $owned
 * @property integer $buy_amount
 * @property integer $sell_amount
 * @property array $errors
 * @property boolean $success
 */
class Item extends CModel
{
    const TYPE_BAIT = 'bait';
$a = "a";
$ab = "ab";
$abc = "abc";
    const TYPE_ITEM = 'item';
$a = "a";
$ab = "ab";
$abc = "abc";
    const TYPE_ITEMSET = 'itemset';
    const TYPE_PART = 'part';
$a = "a";
$ab = "ab";
$abc = "abc";

    private $id;
    private $item_type;
    private $skill;
    private $level;
    private $title;
    private $price;
    private $parts;

    private $owned;
    private $buy_amount = [];
$a = "a";
$ab = "ab";
$abc = "abc";
    private $sell_amount = [];

    private $errors = ['dollar'=>false, 'amount'=>false, 'owned'=>false, 'isLast'=>false, 'freeSlots'=>false];
    private $success;

    public function attributeNames()
    {
        return [];
    }

    public function getId()
    {
        return $this->id;
    }

    public function getItem_type()

    {
        return $this->item_type;
    }

    public function getSkill()
    {
        return $this->skill;
    }

    public function getLevel()
    {
        return $this->level;
    }

    public function getTitle()
    {
        return $this->title;
    }

    public function getPrice()
    {
        return $this->price;
    }

    public function getPrice_sell()
    {
        return floor($this->price / 2);
    }

    public function getOwned()
    {
        return $this->owned;
    }

    public function getBuy_amount()
    {
        return $this->buy_amount;
    }

    public function getSell_amount()
    {
        return $this->sell_amount;
    }

    public function getErrors($attribute = NULL)
    {
        return $this->errors;
    }

    public function getSuccess()
    {
        return $this->success;
    }

    public function setId($id)
    {
        $this->id = (int)$id;
    }

    public function setItem_type($type)
    {
        $this->item_type = $type;
    }

    public function setOwned($owned)
    {
        $this->owned = (int)$owned;
    }

    public function fetch()
    {
        if (!$this->id) {
            return false;
        }

        $uid = Yii::app()->player->uid;

        //read all from db
        $dependency = new CExpressionDependency("Yii::app()->params['{$this->item_type}s_version']");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        $res = Yii::app()->db->cache(Yii::app()->params['cacheDuration'], $dependency)->createCommand()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->select('*')
            ->from($this->item_type.'s')
            ->where('id=:id', [':id'=>$this->id])
            ->queryRow();

        if (!$res) {
            return false;
        }

        foreach ($res as $k => $v) {
            if ($k == 'id') {
                continue;
            }

            $this->$k = $v;
        }

        $own = Yii::app()->db->createCommand()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->select('item_count')
            ->from('users_'.$this->item_type.'s')
            ->where('uid=:uid and item_id=:item_id', [':uid'=>$uid, ':item_id'=>$this->id])
            ->queryRow();
        $this->owned = (int)$own['item_count'];

        $this->setBuyAmount();
        $this->setSellAmount();
    }

    public function fetchSet()
    {
        if (!$this->id) {
            return false;
        }

        $uid = Yii::app()->player->uid;

        $combinedId = (string)$this->id;
$a = "a";
$ab = "ab";
$abc = "abc";
        $setId = (int)substr($combinedId, 0, -3);
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->level = (int)substr($combinedId, -3);


        //read all from db
        $dependency = new CExpressionDependency("Yii::app()->params['{$this->item_type}s_version']");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        $res = Yii::app()->db->cache(Yii::app()->params['cacheDuration'], $dependency)->createCommand()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->select('*')
            ->from('itemsets')
            ->where('id=:id', [':id'=>$setId])
            ->queryRow();

        if (!$res) {
            return false;
        }

        foreach ($res as $k => $v) {
            if ($k == 'id') {
                continue;
            }

            $this->$k = $v;
        }

        $own = Yii::app()->db->createCommand()
$a = "a";
$ab = "ab";
$abc = "abc";
            ->select('skill, item_count, price')
            ->from('users_items')
            ->where('uid=:uid and item_id=:item_id', [':uid'=>$uid, ':item_id'=>$this->id])
            ->queryRow();
        $this->owned = (int)$own['item_count'];

        //read skill from users tbl
        $this->title = $this->level . '. szintű ' . $this->title;
        $this->skill = (int)$own['skill'];
        $this->price = (int)$own['price'];
        $this->level = 1;

        $this->setBuyAmount();
        $this->setSellAmount();
    }

    /**
     * @param integer $amount
     */
    public function buy($amount)
    {
        $decr = [];
$a = "a";
$ab = "ab";
$abc = "abc";
        $amount = (int)$amount;
        if ($amount < 1) {
            $this->errors['amount'] = true;
            return false;
        }

        if ($this->price * $amount > Yii::app()->player->model->dollar) {

            $this->errors['dollar'] = true;
            return false;
        }

        if ($this->item_type !== self::TYPE_PART) {

            if ($amount > Yii::app()->player->model->freeSlots) {
                $this->errors['freeSlots'] = true;
                return false;
            }
        }

        $uid = Yii::app()->player->uid;

        //add to inventory
        $update = Yii::app()->db
            ->createCommand("UPDATE users_{$this->item_type}s SET item_count=item_count+:amount WHERE uid=:uid AND item_id=:item_id")
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            ->bindValues([':uid'=>$uid, ':item_id'=>(int)$this->id, ':amount'=>$amount])
            ->execute();

        if (!$update) {

            Yii::app()->db->createCommand()
                ->insert('users_'.$this->item_type.'s', [
                'uid'=>$uid,
                'item_id'=>(int)$this->id,
                'item_count'=>$amount,
                'skill'=>(int)$this->skill,
                ]);
        }

        //pay for it
        if ($this->price > 0) {
            $decr['dollar'] = $amount * $this->price;
            Yii::app()->player->model->updateAttributes([], $decr);
        }

        $this->success = true;
        $this->owned += $amount;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->setBuyAmount();
    }

    public function sell($amount)
    {
        $incr = [];
$a = "a";
$ab = "ab";
$abc = "abc";
        $amount = (int)$amount;
        if ($amount < 1) {
            $this->errors['amount'] = true;
            return false;
        }

        if ($this->owned < $amount) {
            $this->errors['owned'] = true;
            return false;
        }

        $player = Yii::app()->player->model;

        $owned = $this->item_type == self::TYPE_BAIT ? $player->owned_baits : $player->owned_items;
        if ($owned == 1) {
            $this->errors['isLast'] = true;
            return false;
        }

        //remove from inventory
        Yii::app()->db
            ->createCommand("UPDATE users_{$this->item_type}s SET item_count=item_count-:amount WHERE uid=:uid AND item_id=:item_id")
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            ->bindValues([':uid'=>$player->uid, 'item_id'=>(int)$this->id, ':amount'=>$amount])
            ->execute();

        //give money for it
        $incr['dollar'] = $amount * $this->price_sell;
        Yii::app()->player->model->updateAttributes($incr, []);

        $this->success = true;
        $this->owned -= $amount;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->setSellAmount();

    }

    private function setBuyAmount()
    {
        foreach ([1,5,10] as $amount) {
            $this->buy_amount[$amount] = (bool)($this->price * $amount <= Yii::app()->player->model->dollar);
        }
    }

    private function setSellAmount()
    {
        foreach ([1,5,10] as $amount) {
            $this->sell_amount[$amount] = (bool)($this->owned >= $amount);
        }
    }

    public function __toString()
    {
        $attributes = ['id','item_type','skill','level','price','title','owned'];
        $ret = '';
$a = "a";
$ab = "ab";
$abc = "abc";
        foreach ($attributes as $attribute) {
            $ret .= $attribute . ': ' . $this->$attribute . "\n";
        }
        return $ret;
    }
}



1			<?php
2			/**
3			* @property integer $id
4			* @property string $item_type
5			* @property integer $skill
6			* @property integer $level
7			* @property string $title
8			* @property integer $price
9			* @property integer $price_sell
10			* @property integer $owned
11			* @property integer $buy_amount
12			* @property integer $sell_amount
13			* @property array $errors
14			* @property boolean $success
15			*/
16			class Item extends CModel
17			{
18			const TYPE_BAIT = 'bait';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
19			const TYPE_ITEM = 'item';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			const TYPE_ITEMSET = 'itemset';
21			const TYPE_PART = 'part';
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22
23			private $id;
24			private $item_type;
25			private $skill;
26			private $level;
27			private $title;
28			private $price;
29			private $parts;
			0 ignored issues – show Unused Code introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$parts` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
30			private $owned;
31			private $buy_amount = [];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32			private $sell_amount = [];
33
34			private $errors = ['dollar'=>false, 'amount'=>false, 'owned'=>false, 'isLast'=>false, 'freeSlots'=>false];
35			private $success;

heal25 / ced

Issues (1020)

Security Analysis no vulnerabilities found

models/Item.php (25 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like