Issues in Forum.php (master) - Issues in master - heal25/ced - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1020)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

models/Forum.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @property integer $id
 * @property CPagination $pagination
 * @property integer $count
 * @property array $items
 * @property integer $page
 * @property boolean $private
 */
class Forum extends CModel
{
    private $id;
    private $items = [];
    private $page = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
    private $pagination;
    private $count;
    private $private = false;

    public function attributeNames()
    {
        return [];
    }
    
    public function getId()
    {
        return (int)$this->id;
    }

    public function getPagination()
    {
        return $this->pagination;
    }

    public function getCount()

    {
        return $this->count;
    }

    public function getItems()
    {
        return $this->items;
    }
      
    public function setId($id)
    {
        $this->id = (int)$id;
    }

    public function setPage($page)
    {
        $this->page = $page;
    }

    public function setPrivate($private)
    {
        $this->private = (bool)$private;
    }

    public function fetchItems()
    {
        $player = Yii::app()->player->model;
        $limit = Yii::app()->params['listPerPage'];
$a = "a";
$ab = "ab";
$abc = "abc";
        
        $fetchPrivates = $this->id !== $player->in_club ? ' AND private=0' : '';

        $this->count = Yii::app()->db->createCommand()
            ->select('COUNT(*) AS count')
            ->from('forum')
            ->where('club_id = :id'.$fetchPrivates, [':id'=>$this->id])
            ->queryScalar();
        
        $res = Yii::app()->db->createCommand()
            ->select('*')
            ->from('forum')
            ->where('club_id = :id'.$fetchPrivates, [':id'=>$this->id])
            ->order('id DESC')
            ->limit($limit, ($this->page * $limit) - $limit) // the trick is here!
            ->queryAll();
        
        $this->pagination = new CPagination($this->count);
        $this->pagination->setPageSize(Yii::app()->params['listPerPage']);

        $this->items = $res;
    }

    public function save($post, $isMentor = false)
    {
        if (!$isMentor) {
            $post = trim($post);
            $post = strip_tags($post);
            $post = htmlspecialchars($post);
            $post = substr($post, 0, 800);
        }

        if (!$post) {
            return false;
        }

        $player = Yii::app()->player->model;
        $uid = $isMentor ? 1 : $player->uid;
$a = "a";
$ab = "ab";
$abc = "abc";
        $user = $isMentor ? 'Áron bá' : $player->user;
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($uid > 1 && $player->in_club != $this->id) {
            return false; //nem klubtag, nem mentor
        }

        $parameters = [
            'club_id'=>$this->id,
            'uid'=>$uid,
            'user'=>$user,
            'body'=>$post,
            'private'=>$this->private
            ];

        Yii::app()->db->createCommand()
                ->insert('forum', $parameters);

        $parameters['created'] = 'most';
        array_unshift($this->items, $parameters);
        return true;
    }

    public function delete($id)
    {
        if (!$id) {
            return false;
        }

        $player = Yii::app()->player->model;
        if ($player->in_club != $this->id) {
            return false; //nem klubtag, nem mentor
        }

        Yii::app()->db->createCommand()->delete(
            'forum',
            'id=:id AND uid=:uid',
            [':id'=>(int)$id, ':uid'=>Yii::app()->player->model->uid]
        );

        return true;
    }
}



1			<?php
2			/**
3			* @property integer $id
4			* @property CPagination $pagination
5			* @property integer $count
6			* @property array $items
7			* @property integer $page
8			* @property boolean $private
9			*/
10			class Forum extends CModel
11			{
12			private $id;
13			private $items = [];
14			private $page = 0;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
15			private $pagination;
16			private $count;
17			private $private = false;
18
19			public function attributeNames()
20			{
21			return [];
22			}
23
24			public function getId()
25			{
26			return (int)$this->id;
27			}
28
29			public function getPagination()
30			{
31			return $this->pagination;
32			}
33
34			public function getCount()
			0 ignored issues – show Documentation introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
35			{
36			return $this->count;
37			}
38
39			public function getItems()
40			{
41			return $this->items;
42			}
43
44			public function setId($id)
45			{
46			$this->id = (int)$id;
47			}
48
49			public function setPage($page)
50			{
51			$this->page = $page;
52			}
53
54			public function setPrivate($private)
55			{
56			$this->private = (bool)$private;
57			}
58
59			public function fetchItems()
60			{
61			$player = Yii::app()->player->model;
62			$limit = Yii::app()->params['listPerPage'];
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
63
64			$fetchPrivates = $this->id !== $player->in_club ? ' AND private=0' : '';
65
66			$this->count = Yii::app()->db->createCommand()
67			->select('COUNT(*) AS count')
68			->from('forum')
69			->where('club_id = :id'.$fetchPrivates, [':id'=>$this->id])
70			->queryScalar();
71
72			$res = Yii::app()->db->createCommand()
73			->select('*')
74			->from('forum')
75			->where('club_id = :id'.$fetchPrivates, [':id'=>$this->id])
76			->order('id DESC')
77			->limit($limit, ($this->page * $limit) - $limit) // the trick is here!
78			->queryAll();
79
80			$this->pagination = new CPagination($this->count);
81			$this->pagination->setPageSize(Yii::app()->params['listPerPage']);
82
83			$this->items = $res;
84			}
85
86			public function save($post, $isMentor = false)
87			{
88			if (!$isMentor) {
89			$post = trim($post);
90			$post = strip_tags($post);
91			$post = htmlspecialchars($post);
92			$post = substr($post, 0, 800);
93			}
94
95			if (!$post) {
96			return false;
97			}
98
99			$player = Yii::app()->player->model;
100			$uid = $isMentor ? 1 : $player->uid;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
101			$user = $isMentor ? 'Áron bá' : $player->user;
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
102			if ($uid > 1 && $player->in_club != $this->id) {
103			return false; //nem klubtag, nem mentor
104			}
105
106			$parameters = [
107			'club_id'=>$this->id,
108			'uid'=>$uid,
109			'user'=>$user,
110			'body'=>$post,
111			'private'=>$this->private
112			];
113
114			Yii::app()->db->createCommand()
115			->insert('forum', $parameters);
116
117			$parameters['created'] = 'most';
118			array_unshift($this->items, $parameters);
119			return true;
120			}
121
122			public function delete($id)
123			{
124			if (!$id) {
125			return false;
126			}
127
128			$player = Yii::app()->player->model;
129			if ($player->in_club != $this->id) {
130			return false; //nem klubtag, nem mentor
131			}
132
133			Yii::app()->db->createCommand()->delete(
134			'forum',
135			'id=:id AND uid=:uid',
136			[':id'=>(int)$id, ':uid'=>Yii::app()->player->model->uid]
137			);
138
139			return true;
140			}
141			}
			0 ignored issues – show Coding Style introduced 2016-04-25 05:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
142

heal25 / ced

Issues (1020)

Security Analysis no vulnerabilities found

models/Forum.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like